From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE77CC47082 for ; Thu, 3 Jun 2021 14:20:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF78C613BA for ; Thu, 3 Jun 2021 14:20:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF78C613BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DG/IoxM7WP94C0FuTd70m7RZq9I/HixFBLy3fQQrej8=; b=QeNmb+6gi+RmpxDg5/oI6vEPXQ n8UwQTX03kKMNS6lDPo9wCTt7cgDfVBeBSH8jm83UwnPeLyecLmqtBDxUnnSxYI1inEHxfRyuwsjQ SAVzFQhhEZJ1DrxvsxGqiTvtzdDoRpYBpwwCUlvJf/zLhUyY6GJMXJ8KVfTZQFR3330VQQaL/he6G 1sfoGRaPRnZaVki6EXayMzQGUVX7izEmL+9UFQRg1Y9DN+PV45DdhatLz0tnzaRMfAreXUf3NEMK4 3WwS0yiNpZfrDUoQqxWO+n+SDc5UuQ3uPPdmoibxC+ZiXxk/ugXp13pcepAlLEmMvXafjpnJxV8Y+ mWaDfT8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1looBY-0095pm-8K; Thu, 03 Jun 2021 14:19:00 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1looBU-0095oU-LI for linux-arm-kernel@lists.infradead.org; Thu, 03 Jun 2021 14:18:58 +0000 Received: by mail-ej1-x634.google.com with SMTP id b9so9437753ejc.13 for ; Thu, 03 Jun 2021 07:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tub/4A1Ldp0doIeEbmBbVu6oAKbNZfp1WJZosekTKkc=; b=dscUc9TVcSoBWWqro6OIsaQZfbSfG/rarxHo0R2YaesEtBsR6sO5qXfJqMxz9V4fxE rKLW3V8qpJ/7iz+1mCbPxCdja7o0Q/pry5jKcpsOWrpe4jur1aMLyEHsS6XQbxRwq7mr 3Wz1n1C8HWSMnj0fWjPs1SqLEOC20lunSumVi91aSHL+jBAXk3T3sxijZZGfRB7rn5vj IeSe8gKwukDIU1HnSBlqW5MMZ97cZZfA/3ya86xweFe/JrUptlbgjHJYIaVwRxx+lmhH Vy9qMjtXu9GaV7K/q+gOz9r6CoUdEmmZrnYP+UnotFYCDamyrvEZMI8udZ4NeMUsEqGq xg/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tub/4A1Ldp0doIeEbmBbVu6oAKbNZfp1WJZosekTKkc=; b=r7tXhQLQiYpnZU4sEAKDpttULmOc1o5542qtsJS38u6Ht0K9qQokDGdHFYGb/pLsLy D4RZL2BgybrMqfmztreY1DxyAf+Mr06PRB4xWhjJTpeJlEZXQPR3g/9uKA5WlR1scFLr BV4+45n1DHu+G/ttp/0//KDHBYn+XhcSAl0KM/6aocfknPA4PSHzAFDU/w4XJCU73Xpy Pbwow6FlufFT85TP9QNyvXoLvLACfxXfXZ4RtfnwBoA/zVI4mRgVhhHNUGueslrs2Raf 4bwxW0GMapUhlXJceyYD+y0SL6QXkzTcJ+6K47sWdelzH0Im6Q3+IrwqVWBxoWsIWyJR 216A== X-Gm-Message-State: AOAM5302YeAUE05QNLzB4G4eKO19I0o2bW1sYXb0PhKG7EYk6TiHS+24 hGCgp/euyedmofCLx3n4YDY= X-Google-Smtp-Source: ABdhPJwr6Ij8uvak3IHGofE/gdNx7SYiNeWGcYR4EZtxiByBFvJyW/hchMvIenwfXZ8TmkIW6HN8tg== X-Received: by 2002:a17:906:8318:: with SMTP id j24mr20601777ejx.375.1622729932620; Thu, 03 Jun 2021 07:18:52 -0700 (PDT) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id bd3sm1858706edb.34.2021.06.03.07.18.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 07:18:50 -0700 (PDT) Date: Thu, 3 Jun 2021 16:20:27 +0200 From: Thierry Reding To: Lee Jones Cc: "Russell King (Oracle)" , Boris Ostrovsky , Guenter Roeck , arm@kernel.org, Arnd Bergmann , Olof Johansson , Stefan Agner , Wolfram Sang , Catalin Marinas , Lorenzo Pieralisi , linux-arm-kernel , open list , Stefano Stabellini Subject: Re: [PATCH 2/6] ARM: xen: Register with kernel restart handler Message-ID: References: <20191015145147.1106247-1-thierry.reding@gmail.com> <20191015145147.1106247-3-thierry.reding@gmail.com> <20210603131124.GA1040254@roeck-us.net> <20210603133840.GB2435141@dell> <7a1cf301-ba99-1e01-c43e-53b53f4d3e04@oracle.com> <20210603135608.GU30436@shell.armlinux.org.uk> <20210603140301.GC2435141@dell> MIME-Version: 1.0 In-Reply-To: <20210603140301.GC2435141@dell> User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210603_071856_741563_6A64B3C8 X-CRM114-Status: GOOD ( 50.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5215077780610940439==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5215077780610940439== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ts8oacsaxkBHlaSj" Content-Disposition: inline --ts8oacsaxkBHlaSj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 03, 2021 at 03:03:01PM +0100, Lee Jones wrote: > On Thu, 03 Jun 2021, Russell King (Oracle) wrote: >=20 > > On Thu, Jun 03, 2021 at 09:48:59AM -0400, Boris Ostrovsky wrote: > > > On 6/3/21 9:38 AM, Lee Jones wrote: > > > > On Thu, 03 Jun 2021, Guenter Roeck wrote: > > > > > > > >> On Thu, Jun 03, 2021 at 01:43:36PM +0100, Lee Jones wrote: > > > >>> On Tue, 15 Oct 2019 at 15:52, Thierry Reding > > > >>> wrote: > > > >>> > > > >>>> From: Guenter Roeck > > > >>>> > > > >>>> Register with kernel restart handler instead of setting arm_pm_r= estart > > > >>>> directly. > > > >>>> > > > >>>> Select a high priority of 192 to ensure that default restart han= dlers > > > >>>> are replaced if Xen is running. > > > >>>> > > > >>>> Acked-by: Arnd Bergmann > > > >>>> Reviewed-by: Wolfram Sang > > > >>>> Reviewed-by: Stefano Stabellini > > > >>>> Signed-off-by: Guenter Roeck > > > >>>> Signed-off-by: Thierry Reding > > > >>>> --- > > > >>>> arch/arm/xen/enlighten.c | 12 ++++++++++-- > > > >>>> 1 file changed, 10 insertions(+), 2 deletions(-) > > > >>>> > > > >>> This patch does appear to be useful. > > > >>> > > > >>> Is this just being solved in downstream trees at the moment? > > > >>> > > > >>> It would be nice if we could relinquish people of this burden and= get it > > > >>> into Mainline finally. > > > >>> > > > >> There must have been half a dozen attempts to send this patch seri= es > > > >> upstream. I have tried, and others have tried. Each attempt failed= with > > > >> someone else objecting for non-technical reasons (such as "we need= more > > > >> reviews") or no reaction at all, and maintainers just don't pick i= t up. > > > > Looking at the *-by tag list above, I think we have enough quality > > > > reviews to take this forward. > > > > > > > >> So, yes, this patch series can only be found in downstream trees, > > > >> and it seems pointless to submit it yet again. > > > > IMHO, it's unfair to burden multiple downstream trees with this pur= ely > > > > due to poor or nervy maintainership. Functionality as broadly usef= ul > > > > as this should be merged and maintained in Mainline. > > > > > > > > OOI, who is blocking? As I see it, we have 2 of the key maintainers > > > > in the *-by list. With those on-board, it's difficult to envisage > > > > what the problem is. > > >=20 > > >=20 > > > Stefano (who is ARM Xen maintainer) left Citrix a while ago. He is at= sstabellini@kernel.org (which I added to the CC line). > >=20 > > Stefano already reviewed this patch, which is part of a larger series > > that primarily touches 32-bit ARM code, but also touches 64-bit ARM > > code as well. > >=20 > > As I said in my previous reply, I don't see that there's any problem > > with getting these patches merged had the usual processes been > > followed - either ending up in the patch system, or the pull request > > being sent to me directly. > >=20 > > Sadly, the pull request was sent to the arm-soc people excluding me, > > I happened to notice it and requested to see the patches that were > > being asked to be pulled (since I probably couldn't find them)... > > and it then took two further weeks before the patches were posted, > > which I then missed amongst all the other email. > >=20 > > It's a process failure and unfortunate timing rather than anything > > malicious. >=20 > Understood. >=20 > Is there anything I can do to help this forward? >=20 > I can either collect and re-submit the patches to the MLs if that > makes people's lives any easier. Or if one of the original submitters > wish to retain responsibility, I have no qualms with that either. I had stumbled across these patches from Guenter when I was looking to solve a reboot/power-off issue on one of the boards that I was working on. This was supposed to be preparatory work to get rid of the global function pointers that drivers are simply overwriting, and the goal had been to add a "system power" framework that would allow drivers to register a chip structure to provide a bit more "formality" than overwriting function pointers or registering notifier callbacks. There ended up not being any interest in such a subsystem, so I wanted to at least get this prep work in, because it is at least a bit of an improvement. I vaguely recall that Arnd or perhaps Olof had mentioned that they'd pull these patches, but the timing was bad, so they asked me to remind them after the merge window. By the time we had gotten through the merge window, I probably had gotten sidetracked and forgot... Feel free to give this a shot. This series itself is still useful, in my opinion. Thierry --ts8oacsaxkBHlaSj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmC45SkACgkQ3SOs138+ s6ETyA/9HEm2JR4h4HDcPjniQnuX58wQLgyp7ttzgnIxg4j03+GJDk+IsR2AnTtP xc430zlM3efExiIBqnLCZ+pOmgnLht+YXHQz59JAL9Xt9CUyfDkxJ2zXvJhOLP3d XJpFso39Eh2tdH1E9aNg7nM7P1ZnPrWLQGxbZLEYW0gopY+3NPfO+Zq1oC9lUilx xt30nlN2iK9tiJYgEX2fmIV68DvY8zY+P8i5DYEj4Vq/3R2ssAqviR8WIf6qgqYW 2mQrnYECdmWnFORqTd0Qqx0q64rpC6LxYxJha9yZBvcl0xQaM0JPl8qcm/vQWiFq 93czgnQ4RUPb4Eiz7xbyr9IJlX6suM0VnBzzkAg+lFugIoQbMOfHLzTav8VWk2an 9AAspFsjLHMOoaU7FYRmCtoZFqheq6iZbplpZMx42J4iQhAazJtG8IiOVkAjUAzq c2umgTeYOuu/28UhBg4oCsVucnMAxh2WWYShCDnHImPLSg9zHHEQamfc1YYNgi5z RMLpVYXJ2gnft1byQJX1sHYpjH4dWtYUONG7HDittpG/98UIaOjQ7UciIKWra5F9 jWZ2bK/At3bweCYfgnB6rhfINM5Hb2HljgbVZSXQlozhtosuhrHP4r/IhkbEPCJh o7/9HNattJzPPk2rL5I16ljQjJYbDsw45Z+vXdVgqNegEUEAfBY= =gyeu -----END PGP SIGNATURE----- --ts8oacsaxkBHlaSj-- --===============5215077780610940439== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5215077780610940439==--