From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37754C48BE0 for ; Fri, 11 Jun 2021 21:41:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB86B610E6 for ; Fri, 11 Jun 2021 21:41:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB86B610E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PGPBIcziphkI9VfNTK7x2n9MJY6gnpaXLteL2zQtikc=; b=fvbmgaTjiBWRIm eLOUUIjN+orhyEHhibOhYZoFcn3RsDklKhm7NQABQhzVkLa0sG9Wk45TpB/+oNd4AzVvrWEza7AgI jXnuWD9tRLfiZmUpH8qscRo5IJ+sA2a1B8tN57MovDqejff/j1qok+PYNym89hrDrNfkAu5jgi4YQ 3Aqc2k3Om1txQA6aEafOwhDF79ExGviAZTy0cTYE0rvswjwSwfQxIJnuJgx4/+98eJRuswKOHWhNI OY9hPSJesvgm4+6leNrPcH6qfSkh/5PLEqz54Ee7L0stfv4FjhgkKWSesjsF0zsYB7IIWXKcljt8B 6OjE7cw5ssYg1iYns9Dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrosk-007Cjf-Sn; Fri, 11 Jun 2021 21:40:03 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrosh-007Cih-Ax for linux-arm-kernel@lists.infradead.org; Fri, 11 Jun 2021 21:40:00 +0000 Received: by mail-wr1-x435.google.com with SMTP id f2so7423682wri.11 for ; Fri, 11 Jun 2021 14:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to; bh=0QDb2/kUHVW8lv82h4iuCL3pJ9emh15XA/S11XTDQlU=; b=aeE/8vx6hRhekLT8QJRfxZsP54LVoH27wVXdVczEOp18demzyLWosFwxkXSrNB0Ckx Kg6SGhhbM0vloRCkHxlLUlXBg56/oETyUvFMwgdKI2qpr+oVVvBpI/1ZZ5bbuU3ijiGT IbmnXttBiQAyCGPFGvHtnDW246AvcS36WzXQvTbZmFhzpYTiYjrFnlA/nCRKBrIiuDhr +6r0kku4GCfJjO1BnGtVdOZTGslENKPYiaGhyPnR/QlcmJlPAOIYVdkaI9BN6erYOynk I7kCvA+OPOtXMjKzp88/KFEuP97nbbc9i5vDb18EQ7FDmARh9Nc6m9SRbrIJwogru54x Il5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to; bh=0QDb2/kUHVW8lv82h4iuCL3pJ9emh15XA/S11XTDQlU=; b=THSItr6CfKPRX2BQPEMIPt5loIzXH+RPGrsL9/MZhF2YDIMrjv5OuuSEAPlgx2DnUX vMvE5mAz5Jpk6Gh5pBkSWXMHVCYE9FRm49M4ot1gxJ/e8bHILGqIMt89iy/LwhJ9dnjQ 7jre3OZ++UY2u2dDeVaeRGsCFgbOWXoxjLOgTVPGfiIOvmaDpcXs6BsJ/hjRpaYyCZQ8 ph2+ElKpDzZZmWDg/Ypg3hfvDOubXLK9BoYHcDfSTwof54b2aQaKNSKG2X+MlaFA7er3 jkbKStcOvzUoxKbDU0YKeVy+eD22kvTUOukgBQ0gi91NgyzPCPJBiltPBIYrG9ybtZgK Iffg== X-Gm-Message-State: AOAM533DMyByZxlR8t6SmSER2+7Ua7LStRLkERowb4tOa4XXKurzTRra IZP1ylxeW4O9opugmPjY720= X-Google-Smtp-Source: ABdhPJyca1xqNDS4eR9mwmhPXtMUXQqUGW+nIBEEgdkTQOMljFYGGjj1IJ+VsiXyuF/Ke+MQ/g+fIw== X-Received: by 2002:adf:b64a:: with SMTP id i10mr6097620wre.169.1623447596907; Fri, 11 Jun 2021 14:39:56 -0700 (PDT) Received: from pevik (gw.ms-free.net. [95.85.240.250]) by smtp.gmail.com with ESMTPSA id x3sm13522666wmj.30.2021.06.11.14.39.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 14:39:56 -0700 (PDT) Date: Fri, 11 Jun 2021 23:39:23 +0200 From: Petr Vorel To: Matthias Brugger Cc: Enric Balletbo i Serra , Catalin Marinas , Luo Longjun , will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sangyan@huawei.com, ningyu9@huawei.com, luchunhua@huawei.com Subject: Re: [PATCH] arm64: configs: remove redundant CONFIG_MTK_PMIC_WRAP Message-ID: References: <20210507182410.10515-1-luolongjun@huawei.com> <20210511172020.GB21033@arm.com> <6ef5c7a0-3596-a67c-c99d-c8e0def8a96a@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_143959_419718_F46C1944 X-CRM114-Status: GOOD ( 22.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, > Hi all, > On 11/05/2021 22:04, Enric Balletbo i Serra wrote: > > Hi Catalin, > > Thanks for cc'ing me. > > On 11/5/21 19:20, Catalin Marinas wrote: > >> On Sat, May 08, 2021 at 02:24:10AM +0800, Luo Longjun wrote: > >>> When I compile kernel in ARM64, it produces the following output: > >>> *** Default configuration is based on 'defconfig' > >>> arch/arm64/configs/defconfig:1018:warning: override: reassigning to > >>> symbol MTK_PMIC_WRAP > >>> After checking defcofnig, I found two CONFIG_MTK_PMIC_WRAP options. > >>> Signed-off-by: Luo Longjun > >>> --- > >>> arch/arm64/configs/defconfig | 1 - > >>> 1 file changed, 1 deletion(-) > >>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > >>> index 08c6f769df9a..9907a431db0d 100644 > >>> --- a/arch/arm64/configs/defconfig > >>> +++ b/arch/arm64/configs/defconfig > >>> @@ -491,7 +491,6 @@ CONFIG_SPI_S3C64XX=y > >>> CONFIG_SPI_SH_MSIOF=m > >>> CONFIG_SPI_SUN6I=y > >>> CONFIG_SPI_SPIDEV=m > >>> -CONFIG_MTK_PMIC_WRAP=m > >>> CONFIG_SPMI=y > >>> CONFIG_PINCTRL_SINGLE=y > >>> CONFIG_PINCTRL_MAX77620=y > >> Adding Matthias and Enric. This change looks fine to me but I think it > >> should go in via the arm-soc tree. Commit 9fd5449e061e introduced the =m > >> option while commit fbbe38309d56 introduced the =y variant. > >> You could add: > >> Fixes: fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot from usb") Reviewed-by: Petr Vorel I was going to send fix myself, I'd prefer also y, but weren't 100% sure sure. For a record: * CONFIG_MTK_PMIC_WRAP=m committed by author in 2021-01-04, merged 2021-01-31 15:31:01 9fd5449e061e ("arm64: configs: Support pwrap on Mediatek MT6779 platform") sent: 4 Jan 2021 https://lore.kernel.org/r/1609747703-27207-3-git-send-email-argus.lin@mediatek.com Applied to v5.11-next/defconfig 31 Jan 2021 15:32:26 by Matthias Brugger https://lore.kernel.org/linux-devicetree/5d5a67a5-ac2d-9ef9-b20c-66cbd55ebb8f@gmail.com/ * CONFIG_MTK_PMIC_WRAP=y was committed by author in 2021-03-31 11:06:57, merged 2021-03-31 12:12:59 fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot from usb") sent: 31 Mar 2021 11:06:57 https://lore.kernel.org/r/20210331090659.4169966-1-enric.balletbo@collabora.com But originally sent: 9 Feb 2021 10:11:11 https://lore.kernel.org/lkml/20210209091112.2075478-1-enric.balletbo@collabora.com/ Kind regards, Petr > > I sent the same patch some time ago [1]. > > I agree, either land this patch or mine. In any case, > > Reviewed-by: Enric Balletbo i Serra > > Matthias is this something that should go through your tree? > Yes, this should go through my tree. I'll take care of it. > Regards, > Matthias _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel