From: Mike Rapoport <rppt@linux.ibm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Qian Cai <quic_qiancai@quicinc.com>,
David Hildenbrand <david@redhat.com>,
Ard Biesheuvel <ardb@kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: Arm64 crash while reading memory sysfs
Date: Mon, 14 Jun 2021 11:25:54 +0300 [thread overview]
Message-ID: <YMcSkvXrsDMPLicd@linux.ibm.com> (raw)
In-Reply-To: <daaf6faa-b5c1-b201-28c9-07f8e1fe4a82@arm.com>
On Tue, Jun 08, 2021 at 12:36:21PM +0530, Anshuman Khandual wrote:
>
>
> On 5/28/21 10:43 AM, Mike Rapoport wrote:
> > On Thu, May 27, 2021 at 03:56:44PM -0700, Andrew Morton wrote:
> >> On Thu, 27 May 2021 18:50:48 +0100 Catalin Marinas <catalin.marinas@arm.com> wrote:
> >>
> >>>> Can you please try Anshuman's patch "arm64/mm: Drop HAVE_ARCH_PFN_VALID":
> >>>>
> >>>> https://lore.kernel.org/lkml/1621947349-25421-1-git-send-email-anshuman.khandual@arm.com
> >>>>
> >>>> It seems to me that the check for memblock_is_memory() in
> >>>> arm64::pfn_valid() is what makes init_unavailable_range() to bail out for
> >>>> section parts that are not actually populated and then we have
> >>>> VM_BUG_ON_PAGE(PagePoisoned(p)) for these pages.
> >>>
> >>> I acked Anshuman's patch, I think they all need to go in together.
> >>
> >> That's neat. Specifically which patches are we referring to here?
> >
> > arm64: drop pfn_valid_within() and simplify pfn_valid():
> > https://lore.kernel.org/lkml/20210511100550.28178-5-rppt@kernel.org
> >
> > arm64/mm: Drop HAVE_ARCH_PFN_VALID:
> > https://lore.kernel.org/lkml/1621947349-25421-1-git-send-email-anshuman.khandual@arm.com
>
> I dont see the above patch (which drops HAVE_ARCH_PFN_VALID on arm64) on linux-next
> i.e. next-20210607. I might have missed some earlier context here but do not we want
> to fallback on generic pfn_valid() after Mike's series ?
Andrew,
Can you please pick the two patches above?
--
Sincerely yours,
Mike.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-14 8:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 15:25 Arm64 crash while reading memory sysfs Qian Cai (QUIC)
2021-05-25 15:37 ` David Hildenbrand
2021-05-26 6:40 ` Mike Rapoport
2021-05-26 12:09 ` Qian Cai (QUIC)
2021-05-26 13:04 ` Catalin Marinas
2021-05-26 17:25 ` Mike Rapoport
2021-05-26 17:24 ` Mike Rapoport
2021-05-27 0:16 ` Qian Cai
2021-05-27 0:31 ` Andrew Morton
2021-05-27 7:25 ` Stephen Rothwell
2021-05-27 8:56 ` Mike Rapoport
2021-05-27 14:33 ` Qian Cai
2021-05-27 16:22 ` Mike Rapoport
2021-05-27 17:00 ` Qian Cai
2021-05-27 17:12 ` David Hildenbrand
2021-05-27 17:50 ` Catalin Marinas
2021-05-27 22:56 ` Andrew Morton
2021-05-28 5:13 ` Mike Rapoport
2021-06-08 7:06 ` Anshuman Khandual
2021-06-14 8:25 ` Mike Rapoport [this message]
2021-06-15 0:13 ` Andrew Morton
2021-06-15 6:05 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMcSkvXrsDMPLicd@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maz@kernel.org \
--cc=quic_qiancai@quicinc.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).