From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A79C2B9F4 for ; Mon, 14 Jun 2021 21:01:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F08D76134F for ; Mon, 14 Jun 2021 21:01:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F08D76134F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+FUW6Zb9zB1GK5oF8VZr8WBowaz4QacJ1Ne4qatFHT4=; b=W5lndBqoT0ujD7 aYfxv8V6BOninXIsdkJ7VPAkbt/JxnKaOsuVjvXcuuhpWYNdtVK0iMA34gZBiP++UUihgzD1cFwaM X83HaEPFHhdP6snS/6KIjKSBcy4h0LZl+t9hn2C54VQzklvYl8FxL3E4bDwqa4eNadRhlgNPpyHt3 WXcAmAF+x/25951tUENnhse96RwHj+MMAGYkzQMp9DlE7CPlfIGinxwKeQ69xXz7xhTfoHENkeWjc mTyYiOmZbhq0gGnw1Kgz5t8mw4n27tFDQjOQcAWPVFWaHdb2UOfk8CjLxpIuEr82b/l1rqRgvsC00 yAJjdlo13g1rRP4OnJ7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lstg2-00GBFO-EP; Mon, 14 Jun 2021 20:59:22 +0000 Received: from mail-oi1-x22a.google.com ([2607:f8b0:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lstfz-00GBCW-2Q for linux-arm-kernel@lists.infradead.org; Mon, 14 Jun 2021 20:59:20 +0000 Received: by mail-oi1-x22a.google.com with SMTP id r16so15412392oiw.3 for ; Mon, 14 Jun 2021 13:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/6pKbYj2ed0f0UaEFoaaIUYpFQjvxwrfEa8r7ccecLg=; b=VUcpHcO5+69x+UmFhBX81AvNnV4yZG99MUIPNECFwsScWTK9TaiV0hoCkGfUU7392i IdO3v0bqNtQ1pwOSOr5vbmkySR/9FlzDmozXlGeRfxcECdSsPUtEdGP3mmVqo+gbFuSx I/hgEmF4rADrAYt7llABIPizW00BM03GI/jxEkEFQMC+ceuxqkSY3x0i97Kt4IXrHsd4 i7QlXM1QDPv+NcO410O/yjq72NZY5qV2iCblFogQg9l3bPUMsde5DdeS/BiL7PNGRux8 woxP/GxKqD7irINk0gd14N5PWdLSw9pnWtKhqYVsYiQzD1BvT2DSP5aLiqSVf7hdMCDs yR7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/6pKbYj2ed0f0UaEFoaaIUYpFQjvxwrfEa8r7ccecLg=; b=QF+LB3K4k6SkLpp4XL0Q2kNfV2ZWuQktmsfSU0BEIZrdy9LXunHv6BOmcYFTcg6eFE Ugz+V2ajTRqj+1NXTlMktzHiNQK6HWKUUPXR1YFAApRP8Xu1S1NK6oG1os0pt1MH5yYj ApDDIrfD7BfL/TD2ZX07HLVLNiG96qq+n7GcHgKNt4i7IO6zaZI9wjQ4TgQKlriaW2hW U4RT0Z8YmbQ01rbsVbRnfm9TM/zjS80byHVgdousEdc/Ewaig0zRZ8EDz/GdgjX1XI3O Y0kr1XVYEWWZ50Hde0Yb/KXSXHCUGdp31AZrO67N2iAeQs6u+OhtWOkTNDohefPSKEPs xfRw== X-Gm-Message-State: AOAM533cpcwJa3TAW1nR4mMTeV1v4BreN+TlHe06n3Mo44D2dRiBX3bZ 8Pm28LKZVl+6llwTrSqw9J9ltg== X-Google-Smtp-Source: ABdhPJyGwTQzDPCtsM1dRKOQR3lJJwgBKHzl/HwiNMhRIvnaoQC31Qzw/GHpYHI9LCZcyYFGlq/1kg== X-Received: by 2002:a05:6808:352:: with SMTP id j18mr672718oie.122.1623704356727; Mon, 14 Jun 2021 13:59:16 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id h1sm3583245otq.59.2021.06.14.13.59.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 13:59:16 -0700 (PDT) Date: Mon, 14 Jun 2021 15:59:14 -0500 From: Bjorn Andersson To: Siddharth Gupta Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v2 0/4] remoteproc: core: Fixes for rproc cdev and add Message-ID: References: <1623703244-26814-1-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1623703244-26814-1-git-send-email-sidgup@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210614_135919_142561_4E4EC0AE X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 14 Jun 15:40 CDT 2021, Siddharth Gupta wrote: > This patch series contains stability fixes and error handling for remoteproc. > Thanks for respinning this Sid, I think patch 3 looks good now as well, but it seems you accidentally got an additional file in the same patch. Can you please fix that up and resend the patches? Regards, Bjorn > The changes included in this series do the following: > Patch 1: Fixes the creation of the rproc character device. > Patch 2: Validates rproc as the first step of rproc_add(). > Patch 3: Fixes the rproc cdev remove and the order of dev_del() and cdev_del(). > Patch 4: Adds error handling in rproc_add(). > > v1 -> v2: > - Added extra patch which addresses Bjorn's comments on patch 3 > from v1. > - Fixed commit text for patch 2 (s/calling making/making). > > Siddharth Gupta (4): > remoteproc: core: Move cdev add before device add > remoteproc: core: Move validate before device add > remoteproc: core: Fix cdev remove and rproc del > remoteproc: core: Cleanup device in case of failure > > 0000-cover-letter.patch.backup | 26 ++++++++++++++++++++++++++ > drivers/remoteproc/remoteproc_cdev.c | 2 +- > drivers/remoteproc/remoteproc_core.c | 27 ++++++++++++++++++--------- > 3 files changed, 45 insertions(+), 10 deletions(-) > create mode 100644 0000-cover-letter.patch.backup > > -- > Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel