From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 998C4C48BE6 for ; Wed, 16 Jun 2021 08:03:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C8E461159 for ; Wed, 16 Jun 2021 08:03:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C8E461159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rTwhPQo39lxi74Xb8oYvv+Ex6/Dxa9R2XaQp8+fA3k0=; b=quVsuoHNmkz+lZ jIPTm6MpxhWMEKhb2cPZjnEfsJakZ8zA9cC60d5IS2A0NRqtZ8gkEZk00KULaq11Vs/JEQmzZMKFx j948o8RWPCOSNkG1uFg+TY+zOh668njWOdX+VDlgebYO/uyfJraCVA+9tavfpopFMtzy6lj7RLtfH 2KDYK7tl+uTm3zxA6MyUTmsWbyt0qjU/pjAYPWTfuCi9MfIPHpnF1502rV/3x9G3Ezq8+OTNSNL9m Uuf0AR7nX1mNttzza21QCARXUwWfvpa+GLajKjTBGWRPtmUVf0jkhNMPF4aGyjVwoOO68TYP1Qvp0 LkmY21SxKys4bAZoo5Fw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltQUz-005JJQ-3V; Wed, 16 Jun 2021 08:02:09 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltQUu-005JHo-Um for linux-arm-kernel@lists.infradead.org; Wed, 16 Jun 2021 08:02:06 +0000 Received: by mail-pj1-x1034.google.com with SMTP id fy24-20020a17090b0218b029016c5a59021fso3514004pjb.0 for ; Wed, 16 Jun 2021 01:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yOnR+mvHvq0XbGYNaQzXS/E8NUV0fIrwWByQjDfQPHQ=; b=ogJdzjZlsAKA4Ejn4ortTl8wrFGVAgL3sehcV4cQWN7YHIf+RZHdXy6bxzWiJDpcmL V1dtrQ3b4aOb4SO31cyALXckzBMafRJYGsNpqySCJxefgwNM6MitYkGznpk6cDWlEKc2 MXVfxJAQcKN3G8XpB2Syl2RXG2F/pIAeS7xOY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yOnR+mvHvq0XbGYNaQzXS/E8NUV0fIrwWByQjDfQPHQ=; b=Q5hwO4BGCvrM5Cf5yfskUxA1CfKl5zpoj08aAcT83sfH02mUwUOvnyYIyCAiVjACuS mq9LBTzDr7CC2tWrrh/dk6tlCI1r0R/qehhILXp1xhk+s8DehhTNurf53i7YiDQwjLTo aY6JMCzxIKl5DPLOjZG30Ux8zpktSypKjNCxn3mIDvzOAqTgezTZ2b16qnkGrMaJET0F TqZ3OoJdXZmPu0m8nyxjmtZGAnHSqScnIcTgPXa2hnJP77rLaKIuv/4fg1VZ+qVDMJ3V c4CYESFeEMs1NW3pajP0Pv6udJWXwCARdmQ94OlWE4q6MtvOJEJD8XwzAuosxowks4dz DUXA== X-Gm-Message-State: AOAM532rm6qZXfB/ONB3LhcrW0dZpTSBtOmJCd4v8d7d+3Oi2evY67BJ Y+iKwIn4SHXTFnd1XaXG6ZfF/w== X-Google-Smtp-Source: ABdhPJzobEDwQGUJ4kTYd2EtdaboX/M1rgIePs8vk+Af7VafwTKClGnUPRFRDOQ789Va1PHbWluGcg== X-Received: by 2002:a17:90a:4216:: with SMTP id o22mr9487241pjg.3.1623830523139; Wed, 16 Jun 2021 01:02:03 -0700 (PDT) Received: from google.com (2001-b011-0003-1f79-f0b4-87ad-2804-77d3.dynamic-ip6.hinet.net. [2001:b011:3:1f79:f0b4:87ad:2804:77d3]) by smtp.gmail.com with ESMTPSA id h8sm1392639pjf.7.2021.06.16.01.02.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jun 2021 01:02:02 -0700 (PDT) Date: Wed, 16 Jun 2021 16:01:58 +0800 From: Chen-Yu Tsai To: Tinghan Shen Cc: robh+dt@kernel.org, matthias.bgg@gmail.com, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com, seiya.wang@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com, Crystal Guo Subject: Re: [PATCH 01/27] arm64: dts: mt8195: add infracfg_rst node Message-ID: References: <20210615173233.26682-1-tinghan.shen@mediatek.com> <20210615173233.26682-2-tinghan.shen@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210615173233.26682-2-tinghan.shen@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210616_010205_096157_385D8BF2 X-CRM114-Status: GOOD ( 18.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jun 16, 2021 at 01:32:08AM +0800, Tinghan Shen wrote: > From: Crystal Guo > > add infracfg_rst node which is for MT8195 platform > > Signed-off-by: Crystal Guo > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 629cd883facf..8cda62f736b3 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -8,6 +8,7 @@ > > #include > #include > +#include > > / { > compatible = "mediatek,mt8195"; > @@ -273,6 +274,20 @@ > }; > }; > > + infracfg: syscon@10001000 { > + compatible = "mediatek,mt8195-infracfg", "syscon", "simple-mfd"; This block is named infracfg_ao in the datasheet. You seem to rename it in the clock patch. Maybe you squashed the change into the wrong commit? > + reg = <0 0x10001000 0 0x1000>; The address range matches the datasheet. > + #clock-cells = <1>; > + > + infracfg_rst: reset-controller { > + compatible = "ti,syscon-reset"; > + #reset-cells = <1>; > + ti,reset-bits = < > + 0x140 26 0x144 26 0 0 (ASSERT_SET | DEASSERT_SET | STATUS_NONE) > + >; > + }; This node doesn't seem to be used anywhere. Is it really needed? ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel