From: LABBE Corentin <clabbe@baylibre.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: ulli.kroll@googlemail.com, linus.walleij@linaro.org,
herbert@gondor.apana.org.au, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] crypto: sl3516 - Fix build warning without CONFIG_PM
Date: Thu, 17 Jun 2021 15:00:34 +0200 [thread overview]
Message-ID: <YMtHcruTqo3WE+g6@Red> (raw)
In-Reply-To: <20210617035129.4948-1-yuehaibing@huawei.com>
Le Thu, Jun 17, 2021 at 11:51:29AM +0800, YueHaibing a écrit :
> drivers/crypto/gemini/sl3516-ce-core.c:345:12:
> warning: ‘sl3516_ce_pm_resume’ defined but not used [-Wunused-function]
> static int sl3516_ce_pm_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~
>
> Use #ifdef macro to guard this.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/crypto/gemini/sl3516-ce-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Hello
Thanks for the report, but I am sorry and need to NAK this patch.
The driver needs PM, without it, clock and resets are never set.
The correct fix is to add "depends on PM".
Regards
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-17 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 3:51 [PATCH -next] crypto: sl3516 - Fix build warning without CONFIG_PM YueHaibing
2021-06-17 13:00 ` LABBE Corentin [this message]
2021-06-18 7:57 ` YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMtHcruTqo3WE+g6@Red \
--to=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ulli.kroll@googlemail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox