From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96BDAC2B9F4 for ; Fri, 18 Jun 2021 01:26:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5290E6112D for ; Fri, 18 Jun 2021 01:26:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5290E6112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lCNBzBOe369xq8bu/oZa9QZlbQLcDoCF4amyahrZr4Y=; b=PZTSUHRiUnNg40 M1WDJ2b6mTR4rWqbGe+fn9R54OmK3BOWz/h+GfOsx6DnRKdczh4mGJVdfctDk6HW/zhIoIAaqzoXQ YLd6HV2gJA00Q1vUWQFU2yS4B0f7ywYTAG4iucBXmlX5IfEO3n1LnnJjCMiiYH0O0qR4okiuuf0Lq CawaZKUCxfRVczdKjj4co5Nomcdk6h4x7F86tR4aodTuYGEVPicNSHsIHpTcWrGp6kvyNnA8OB8EK 4cimxZTkZKlKmml8vpjgUPPpcONu5dqx307iCkvsB5hdgNmdxfKoLo1VPud8GImUCAA6XUUF5EMV6 Cc4ESPEA6L0yP0Y4QPoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lu3GL-00CHgI-2s; Fri, 18 Jun 2021 01:25:37 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lu3GG-00CHfg-JH for linux-arm-kernel@lists.infradead.org; Fri, 18 Jun 2021 01:25:34 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 278EB61369; Fri, 18 Jun 2021 01:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623979532; bh=4PCFRwdghdjFK7eM8qTw9AzytvkS0O/ABFB0fovPwjQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DqxzrsLcxjJ5spoWIpS41W+UrpkwcE6f0kL0xrSiAVnSsiiIezDLwWI4j+9bekQzO v4EdhQaFWsHiHiAXMVP3xdNz1+6Z24AaHGRDIeuiX6fSeJNy9RUPH8B6HjpMRCQyaP kKgKi+mtTkUNasO6tc97gGHJcKBI7+DNr0FPg8INIDrEFBf9arcn7vfIFaJayGVTmk 2OGWIZzxFYGCHC74Ulg02Chkfguq1BJWIRqfU1IsKoMayH6/k89mq5pmV6ZnzODNhO ReChADQTh7b2fLp+E7mR95XJ3iGkZZOFfGqKOZuqhh86DE+ElBcs+smWIPVJlfHidN WXkhDBNb5qX2A== Date: Thu, 17 Jun 2021 18:25:27 -0700 From: Nathan Chancellor To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, will@kernel.org, Catalin Marinas , clang-built-linux@googlegroups.com Subject: Re: [PATCH 2/2] arm64: insn: move AARCH64_INSN_SIZE into Message-ID: References: <20210609102301.17332-1-mark.rutland@arm.com> <20210609102301.17332-3-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210609102301.17332-3-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_182532_710059_1ABC63C3 X-CRM114-Status: GOOD ( 20.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mark, On Wed, Jun 09, 2021 at 11:23:01AM +0100, Mark Rutland wrote: > For histroical reasons, we define AARCH64_INSN_SIZE in > , but it would make more sense to do so in > . Let's move it into , and add the necessary > include directives for this. > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/include/asm/alternative-macros.h | 4 +--- > arch/arm64/include/asm/insn.h | 3 +++ > arch/arm64/include/asm/kvm_asm.h | 1 + > arch/arm64/kernel/cpufeature.c | 1 + > arch/arm64/kernel/patching.c | 1 + > arch/arm64/kernel/traps.c | 1 + > arch/arm64/net/bpf_jit_comp.c | 1 + > 7 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/include/asm/alternative-macros.h b/arch/arm64/include/asm/alternative-macros.h > index 8a078fc662ac..703fbf310b79 100644 > --- a/arch/arm64/include/asm/alternative-macros.h > +++ b/arch/arm64/include/asm/alternative-macros.h > @@ -3,12 +3,10 @@ > #define __ASM_ALTERNATIVE_MACROS_H > > #include > +#include > > #define ARM64_CB_PATCH ARM64_NCAPS > > -/* A64 instructions are always 32 bits. */ > -#define AARCH64_INSN_SIZE 4 > - > #ifndef __ASSEMBLY__ > > #include > diff --git a/arch/arm64/include/asm/insn.h b/arch/arm64/include/asm/insn.h > index a6f3f45fc46f..1430b4973039 100644 > --- a/arch/arm64/include/asm/insn.h > +++ b/arch/arm64/include/asm/insn.h > @@ -12,6 +12,9 @@ > > #include > > +/* A64 instructions are always 32 bits. */ > +#define AARCH64_INSN_SIZE 4 > + > #ifndef __ASSEMBLY__ > /* > * ARM Architecture Reference Manual for ARMv8 Profile-A, Issue A.a > diff --git a/arch/arm64/include/asm/kvm_asm.h b/arch/arm64/include/asm/kvm_asm.h > index cf8df032b9c3..894edda8cc85 100644 > --- a/arch/arm64/include/asm/kvm_asm.h > +++ b/arch/arm64/include/asm/kvm_asm.h > @@ -8,6 +8,7 @@ > #define __ARM_KVM_ASM_H__ > > #include > +#include > #include > > #define ARM_EXIT_WITH_SERROR_BIT 31 > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index efed2830d141..16d35cfffcea 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -76,6 +76,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/arch/arm64/kernel/patching.c b/arch/arm64/kernel/patching.c > index 7aa55b33c8c7..9a6edb9c48c7 100644 > --- a/arch/arm64/kernel/patching.c > +++ b/arch/arm64/kernel/patching.c > @@ -8,6 +8,7 @@ > > #include > #include > +#include > #include > #include > #include > diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c > index 48ff6fb888e0..8f66072fa5cb 100644 > --- a/arch/arm64/kernel/traps.c > +++ b/arch/arm64/kernel/traps.c > @@ -36,6 +36,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c > index f7b194878a99..dd5000da18b8 100644 > --- a/arch/arm64/net/bpf_jit_comp.c > +++ b/arch/arm64/net/bpf_jit_comp.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > > #include "bpf_jit.h" > -- > 2.11.0 > I bisected a CONFIG_LTO_CLANG_THIN=y build failure that our CI reported to this patch: https://builds.tuxbuild.com/1u4Fpx2FQkkgkyPxWtq0Ke4YFCQ/build.log I have not had a whole ton of time to look into this (dealing with a million fires it seems :^) but it is not immediately obvious to me why this fails because include/linux/build_bug.h is included within arch/arm64/include/asm/insn.h. It seems only CONFIG_LTO_CLANG_THIN=y (or FULL) is enough to trigger this, a regular defconfig build is fine: https://builds.tuxbuild.com/1u4Fpt5M8quEVUd4kNSMrdzobC2/build.log I will try to look into this tomorrow but I figured I would let you know in case something obviously stuck out. Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel