From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A8BEC11F64 for ; Thu, 1 Jul 2021 17:17:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4296661405 for ; Thu, 1 Jul 2021 17:17:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4296661405 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DPI49mjK3/k0bS57tZ6JzIvNeMpDVUOb3IpQf6jP/rU=; b=STSx5kImrloPNH gpCHvCSUtFSZ8fD9JbwhqcExGljItTtUae5BnVUb0l2CUhw1lnXrek5c2bhGh3KtMB6H0LcGQzvMy RR5Wievk7QGpDh0MlDSvIIplyV78OGXKTsqUli8k9JAeJ2QNOqF4WOehd4+PDd8TrVLzQUGQNIv1h o+/bVj6pnYxiO2+GhC9J6Ed5uIm5PbMGZaf7xJzagxx7xsDsgoh4rOQ7Rwm69Jlm7K1Hq/hADEDGi stxRnYM5SM+7kCMWNc0qmCvbM8aK/K7OKAQrccarQCTp+R88DDvvQfCC55OlLrivg3LyMOe75ey0H hFNP8LH3VlAAbHFJWqJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lz0I6-000aMn-Hb; Thu, 01 Jul 2021 17:15:54 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lz0I4-000aMQ-GV for linux-arm-kernel@bombadil.infradead.org; Thu, 01 Jul 2021 17:15:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9WDXU4Rt6nNDHcbzXa4fAXPi/EaDfekWUA3m+l9MMUg=; b=V9O1vVtkLSUnrKLCtX7hHH6wWy T/LR1VG6t7YNVqgkYa4Jmv79OGo6EB1ya+rMnMAheQrpwrmyrAuzWvoyk8ydlzdhoSPeRrGLhJJ0M G3M4gVbl4/dzfPZdWkIewGRmOo0IRkRcnBNhyrqMyK4xNzxw+w1E3IBUIY+ct1vXPPY5rE8pcv0HV vEd51stYox9nr79n6YIm+OUMDgfYutQlvtxgTB6g4p7kCNWROjYFb/ww9AZFEKWS6WWN6ZAnLRln6 E0u1nGhTGXhkMBOaXXT1KKaWY5/b70LcLtn1qFHRPoWVOrjn49PN2zSOceyE7PDubpeQsPapE79BM gPwAa5iA==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lz0Hh-006nzb-DL for linux-arm-kernel@lists.infradead.org; Thu, 01 Jul 2021 17:15:34 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 02C1340B1A; Thu, 1 Jul 2021 14:15:26 -0300 (-03) Date: Thu, 1 Jul 2021 14:15:26 -0300 From: Arnaldo Carvalho de Melo To: Mathieu Poirier Cc: James Clark , coresight@lists.linaro.org, leo.yan@linaro.org, al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org, suzuki.poulose@arm.com, anshuman.khandual@arm.com, Mike Leach , John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf cs-etm: Delay decode of non-timeless data until cs_etm__flush_events() Message-ID: References: <20210609130421.13934-1-james.clark@arm.com> <20210614155442.GA396617@p14s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210614155442.GA396617@p14s> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Mon, Jun 14, 2021 at 09:54:42AM -0600, Mathieu Poirier escreveu: > On Wed, Jun 09, 2021 at 04:04:20PM +0300, James Clark wrote: > > Currently, timeless mode starts the decode on PERF_RECORD_EXIT, and > > non-timeless mode starts decoding on the fist PERF_RECORD_AUX record. > > > > This can cause the "data has no samples!" error if the first > > PERF_RECORD_AUX record comes before the first (or any relevant) > > PERF_RECORD_MMAP2 record because the mmaps are required by the decoder > > to access the binary data. > > > > This change pushes the start of non-timeless decoding to the very end of > > parsing the file. The PERF_RECORD_EXIT event can't be used because it > > might not exist in system-wide or snapshot modes. > This looks good to me but I'd like to have other people testing it. So Leo reviewed and tested this, I'm taking your "looks good to me" as an Acked-by, as per Documentation/process/submitting-patches.rst. - Arnaldo > Thanks, > Mathieu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel