From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3346C11F68 for ; Fri, 2 Jul 2021 13:00:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B125B61413 for ; Fri, 2 Jul 2021 13:00:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B125B61413 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kLRS6RKJvHwD/nWPal/wp+eu+u3JqzxuQWlfgswDHQY=; b=B4oBM6mcQAzHJV v1uSLvdE1zC8uB3/0Kk9ZnnVpVsvTkt2TCJf2lTU9uqqRJ0yZUs4XBMi7ClVgakNExnuyus1XGJIL fXEWOeELefzwmPJphejPRdJ2dMyKW4MrsARXyACkbrdwMaWKSYTG1SWOVWeDZrf0BX7PCOJQ++OQK fIFg2vAHVmQXi74fFgYyddQ+xAF5iWfMDiHWHesOOq9sJpJdvnPNRiOYbDdzOI54P+a6VEsDgRVgF MbU+n8ikyumnndytmcdzhO6FRIBXA9in4LP7Qmyo+DjPbKhzPJXaI43Z0X3oSi/pEt+uQYqVpYo0z yLiSdxJNND/VelzEUU3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lzIl2-0033Wv-7N; Fri, 02 Jul 2021 12:59:00 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lzIkz-0033WF-MW for linux-arm-kernel@bombadil.infradead.org; Fri, 02 Jul 2021 12:58:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xABsEDX+puDI/uveh8vefN+85/JnFznbmWaJqvFl3Xk=; b=l2AB6ch0ufkHu8Kyg3Pc1OWvMB ZAF56oh4HWKvsPVAe6GzrYpAph3Vz2ZdZUZaV0sB93TSZK8fEllZALgpRsdOjif14H774fZJncWlh kH/6maseYb4QgMiOSbUUS6dSexsgPkscKFnEomEx0ZrhFi02MJimx76mVvSDRWV9di2463NSFhs7T TAaDwKxrQ582DHiPJ1GjZ+37S7Ckw+iWP/fw+x8P6WxaXY9nYvW+yp0EC8oY5UArDvxD25T5IqM8a 1FZSljSnq1Smsj0qz889qbphjSLQ9fuqx0yjLyfJyRq4q4CZxFGW28c2JeIb03qBfAt3F3ceQdppt MfwyJ38A==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lzIkx-00DrVF-LJ; Fri, 02 Jul 2021 12:58:56 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 7FCDB40B1A; Fri, 2 Jul 2021 09:58:52 -0300 (-03) Date: Fri, 2 Jul 2021 09:58:52 -0300 From: Arnaldo Carvalho de Melo To: gushengxian Cc: will@kernel.org, mathieu.poirier@linaro.org, leo.yan@linaro.org, peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, gushengxian Subject: Re: [PATCH] perf: tests: fix some mmemory leak issues Message-ID: References: <20210702040955.631618-1-gushengxian507419@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210702040955.631618-1-gushengxian507419@gmail.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Thu, Jul 01, 2021 at 09:09:55PM -0700, gushengxian escreveu: > From: gushengxian > > Some memory leak issues should be fixed by free(). > Reported by cppcheck. Thanks, applied. - Arnaldo > Signed-off-by: gushengxian > --- > tools/perf/arch/arm/tests/dwarf-unwind.c | 1 + > tools/perf/arch/arm64/tests/dwarf-unwind.c | 1 + > tools/perf/arch/powerpc/tests/dwarf-unwind.c | 1 + > tools/perf/arch/x86/tests/dwarf-unwind.c | 1 + > 4 files changed, 4 insertions(+) > > diff --git a/tools/perf/arch/arm/tests/dwarf-unwind.c b/tools/perf/arch/arm/tests/dwarf-unwind.c > index ccfa87055c4a..f2541d1dbb02 100644 > --- a/tools/perf/arch/arm/tests/dwarf-unwind.c > +++ b/tools/perf/arch/arm/tests/dwarf-unwind.c > @@ -39,6 +39,7 @@ static int sample_ustack(struct perf_sample *sample, > memcpy(buf, (void *) sp, stack_size); > stack->data = (char *) buf; > stack->size = stack_size; > + free(buf); > return 0; > } > > diff --git a/tools/perf/arch/arm64/tests/dwarf-unwind.c b/tools/perf/arch/arm64/tests/dwarf-unwind.c > index 46147a483049..ecd25c77a71f 100644 > --- a/tools/perf/arch/arm64/tests/dwarf-unwind.c > +++ b/tools/perf/arch/arm64/tests/dwarf-unwind.c > @@ -39,6 +39,7 @@ static int sample_ustack(struct perf_sample *sample, > memcpy(buf, (void *) sp, stack_size); > stack->data = (char *) buf; > stack->size = stack_size; > + free(buf); > return 0; > } > > diff --git a/tools/perf/arch/powerpc/tests/dwarf-unwind.c b/tools/perf/arch/powerpc/tests/dwarf-unwind.c > index 8efd9ed9e9db..e57a8ca52ce7 100644 > --- a/tools/perf/arch/powerpc/tests/dwarf-unwind.c > +++ b/tools/perf/arch/powerpc/tests/dwarf-unwind.c > @@ -40,6 +40,7 @@ static int sample_ustack(struct perf_sample *sample, > memcpy(buf, (void *) sp, stack_size); > stack->data = (char *) buf; > stack->size = stack_size; > + free(buf); > return 0; > } > > diff --git a/tools/perf/arch/x86/tests/dwarf-unwind.c b/tools/perf/arch/x86/tests/dwarf-unwind.c > index 478078fb0f22..da90b33a1e28 100644 > --- a/tools/perf/arch/x86/tests/dwarf-unwind.c > +++ b/tools/perf/arch/x86/tests/dwarf-unwind.c > @@ -47,6 +47,7 @@ static int sample_ustack(struct perf_sample *sample, > #endif > stack->data = (char *) buf; > stack->size = stack_size; > + free(buf); > return 0; > } > > -- > 2.25.1 > -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel