From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4960C48BE5 for ; Mon, 21 Jun 2021 05:31:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76EA56109E for ; Mon, 21 Jun 2021 05:31:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76EA56109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mG2Q4fdSOabU520JZQtw60aeNmES5pwGtkn9bpiPaE4=; b=Ek6+AIQcmm0rU5 k9T/OFnW8rwHRLwKDXV2roc878GEmq4YmnzDnKhiJ/dkpBJfqccglVXYPVExSTZQoOvcuLbtq6yOt 0+wz0i+DQwBAcvcmllco4BT68u2b21GGTmKoRH+yghybkLX+crt4h4/l/6KlW6l/kOOF9ArGeOHz9 TV7i8NWe40RBg/7KKaptpSpjRjucoaRMzkW7OFTX7OPHkG2Ejg/aI4BzIw1LtLMOtnUYufamg1S3A oWN+kHkC124w9sDS3R0FekknNJcbiC7QOoUFedkvf0DqTRonZmLLnV/2VdWCU2O63Pgb/avJbcso8 16xXglSSObhzI2ddhUtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvCVj-002Bsh-LX; Mon, 21 Jun 2021 05:30:15 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvCVg-002BsF-DH for linux-arm-kernel@lists.infradead.org; Mon, 21 Jun 2021 05:30:13 +0000 Received: by mail-pj1-x102f.google.com with SMTP id 22-20020a17090a0c16b0290164a5354ad0so11869325pjs.2 for ; Sun, 20 Jun 2021 22:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4IlYTzqTiHSSyCrVD+PHTHP/vSzXrM8Iuj5rsEYS1ag=; b=Pbv+96vIF+02I2wwcvgORNfYiULcsseOROoTrlSkAdKQ8/0Jt3oHyCsTpSYEpixQa9 0QcfW+xMj20lELFCZw3O2rZS61pC1kdLQl0qeDJp/c/mw0IKd4G6fmq0LMWvXKOT6g0q 8bNbSxDCaQPn9FC4iYdH88nTPZyCMlmeA+pQ019Dm41oF6WiYiM3aR+qIYFQjwFIwSbu cG/ueNacxVotmLx/0LLZUEP24oAMu6qAq/V8Zj5IEiXkCPlapYJlpGprSHshJtBNz7fH dEJJqOaV+PYUmEEYIESe0gUDDDxg5hynZnKc1vnGDiiJX5pYvGd9U8V1yme0RS6atH1L IbPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4IlYTzqTiHSSyCrVD+PHTHP/vSzXrM8Iuj5rsEYS1ag=; b=Kts5s2WcQiO4T3FvfD5CvWxsHXQIcA4FybIPCJEr6WkhINg96pB+bcs3LGZS7/YaIR IJmjYur04M4QH4Y2ZtYhsD5S/Ei26JlFdYb8o3YVsRs6hjEQxTQdWt1S3F2T3sA8qrew PVEHBJZVNs92axY4WEYW68oJSrBY5ZL+kadGBLa/vOD+PsDG21dAcXuwYTPxNuU1/dWN UnCwpVl1LypFZ8j1wYO7if4np4ZNq3ouBpmeGPUWASvNjjQUiT2fOi6sKttUPCI5Ruie x1jxyh5Big4QgsFGYNiSwXAHgb4JQUnXC0cQiTMJwTB6lFj97Awq9WsXoK8I+WQjb7yI 5zQw== X-Gm-Message-State: AOAM5332Ccyionfo5PmflD4BO8d394/mKgKJmj5sJcjkFTaETzoCiLG7 hI+fGVVq1/jfOqUDzuVVzRs= X-Google-Smtp-Source: ABdhPJwxJnLSM4mz1fCQWv4Mof+GiaalZ0RUmJTvO4iQIhAj/uMqCpXrb8enkuozJHLC0dCp8MiF2g== X-Received: by 2002:a17:90a:901:: with SMTP id n1mr35920253pjn.44.1624253410705; Sun, 20 Jun 2021 22:30:10 -0700 (PDT) Received: from google.com ([2620:15c:202:201:df5a:b40e:40c9:a3e7]) by smtp.gmail.com with ESMTPSA id l6sm1210484pgh.34.2021.06.20.22.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Jun 2021 22:30:09 -0700 (PDT) Date: Sun, 20 Jun 2021 22:30:07 -0700 From: Dmitry Torokhov To: Sergey Larin Cc: Maxime Coquelin , Alexandre Torgue , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: stmpe-keypad - add STMPE1801 support Message-ID: References: <20210618145149.10136-1-cerg2010cerg2010@mail.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210618145149.10136-1-cerg2010cerg2010@mail.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210620_223012_493730_05EFFB40 X-CRM114-Status: GOOD ( 11.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sergey, On Fri, Jun 18, 2021 at 05:51:49PM +0300, Sergey Larin wrote: > @@ -176,7 +232,9 @@ static irqreturn_t stmpe_keypad_irq(int irq, void *dev) > u8 data = fifo[i]; > int row = (data & STMPE_KPC_DATA_ROW) >> 3; > int col = data & STMPE_KPC_DATA_COL; > - int code = MATRIX_SCAN_CODE(row, col, STMPE_KEYPAD_ROW_SHIFT); > + int code = variant->read_inverted ? > + MATRIX_SCAN_CODE(col, row, STMPE_KEYPAD_ROW_SHIFT) > + : MATRIX_SCAN_CODE(row, col, STMPE_KEYPAD_ROW_SHIFT); Do we really need to do this swap vs. simply arranging the keymap differently for 1801? Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel