From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FFBBC48BE5 for ; Mon, 21 Jun 2021 16:03:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 294BD600D3 for ; Mon, 21 Jun 2021 16:03:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 294BD600D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A0XzHD17i5K0N51lRraHOkCnExG14U6qjhsIne1vyFg=; b=cAWYkLah2xp+c1bpTGiVmQgLBh e9/Ve3UaDwYAiVhjOgcPXyW6G3wEXebnia4wgMlzv4xAYX/v9PZQ1jYnJ3IREEeaVqa+WvhbT8OeG ojbTo6nZTRo9L5gkLxr78w8UCrAPbUf3JJ66pzs/XDWEgdelr3PNqEu4rItDYdGvgxs3H5xrafDpZ rA6D60zkffoInPLM/59o/Y1Nb8Iflo7Ioo9Vwn9MFLlWHWp3oRa9TkFbHTebmJoffwP14+CxfF0gC 8LlFU/mFF46oiZuE2U3spR4LVNndcFpw+nECgRFEMRA0oOYh06dBSUvtmPYs70ZSUTnJ35rXWF0rm lypcJUnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvMMT-0040Me-Ox; Mon, 21 Jun 2021 16:01:21 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvMMP-0040MA-Ic for linux-arm-kernel@lists.infradead.org; Mon, 21 Jun 2021 16:01:19 +0000 Received: by mail-wm1-x329.google.com with SMTP id m41-20020a05600c3b29b02901dcd3733f24so3794781wms.1 for ; Mon, 21 Jun 2021 09:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ivAWWnxfgtrmvv3mt9r+kn10vF6aZeuh33extDSkaTo=; b=uOqWwWQ4WOIl9VuV2Y274ZVEHBTN0BdemWxxZnRE4hduwnBUSKhefHy6iBk+4Zsibt GDRyURS5vRNIpHQpbAGKCzVSK93YcqY9v9Z5w8BiX5SGcTNKppe8Wp9r1k2FdlIlOB6I 2vSaJW+0KGyconEKhQBsYZtNheZfpHLphF1nLeGOhSFBYbRershc8nBGaqvuzwZRT76d NL/2twFjbBzLAIerHZApKmg/H7YSv/woTz6gs7E1h5pAl68osiT/Pti4kMdbcbZtl/Wd nE/heYSlsxk/HBUIQg0dbbJZl+XZtZvc6/86NWBi3fABFvAWVqXODwyc/yUsfwYykoN+ T/tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ivAWWnxfgtrmvv3mt9r+kn10vF6aZeuh33extDSkaTo=; b=ZKHViwqM1n5oHMT6LWiYTdTq+p+BU50Si1XUAb+oDz7F36yAP4r9W0km0zNeAAAW/1 GN1001PAqlFvSAMk5lgE4j5gS7qzcCiKDGe2bI0R+0FpVAy1jCEiFUM6ic1Rz9oUVk/b TMizXzTOPsRCGSP0Uge9Rg6uFXclBqdMn1o2ug6ZPgUiwyzD+eartul8FM8b/kFQ2jM7 Dlyj2MG3cPjS49ml0ooUx/bZyBdOqDmSBP19PBbUAX2UiDDnVAlsFLCwYBN5NECNj07s NFF8KaXDpW9Wzgy/J6fKUo4u8bH/zd8M219egFpFpyyF0xWdah8lEr5hcAXtbIx7iL5w FePg== X-Gm-Message-State: AOAM530r3KQWxtSUpQQtORS57tVXW+ao5wlgm2s+XuzPGqMcy6NhhNw6 Ner6nom+qH4wOtwFIZezkN4= X-Google-Smtp-Source: ABdhPJx7aPSw8G1VbByNyfHybZXWzG2tegvel5Pn2UV6Pnm1dIobwxNlOc5wlZr/ZS/3wK6c5Iaf7Q== X-Received: by 2002:a1c:4b05:: with SMTP id y5mr4923971wma.96.1624291275970; Mon, 21 Jun 2021 09:01:15 -0700 (PDT) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id c13sm18590628wrb.5.2021.06.21.09.01.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 09:01:14 -0700 (PDT) Date: Mon, 21 Jun 2021 18:03:11 +0200 From: Thierry Reding To: Will Deacon Cc: Krzysztof Kozlowski , Rob Herring , Joerg Roedel , Linux IOMMU , Jon Hunter , Nicolin Chen , linux-tegra , Robin Murphy , linux-arm-kernel Subject: Re: [PATCH v3 2/9] dt-bindings: arm-smmu: Add Tegra186 compatible string Message-ID: References: <20210603164632.1000458-1-thierry.reding@gmail.com> <20210603164632.1000458-3-thierry.reding@gmail.com> <14551e79-853d-471f-bb5e-0d2d6581a9b6@canonical.com> <20210621155418.GA29488@willie-the-truck> MIME-Version: 1.0 In-Reply-To: <20210621155418.GA29488@willie-the-truck> User-Agent: Mutt/2.0.7 (481f3800) (2021-05-04) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210621_090117_683345_F6EFAAFE X-CRM114-Status: GOOD ( 27.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6070238497373729420==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6070238497373729420== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+CwF57SIeipNOA+L" Content-Disposition: inline --+CwF57SIeipNOA+L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 21, 2021 at 04:54:18PM +0100, Will Deacon wrote: > On Mon, Jun 21, 2021 at 04:11:55PM +0200, Thierry Reding wrote: > > On Mon, Jun 21, 2021 at 08:46:54AM +0200, Krzysztof Kozlowski wrote: > > > On 18/06/2021 21:47, Rob Herring wrote: > > > > On Thu, Jun 3, 2021 at 10:49 AM Thierry Reding wrote: > > > >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml= b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > > > >> index 9d27aa5111d4..1181b590db71 100644 > > > >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > > > >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > > > >> @@ -54,8 +54,14 @@ properties: > > > >> - const: arm,mmu-500 > > > >> - description: NVIDIA SoCs that program two ARM MMU-500s id= entically > > > >> items: > > > >> + - description: NVIDIA SoCs that require memory controller i= nteraction > > > >=20 > > > > This is not valid jsonschema: > > > >=20 > > > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu= /arm,smmu.yaml: > > > > properties:compatible:oneOf:4:items: 'anyOf' conditional failed, one > > > > must be fixed: > > > > None is not of type 'object', 'boolean' > > > > None is not of type 'array' > > > > from schema $id: http://json-schema.org/draft-07/schema# > > > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu= /arm,smmu.yaml: > > > > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > > > > must be fixed: > > > > None is not of type 'object' > > > > None is not of type 'array' > > > > from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# > > > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu= /arm,smmu.yaml: > > > > properties:compatible:oneOf:4:items: 'oneOf' conditional failed, one > > > > must be fixed: > > > > None is not of type 'object' > > > > None is not of type 'array' > > > > from schema $id: http://devicetree.org/meta-schemas/string-array.ya= ml# > > > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/iommu= /arm,smmu.yaml: > > > > properties:compatible:oneOf:5:items: 'oneOf' conditional failed, one > > > > must be fixed: > > > > [{'enum': [{'const': 'nvidia,tegra194-smmu'}, {'const': > > > > 'nvidia,tegra186-smmu'}]}, {'const': 'nvidia,smmu-500'}] is not of > > > > type 'object' > > > > {'const': 'nvidia,tegra194-smmu'} is not of type 'string' > > > > {'const': 'nvidia,tegra186-smmu'} is not of type 'string' > > > > from schema $id: http://devicetree.org/meta-schemas/string-array.ya= ml# > > > >=20 > > > >=20 > > > > This was not reviewed nor tested since the DT list was not Cc'ed. > > >=20 > > > Ugh, I see now weird empty item on a list... and not only DT list was > > > skipped - Thierry did not Cc you either. > >=20 > > This seemed like a too trivial addition to waste Rob's time on, so I > > didn't add him (or the DT list for that matter) on Cc. The ARM SMMU > > maintainers had reviewed this, which seemed like it was enough for what > > the DT bindings change was doing. >=20 > Hmm, I didn't review it. I find the yaml stuff unreadable so I usually > wait for the DT folks to ack bindings changes before I queue them in the > SMMU tree. Alright... in the future I'll make sure to always Cc DT folks, even for trivial stuff like this. Thierry --+CwF57SIeipNOA+L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmDQuD0ACgkQ3SOs138+ s6HSvA/7BHYi/gFhpj4KkJ1anrFhbP8ExJoJGbVVjxip0aEE5drYxHHLf9eORDpC zm5GpLFak8QUqsmQpu3uJDZV5GngAu+Py7MsD/F/sw/NV4sl/P2QaGO94sv3wxGU 8c/4lslxP+tS/1RQRM51y/UJntsHCMfjsFiGiGQX350CBzw8V8vBb1Hvl9DgUQKN sW4t3nRr8vE3MfL+Bmd3rROk6sKo6oVpLA7txsPfCr3s4PS4bNo1jbEZBysDukSj 7HfGI+e/lbIBQuOcjWRrpTR2vu7cqYFKJgStP4oNcC/jyh2JuUVc4+3Lt8j8WsSD DKGtySqU73ZLVhmcDi42mKQLRDnkqetdQvaDr91EVXrNhXCZpZOksY86K0C8cLt5 e+0/WTBftQTnSZE/fEOWVm4DtlxJij5HSScAeC3rXd8P+arP7rxlzRoDeospXKfz rx0epONpi/LWuzCy8hjtU5+A9Tcl4xD31cEVXxwLMUEIdptt9jJj5/QymsLxW2OJ noa2gxXa3OTutq7h4SJPRb1BW9kIFuC8lut7rVMnMUnSKgmtK/YbR1dHeHDMxzdR isHDUlPNS+R/6Qh78c0FrUmySfU91YjBg5JuxY0nek+vmY5jHCZYITBItOfBPq21 30xQwGk0iFKRPoqInoz+sHsJ5+OkecFPXmjBmRBktj8DLfQoemI= =w4gL -----END PGP SIGNATURE----- --+CwF57SIeipNOA+L-- --===============6070238497373729420== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6070238497373729420==--