From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 607FDC4743C for ; Wed, 23 Jun 2021 13:01:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3099C600D3 for ; Wed, 23 Jun 2021 13:01:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3099C600D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V96Q4WYzIXnEDhdntO1dJ2F6ZrJrME0wtHMRoruh0/Q=; b=2Avg/oexZ/LP84 ch+kk7ahlyx2yYQ0ZsWNeBkShjoiS3T45z91OL6T/r0hiyyoULB+OYuLM2Y/3eiG5rDdWwTlTtX0W k+8pvqGyEpZaNUD7cis46HXiOICaP7VF9vBPjyq9T5j7l4p86vat7qmP/HKHJjV8YlS25iDJoIMsO DDOc/qEQozn0qgV4/ku2jw3C1nCBKk+7zzUpB1wOr5ZsxRYeloxVG+8KlNA1b2B9WKf/iaOfrTDdV k6Oyk5/k9WAQI15ZombpvUf/FhmtjrUfUIPQjHvZZc5M4bE/eGbpMALATetOl3ybbDvZuLKDQeE0o bqBn2W8+2oOqvuYXIdQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw2Ti-00AhnQ-GF; Wed, 23 Jun 2021 12:59:38 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw2Tf-00AhmQ-BT for linux-arm-kernel@lists.infradead.org; Wed, 23 Jun 2021 12:59:36 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A29909AA; Wed, 23 Jun 2021 14:59:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624453173; bh=WRNQ43bka2fHx73Bt1Dxbd2nJ/Sp0ZOKsmWYcvwxIzs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sj1k4TSCKTPhIjLEc3HXCo5YNYNinTs1CsSBST/JDrTuGPn00iYNpxQs71eR1VDad PN6xuSUmux7cVbxR//zRraRQ9SVrfbRFcS1F1idRvX8zF5hVISv1FnwUGndrBWT/4O jhjaPEKgO7xMQhxWqPprjyWWD8Nr6OLRYWMXEYIQ= Date: Wed, 23 Jun 2021 15:59:04 +0300 From: Laurent Pinchart To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, Hyun Kwon , Vinod Koul , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] dmaengine: xilinx: dpdma: Fix spacing around addr[i-1] Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210623_055935_587397_2BC5439E X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 23, 2021 at 01:07:38PM +0200, Michal Simek wrote: > Use proper spacing for array calculation. Issue is reported by > checkpatch.pl --strict. > > Signed-off-by: Michal Simek > --- > > drivers/dma/xilinx/xilinx_dpdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c > index 0b67083c95d0..b280a53e8570 100644 > --- a/drivers/dma/xilinx/xilinx_dpdma.c > +++ b/drivers/dma/xilinx/xilinx_dpdma.c > @@ -531,7 +531,7 @@ static void xilinx_dpdma_sw_desc_set_dma_addrs(struct xilinx_dpdma_device *xdev, > for (i = 1; i < num_src_addr; i++) { > u32 *addr = &hw_desc->src_addr2; > > - addr[i-1] = lower_32_bits(dma_addr[i]); > + addr[i - 1] = lower_32_bits(dma_addr[i]); I don't mind either way. Reviewed-by: Laurent Pinchart > > if (xdev->ext_addr) { > u32 *addr_ext = &hw_desc->addr_ext_23; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel