From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACD8BC11F66 for ; Tue, 29 Jun 2021 14:09:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6917661DCB for ; Tue, 29 Jun 2021 14:09:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6917661DCB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AJQiHgRLUx+cS89WqFRBs0jptWG20oWwOyogk6ZaDio=; b=kIRtBfnddXfyDU rn8rMeFjZos6I/815Y2KqDA/HPL4O9E8kM6YACFAMVdTnTM+TIJBBmzf/MRjFqRL9FbSVLyO/pshZ e/I53iErwtKsbwWNMLvyVr5OKfBT0V9kfchFhZ6MeJ5VEdMxExZ1ekxloijM6m6OOsXoocKHBWA0o 0eQpQl4nt1PIsW9+Xyqj+fP7XC9r5MML5YJ+AnJIPANOdc+WwhKLRt0MAdoO4YDu10X90lLFUvqYv xdZaAH3VC0aAPwLEOmNc/W3l7v9KP6ip0S9GZ1r/DhXgSLraNbL24j9nrX7VIGIH6HvWiB86I/u0f 1UJnMChjZ2SUZRg2vucA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyEOU-00BDhr-GA; Tue, 29 Jun 2021 14:07:18 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyEOQ-00BDh5-NG for linux-arm-kernel@lists.infradead.org; Tue, 29 Jun 2021 14:07:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=w0aRX+AVNRJPjlDg5QC6T0rQR3HiSguZvmev3Zp5piE=; b=WXGZ0/uFyApzN9diblYk6h+6Yv JfykksEXxmGiyInS8Vhtw/9UhuzqGFhMHQsznmeAnoEP8tQJ+VWr2rEmxuUGxwgLZypG+F+XQf15/ 5n8DnKvqothU3Lu+xHIEM41BYl9oBF5tnk5VN5kn+4oDeYpVQorcAQwYBHogf0yRCi1o=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lyEOJ-00BY2O-34; Tue, 29 Jun 2021 16:07:07 +0200 Date: Tue, 29 Jun 2021 16:07:07 +0200 From: Andrew Lunn To: Harini Katakam Cc: robh+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, steen.hegelund@microchip.com, bjarni.jonasson@microchip.com, ioana.ciornei@nxp.com, likaige@loongson.cn, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, harinikatakamlinux@gmail.com, michal.simek@xilinx.com, radhey.shyam.pandey@xilinx.com Subject: Re: [PATCH 2/3] dt-bindings: mscc: Add RGMII RX and TX delay tuning Message-ID: References: <20210629094038.18610-1-harini.katakam@xilinx.com> <20210629094038.18610-3-harini.katakam@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210629094038.18610-3-harini.katakam@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210629_070714_813270_33E90C0C X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 29, 2021 at 03:10:37PM +0530, Harini Katakam wrote: > Add optional properties to tune RGMII RX and TX delay. > > Signed-off-by: Harini Katakam > Signed-off-by: Radhey Shyam Pandey > Signed-off-by: Michal Simek > --- > .../devicetree/bindings/net/mscc-phy-vsc8531.txt | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > index 87a27d775d48..e201d24d8e27 100644 > --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > @@ -33,7 +33,14 @@ Optional properties: > VSC8531_DUPLEX_COLLISION (8). > - load-save-gpios : GPIO used for the load/save operation of the PTP > hardware clock (PHC). > - > +- vsc8531,rx-delay : RGMII RX delay. Allowed values are defined in > + "include/dt-bindings/net/mscc-phy-vsc8531.h". > + Default value, set by the driver is > + VSC8531_RGMII_CLK_DELAY_2_0_NS. > +- vsc8531,tx-delay : RGMII TX delay. Allowed values are defined in > + "include/dt-bindings/net/mscc-phy-vsc8531.h". > + Default value, set by the driver is > + VSC8531_RGMII_CLK_DELAY_2_0_NS. The default values need better explanation. So you are saying they are only used when 'rgmii' is not used. And they replace the default 2ns delay, they don't add to the default 2ns delay. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel