From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F76C11F67 for ; Tue, 29 Jun 2021 16:06:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D38661D88 for ; Tue, 29 Jun 2021 16:06:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D38661D88 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ob1H8QEeR3k+mAvMgfPIx617XPs3kpi5/gles2th0lg=; b=oSbiTb91gYzs7r 6iNUsmSxxZHnk/WEIQsZkVSmV5r0/kNL3bIacB7IhTvtcQ9Ga6I2jmeFnSHvRnwMgwFP4S0rCKJKy r0ta0yXjYKuoReb+vUHM2B75FtNtlsdUpeh2DzhuHDgRoXbgN1U8AB6W0nWAKBA58rUsJAXzwH0/h UdlO5SILu5aN5T/GOX1Gmzn27oRpndPF2PaAkRPbdK8/wbcLchlt8mhdx8tUGL3uebrOHXZwG7+T7 siq44RKIZVlHf5U5cKpNJ7EWQk49aOSOLC99HSalRouyI/Ag+n0kGVlmQu0AHPv9xq0byPUj9iwbd iCurzUlJiWrzrw0qHvBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyGDO-00BYne-Uv; Tue, 29 Jun 2021 16:03:59 +0000 Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyGDI-00BYls-Mp for linux-arm-kernel@lists.infradead.org; Tue, 29 Jun 2021 16:03:54 +0000 Received: by mail-oi1-x22e.google.com with SMTP id 11so18654119oid.3 for ; Tue, 29 Jun 2021 09:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=22YCX1gTuHxij8jBkd6zakC86sS35hKmpf8kUxvjUtA=; b=uNeO5HQ/ALYrv8nofxfYkzdeDAGS1Xx9YbfqiTXo82HWDllL+J+AvuQpCzIVUM8K+a SKl340JpBbSYnEzjVYXgxousi3t27+S5sloXkIBnbywCuwwUDmadKGIVmFozaPq1S2zo /CQnqX/w48kCBJ4oUo15C37Nx1sSYhDwWr1YcAf0lKMLGuOwwsleJ0t15S65WSS570QZ AtgV6/DxttbW5g7DSxr/F8Mbu7uylHJ9wV0w5LtaeAHRU32gQRnHzz3uB52Ux6cXBsnq RJrfqVVqO5cRx1P2B0dT28h6QzLckbINiLl1dsuoPFfYrYS+Fm8vGnvJ3exh8T6U2qc5 ZUaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=22YCX1gTuHxij8jBkd6zakC86sS35hKmpf8kUxvjUtA=; b=CBBwnPbwFN3qYcHf3ATDNst38qQMGciEGWQdfNgIiWmVC1Hk1PZQzCJ96ezQ3HxkK1 vTC1mPJY6E9/qKQQ8ZbkG+7u5LQoV8ZmJ4WG8gbKWIRasf26EeH8MDD7nRxPfJUqU3a9 QAOGjOPu6hOfL0Uwem+WRjKRYAmcMyBKLb1MQXZkP4Ya6IQ3d8erB+KuwxNxJ3KtbLu7 F5DWnFo4cW2YkURdHwyNHI37TbSGfJldAeH4u33bqg59/bvpGG8D86dJ8AdtasqTYjwa OL4nQeRBzcCS43nEzDwDBHMhwNU7QA9kVCmbprkBHpGWBNZjUVE7Zq01hRAsonXZO5yG /SKw== X-Gm-Message-State: AOAM530IuWhikS4XlNUFtRYzvybFLkoiCI+OvGhn13DHo78lD3VYGEey sy3W2J7y5wzJvZY/4yqksZ95Eg== X-Google-Smtp-Source: ABdhPJx4ReJpcx5aMpggn8YB+452U+YvCzJu2XF3zGPSA+kp4p1LMkT+7egjWO81/LUgvGGbBcRaNQ== X-Received: by 2002:aca:3285:: with SMTP id y127mr22031113oiy.115.1624982628172; Tue, 29 Jun 2021 09:03:48 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id y18sm3941779oiv.46.2021.06.29.09.03.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jun 2021 09:03:47 -0700 (PDT) Date: Tue, 29 Jun 2021 11:03:45 -0500 From: Bjorn Andersson To: Phil Chang Cc: linux-remoteproc@vger.kernel.org, ohad@wizery.com, mathieu.poirier@linaro.org, matthias.bgg@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, yj.chiang@mediatek.com, mark-pk.tsai@mediatek.com, weiting.tsai@mediatek.com Subject: Re: [PATCH] remoteproc: export rproc re/unregister to virtio device APIs Message-ID: References: <20210629150002.8050-1-phil.chang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210629150002.8050-1-phil.chang@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210629_090352_865855_7DC4F86A X-CRM114-Status: GOOD ( 18.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 29 Jun 10:00 CDT 2021, Phil Chang wrote: > In some case, the remote processor already boot up on previous state, > but still need register to virtio device, so that exported those APIs. > > Signed-off-by: Phil Chang > Signed-off-by: YJ chiang > --- > Hi > > In our case, the remote processor is already boot up in u-boot, > we don't want to boot again or load fw in driver but register to virtio > device for rpmsg. so that needs those API exported. > Furthermore, the rproc_vq_interrupt is exported, so those functions > should be exported also. > Would the recently introduces support in remoteproc for "attaching" to an already running remote processor be useful to you? If you don't need a remoteproc driver, but rather just want e.g. a platform_driver that spawns the appropriate virtio devices, wouldn't virtio_mmio work? Regards, Bjorn > thanks > > drivers/remoteproc/remoteproc_virtio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c > index 0cc617f76068..e23658a76f5e 100644 > --- a/drivers/remoteproc/remoteproc_virtio.c > +++ b/drivers/remoteproc/remoteproc_virtio.c > @@ -425,6 +425,7 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id) > out: > return ret; > } > +EXPORT_SYMBOL(rproc_add_virtio_dev); > > /** > * rproc_remove_virtio_dev() - remove an rproc-induced virtio device > @@ -440,3 +441,4 @@ int rproc_remove_virtio_dev(struct device *dev, void *data) > unregister_virtio_device(vdev); > return 0; > } > +EXPORT_SYMBOL(rproc_remove_virtio_dev); > -- > 2.18.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel