From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5909C07E96 for ; Thu, 15 Jul 2021 04:03:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C2F061279 for ; Thu, 15 Jul 2021 04:03:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C2F061279 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jYL60PG9z9B1GVd1oSbnNuAvCPAG3oAHeIBKYgrL7ss=; b=OtFiEnIrgujevh 82TfTCJi88cHlZ6wGuTtrxkUd+EzgXRk3DpG17sKgUV2GcY09kXVVzdafM2XsXctTgZ4yIk6sWdYc 1cLWAVrCCUFxGrjX/CDOZbpamcj62BreA/rDX3PGxfNr1N/eXbdIpDcl/Hj/wzKL+F2Tt6lgfJHt+ +wzGbjse5souakXkT/rBStA3HUm+/cLNLztN5oUx3Hif2CbWs60AV5/hQLMSA2RhP3z+BqS4oU94S pMXajK7FlduXyPoqOoBHii0XWjNHizBa5kqdAn31n6Hj7FHQSBpPgWAxNtDglIIWbma7FxdfbcyP1 WQBKQ0bxV9LKJJjR4V3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3sYY-00H3P1-0l; Thu, 15 Jul 2021 04:01:03 +0000 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3sYU-00H3OY-RP for linux-arm-kernel@lists.infradead.org; Thu, 15 Jul 2021 04:01:00 +0000 Received: by mail-qk1-x72e.google.com with SMTP id m68so3909160qke.7 for ; Wed, 14 Jul 2021 21:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6rmQU8jGx9qyfU1QaPi0lk+AKU6KfThL1irBy+Grp3M=; b=kbAZJiSxCI+J5bbjEdRXpIrM96GIXkIs94HB8bdkDJfnxiQVAsVtonrl7HlHnnxn10 5S23XyY+z+lF3qqPJ4iAyP7+plY5yW1P2CbS18vOFEYbtGfMH+ZU5V1D9ivCISbZeILK 5X0t8MB+UVqn+wxa/mcIF3t0rD9FPNWCPoZWQSwnEiq9+/jQ9MUCjL1tRRNF5WW8PNVZ BfQKgmQF8+U1Gpe6d8sfehCfZ9HTiAKQOH9iKV7WByjgb3WYihrk5YOccr7FaiVRMzgo ArdAZVHixj852JUyYKPf263d1Z2M3Jtuz4znWlIQu6zNVsidhS223fg7AgfjRHELER4a 5iZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6rmQU8jGx9qyfU1QaPi0lk+AKU6KfThL1irBy+Grp3M=; b=A2fd5aEcWNKyToJ8jYZ/axlwZDF0kBOFNTq84YCFvJ9gcoqik+x41Y4Ui3+zMQDTrI 130uCJaArp1q/3iLm0S6yw1jt8ip7loRqM3eV+02fvxlJDjdA3MVHdhxZtIeZB0VB4/+ sS3RxEdDRiqI1zlToHy1+LdPtvC7vfoe9BzdYQJH04gW1DINcsx4aLKq2UepbjPHk7gI E7aApiPji1uEBAkRcGUhTuj9Pou/AE4lj17R3/XDJ2KW4Yc2WGck9M88igaBmbz5Yjql PPsJk48l8oVVH8kbLU3m0yRXLaGHUunkNyOH06X5XrrNuQDrmeR86PuBUNIqUv5oXHRv cJxg== X-Gm-Message-State: AOAM531TaMcPMDf99oSX2hfq0428rmj2lbMLBdhaVWqa933llG9X+bmf YCdBbFkvVEsYCmdM2uUuE7Y= X-Google-Smtp-Source: ABdhPJx06BAR0FJNVGXQ4AOnEF8YxXz85J+lxiWBq3RelI+CV1DaPgQz5DICRdCoL+7G0d2CQIPO7A== X-Received: by 2002:ae9:eb54:: with SMTP id b81mr1380516qkg.192.1626321657934; Wed, 14 Jul 2021 21:00:57 -0700 (PDT) Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com. [66.111.4.228]) by smtp.gmail.com with ESMTPSA id 8sm825419qkb.105.2021.07.14.21.00.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jul 2021 21:00:57 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 7D39E27C0054; Thu, 15 Jul 2021 00:00:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 15 Jul 2021 00:00:56 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudelgddutddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeeuohhquhhn ucfhvghnghcuoegsohhquhhnrdhfvghnghesghhmrghilhdrtghomheqnecuggftrfgrth htvghrnhepvdelieegudfggeevjefhjeevueevieetjeeikedvgfejfeduheefhffggedv geejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsg hoqhhunhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqieelvdeghedtieeg qddujeejkeehheehvddqsghoqhhunhdrfhgvnhhgpeepghhmrghilhdrtghomhesfhhigi hmvgdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Jul 2021 00:00:54 -0400 (EDT) Date: Thu, 15 Jul 2021 11:59:14 +0800 From: Boqun Feng To: Sunil Muthuswamy Cc: Bjorn Helgaas , Arnd Bergmann , Marc Zyngier , Catalin Marinas , Will Deacon , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-pci@vger.kernel.org" , Mike Rapoport Subject: Re: [EXTERNAL] [RFC v4 5/7] PCI: hv: Use pci_host_bridge::domain_nr for PCI domain Message-ID: References: <20210714102737.198432-1-boqun.feng@gmail.com> <20210714102737.198432-6-boqun.feng@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_210058_955168_01DFE448 X-CRM114-Status: GOOD ( 16.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 14, 2021 at 05:04:38PM +0000, Sunil Muthuswamy wrote: > > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c > > index 8d42da5dd1d4..5741b1dd3c14 100644 > > --- a/drivers/pci/controller/pci-hyperv.c > > +++ b/drivers/pci/controller/pci-hyperv.c > > @@ -2299,7 +2299,7 @@ static void hv_eject_device_work(struct work_struct *work) > > * because hbus->bridge->bus may not exist yet. > > */ > > wslot = wslot_to_devfn(hpdev->desc.win_slot.slot); > > - pdev = pci_get_domain_bus_and_slot(hbus->sysdata.domain, 0, wslot); > > + pdev = pci_get_domain_bus_and_slot(hbus->bridge->domain_nr, 0, wslot); > > if (pdev) { > > pci_lock_rescan_remove(); > > pci_stop_and_remove_bus_device(pdev); > > @@ -3071,6 +3071,7 @@ static int hv_pci_probe(struct hv_device *hdev, > > "PCI dom# 0x%hx has collision, using 0x%hx", > > dom_req, dom); > > > > + hbus->bridge->domain_nr = dom; > > hbus->sysdata.domain = dom; > With your other patches everything is moving over to based off of bridge->domain_nr. > Do we still need to update sysdata.domain? Yes, we still need it, because x86 is not a CONFIG_PCI_DOMAINS_GENERIC=y architecture, and this patchset only makes CONFIG_PCI_DOMAINS_GENERIC=y archs work with bridge->domain_nr. x86 still use the arch-specific pci_domain_nr(), so we need to set the field in sysdata. Regards, Boqun > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel