From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAB43C07E99 for ; Mon, 12 Jul 2021 11:27:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B297C610C7 for ; Mon, 12 Jul 2021 11:27:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B297C610C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=00dKAdTojFYUtpYCp7048g45OtePb4zkweKxCt2ZXMg=; b=ZzQh+dTPRPeZQJ ND8Ybq8KvsB/9y5tcqLYt/PGORIWiIUqdM+Hei4bwzOf9+4F6u8Fb3EQdcTYmrIgxUUBME6CMFZVz YBP9laVI5yzEXF7/7YkLuB/fHnou062sZz9fCVzgQAMIXuoIXvLqEZwEkuqvXi9lIC252C7F4CG7s 8m4VcONDiqqsHYYd/Ag4jIJziHC6xSpZcDMrq1NdM9nMz673MNaQ8NG4mcbOXdC4tHokCe0MgaylB hhyZUxaF114+LCJCA4ZbuyqniB2/JJmZMbgsVh8tmqwRAzTpolpcctutk0fxs70wnUzagrepbJSBj wj3oObC8mu7Va6tmFx1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2u4D-0078Ae-M5; Mon, 12 Jul 2021 11:25:41 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2u4A-0078A0-1t for linux-arm-kernel@lists.infradead.org; Mon, 12 Jul 2021 11:25:39 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 641AACC; Mon, 12 Jul 2021 13:25:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1626089132; bh=AcmxZ+QiPreemJeQ4MkgH5L1dZQ4jhY7jwo8WBth7r8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P84kdNZ+UJ7ZrGJv/F1d8F5WczxCwnMuqAGJ6yuixY9Hw+ugxzxjThsRKFlgxHJrB /02q6bWR4RN3qlR505cwWq2f5QJQV2m5MPlKk7tJBDpYq58z27KXHa0qckTmj9ee9b gAweMje4CAu5sHMMY5TnfHogM00JdZ4z0eeBX4Sk= Date: Mon, 12 Jul 2021 14:24:46 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Magnus Damm , Kieran Bingham , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: shmobile: defconfig: Restore graphical consoles Message-ID: References: <2a4474be1d2c00c6ca97c2714844ea416a9ea9a9.1626084948.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2a4474be1d2c00c6ca97c2714844ea416a9ea9a9.1626084948.git.geert+renesas@glider.be> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_042538_292203_7C48029C X-CRM114-Status: GOOD ( 19.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, Thank you for the patch. On Mon, Jul 12, 2021 at 12:16:57PM +0200, Geert Uytterhoeven wrote: > As of commit f611b1e7624ccdbd ("drm: Avoid circular dependencies for > CONFIG_FB"), CONFIG_FB is no longer auto-enabled. While CONFIG_FB may > be considered unneeded for systems where graphics is provided by a DRM > driver, R-Mobile A1 still relies on a frame buffer device driver for > graphics support. > > Restore support for graphics on R-Mobile A1 and graphical consoles on > DRM-based systems by explicitly enabling CONFIG_FB in the defconfig for > Renesas ARM systems. Does anyone still care about the Armadillo board ? This being said, I think CONFIG_FB should be added , but for a different reason. There's no KMS console driver, so the only option we have today, even when a KMS driver is available, is to go through FBDEV emulation, which requires CONFIG_FB to be enabled. > Fixes: f611b1e7624ccdbd ("drm: Avoid circular dependencies for CONFIG_FB") > Signed-off-by: Geert Uytterhoeven > --- > To be queued as a fix for v5.14. > --- > arch/arm/configs/shmobile_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig > index 66c8b0980a0a744d..d9a27e4e09140b43 100644 > --- a/arch/arm/configs/shmobile_defconfig > +++ b/arch/arm/configs/shmobile_defconfig > @@ -135,6 +135,7 @@ CONFIG_DRM_SII902X=y > CONFIG_DRM_SIMPLE_BRIDGE=y > CONFIG_DRM_I2C_ADV7511=y > CONFIG_DRM_I2C_ADV7511_AUDIO=y > +CONFIG_FB=y > CONFIG_FB_SH_MOBILE_LCDC=y > CONFIG_BACKLIGHT_PWM=y > CONFIG_BACKLIGHT_AS3711=y -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel