From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F3B5C07E9C for ; Mon, 12 Jul 2021 13:55:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4672161003 for ; Mon, 12 Jul 2021 13:55:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4672161003 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L3xepq2avyXOoPr/q6WkNlzf1Yo4u+0IcF7utSpCENQ=; b=COm86jfGJuhXCl bAtEAaNfVtpAZmeO/f/WnejMe7Q5ibeWpLvzf0ycRrLk1TT/vCOPFV07B+jGyAF9R7OcmhkrFRtON 9tCD1fIrN+2/N6sTijwO/P9/8cUs9b4e2ioTNeOLKsGF1UbU60wzlgnfmksl72DJB5C/UPT9TCOGW Kvk+/yyuhOdZ6FW/bCJzFv8KvoclW66nMNLzJXp4Xc4MMmLCxbWw769UARmZdZ5s1rwGRU5gUYPx5 Fzfh0I5zPtb4IKMMQfYSdWf48OW7KFnEmpYs7iDGs0buCIZVYzegOrHwGqIAfU/GFry+3YKbl1ipA yzNRwpV8kYfcZMJIMANw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2wNE-007ROb-Ka; Mon, 12 Jul 2021 13:53:28 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2wNB-007RNo-F2 for linux-arm-kernel@lists.infradead.org; Mon, 12 Jul 2021 13:53:26 +0000 Received: from maud (unknown [IPv6:2600:8800:8c04:8c00::ffa6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: alyssa) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 198401F4249E; Mon, 12 Jul 2021 14:53:16 +0100 (BST) Date: Mon, 12 Jul 2021 09:53:11 -0400 From: Alyssa Rosenzweig To: Sven Peter Cc: Will Deacon , Robin Murphy , Joerg Roedel , Arnd Bergmann , devicetree@vger.kernel.org, Hector Martin , linux-kernel@vger.kernel.org, Marc Zyngier , Mohamed Mediouni , Stan Skowronek , linux-arm-kernel@lists.infradead.org, Mark Kettenis , Petr Mladek via iommu , Alexander Graf , Alyssa Rosenzweig , Rob Herring , Rouven Czerwinski Subject: Re: [PATCH v4 3/3] iommu: dart: Add DART iommu driver Message-ID: References: <20210627143405.77298-1-sven@svenpeter.dev> <20210627143405.77298-4-sven@svenpeter.dev> <16ffb4ec-86a4-4300-b175-5d7a1fcbf994@www.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <16ffb4ec-86a4-4300-b175-5d7a1fcbf994@www.fastmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_065325_680199_625F48C7 X-CRM114-Status: UNSURE ( 8.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > Should we be checking alignment here? Something like > > > > BUG_ON(paddr & ((1 << DART_TTBR_SHIFT) - 1)); > > > > Sure, right now paddr will always be aligned but adding that > BUG_ON doesn't hurt :) Probably should have suggested WARN_ON instead of BUG_ON but yes. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel