From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB9F2C4338F for ; Tue, 27 Jul 2021 10:41:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 803B261019 for ; Tue, 27 Jul 2021 10:41:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 803B261019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=plYMrubQho1R3mTA2lthXlrAGxXcJNXEKGsOoU2e9HY=; b=cmEu1ZFuxYPEik AaUFK+BePu6KMKoax9hrdNvRTjI5vE3e5BFtB4YrpABlTemUy/n8ARrs8F8v7XehK9yFf9hXBCORb 3TLVkPC5awzknZljzs2WIFpcSVXHOGo5Gn4mpx4rNzOr4sDvkSjju5qVsIKpR2WSm3FJ/YJOMxvyZ th4+tWP9FJVOgYGgR++MXO2+G110zE2f2+91BIexUQHGGF/HH/GJTvtzoD4xckj/WevWTittayVAP IsWXJcLl4PX6t9NI9Gzpl7ur+KriLGv/BZm/HaGzH2U398NXZpNpeVFhHf3T8i/nXV1Uurrweo0dv xSrs5h7dk9h2PXhKsiCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8KUQ-00ETDn-7k; Tue, 27 Jul 2021 10:39:10 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8KUN-00ETCu-34 for linux-arm-kernel@lists.infradead.org; Tue, 27 Jul 2021 10:39:08 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 3600D80F0; Tue, 27 Jul 2021 10:39:24 +0000 (UTC) Date: Tue, 27 Jul 2021 13:39:05 +0300 From: Tony Lindgren To: Andy Shevchenko Cc: Vignesh Raghavendra , "open list:SERIAL DRIVERS" , Jan Kiszka , Greg Kroah-Hartman , Jiri Slaby , Linux OMAP Mailing List , Linux ARM Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH] serial: 8250: 8250_omap: Fix possible interrupt storm Message-ID: References: <20210511151955.28071-1-vigneshr@ti.com> <0ad948ac-f669-3d6d-5eca-4ca48d47d6a3@siemens.com> <56c5d73f-741c-2643-1c79-6dc13ebb05c7@ti.com> <0ae7e313-1ed7-f1be-e8a7-edd1286277a5@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210727_033907_227267_B721AD42 X-CRM114-Status: GOOD ( 18.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Andy Shevchenko [210713 09:14]: > On Tue, Jul 13, 2021 at 11:54 AM Vignesh Raghavendra wrote: > > On 7/13/21 1:57 AM, andy@surfacebook.localdomain wrote: > > > Tue, Jun 22, 2021 at 11:53:38AM +0530, Vignesh Raghavendra kirjoitti: > > ... > > > > https://lore.kernel.org/linux-serial/20170206233000.3021-1-dianders@chromium.org/ > > > > I am not sure if reading UART_LSR is a good idea in the above patch. > > Some flags in LSR register are cleared on read (at least that's the case > > for UARTs on TI SoCs) and thus can result in loss of error/FIFO status > > information. > > > > > https://lore.kernel.org/linux-serial/1440015124-28393-1-git-send-email-california.l.sullivan@intel.com/ > > > > Looks like this never made it. > > Forgot to react to the above. Yes, they never made it because I > believe due to the exact reason you mentioned above. Also California > set up different experiments IIRC and it shows that the problem didn;t > fully disappear with his approach. But maybe yours will work better > (at least it's not the first time I have seen it on different hardware > according to people's contributions). Not sure if this is the same issue with noisy lines, but see also the following in case it's related: [PATCH 2/2] serial: 8250_omap: Handle optional overrun-throttle-ms property Also available at [0] below. Regards, Tony [0] https://lore.kernel.org/linux-omap/20210727103533.51547-1-tony@atomide.com/T/#m5f9da26c32503f2937d3d5977310ca337fa0cb5a _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel