From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F82BC636C8 for ; Thu, 15 Jul 2021 18:14:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3B2B613C9 for ; Thu, 15 Jul 2021 18:14:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3B2B613C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6Dg00mCDWTLYx3ecxtPnZZpDpsNWB6YzNSl1RVuCdhk=; b=YMwwYtw8/mtpKM 9aQ8BQVhNexWUp+Zc58nvGA+UoMGzQMPszHmMM4Y02lVSs6VqniMZwBo+0JviC9/1SOzFqu5SbS1K JGp4OVxWTLLPMKyZXvldv0hEPC6NBeJpnA7UWoeLMHqHhGzjbrqhBIZMxVbm2liGahRuRrqiwZvm0 l9+YuiKvQG3mKTT6bbYEZQtaKkY+5slS9HxTpf2wHrvIXuVh/ebHxu6X3Q3y74XA7cHonj+7skdmP /NzaDD8s9zzXSzUJXr9q1b1IBWlY+Y7qxxnxMadTxo4pZXQxtPRVOcDIMrGDIs4vxookOGmZKKVrW BhTNBwSK4LgRk23bslRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m45qL-001wis-PU; Thu, 15 Jul 2021 18:12:17 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m45qJ-001wih-MQ for linux-arm-kernel@bombadil.infradead.org; Thu, 15 Jul 2021 18:12:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1wkBxUEbT0DVYtgLY8bo8fqQViCHE6yFAYwJFSkVK9o=; b=XNCqO8BCe71uTviFBhVmUUycKI JDvtIxhdi/4acLD11VtR8tfkf/b+XqqtnxWrL2q7aIVcS+ulQtP7QPQav33pp8FMiNRDgz1KIEgiz TNMnVp42zr/0wUo4S+Sw8zx1eV8WdkompgFrC8YIL9R6g+DvccShLFfWZd8zWV4mw7OYn4EPiXare 10S7AayZ19gJAaKczF9p6BrO5OMNiC9WCUUy6ZaMzyIECGttgTpIUkLHtJ7xVFueE68NR0UTFuda5 5khceIUdQP2lyJo+SmEP/frd2FNQCrWsawtt4gGUuk2nbP11BlQnmgSrK4tcjMBZg+qvI/04SaxgE zog6uMLQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m45p0-003blr-HW; Thu, 15 Jul 2021 18:11:16 +0000 Date: Thu, 15 Jul 2021 19:10:54 +0100 From: Matthew Wilcox To: "Russell King (Oracle)" Cc: linux-arch@vger.kernel.org, linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] arm: Rename PMD_ORDER to PMD_TABLE_ORDER Message-ID: References: <20210715134612.809280-1-willy@infradead.org> <20210715134612.809280-2-willy@infradead.org> <20210715164740.GN22278@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210715164740.GN22278@shell.armlinux.org.uk> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 15, 2021 at 05:47:41PM +0100, Russell King (Oracle) wrote: > On Thu, Jul 15, 2021 at 02:46:10PM +0100, Matthew Wilcox (Oracle) wrote: > > This is the order of the page table allocation, not the order of a PMD. > > -#define PMD_ORDER 3 > > +#define PMD_TABLE_ORDER 3 > > #else > > #define PG_DIR_SIZE 0x4000 > > -#define PMD_ORDER 2 > > +#define PMD_TABLE_ORDER 2 > > I think PMD_ENTRY_ORDER would make more sense here - this is the > power-of-2 of an individual PMD entry, not of the entire table. But ... we have two kinds of PMD entries. We have the direct entry that points to a 1-16MB sized chunk of memory, and we have the table entry that points to a 4k-32k chunk of memory that contains PTEs. So I don't think calling it 'entry' order actually disambiguates anything. That's why I went with 'table' -- I can't think of anything else to call it! PMD_PTE_ARRAY_ORDER doesn't seem like an improvement to me ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel