From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17E68C07E9B for ; Tue, 20 Jul 2021 11:15:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D47546023D for ; Tue, 20 Jul 2021 11:15:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D47546023D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YATqN6+fAk4/WUgUJF7pR/FEkgFX2IXJNc1oUmscrFE=; b=ct7KKlMpUl11KB BAMRdPQoiecjMAj6yMp8H9H7Efz1w1k5LRmA7ZyVqHB1NiR3iqiqEXhedLNlMxR8xgaLmwzI8WoZu X1wTPsza8KsJKODnCejr4RAIwgbjg+JFYBWDgeesg/5IU4j9h79x7GqsTaeCttog/uE/nMz52Mfcy XoYvfHd7gf510USBQWajchltDXEJI+t/ICAOTJvPEvqP0gx0aLoOKJcbsbvB3CkIHbVKkhiaVuav7 FC5wc21hH5+bftrrPAoUvi+bRk+Y3mYCQHfB3AzFiLXKwH63OChdPcYofKhcPQyR90JiQMD/3FauJ 4MtVtUqgubxfzK7BhJrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5ngn-00Cc8H-5P; Tue, 20 Jul 2021 11:13:29 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5ngj-00Cc7u-O9 for linux-arm-kernel@lists.infradead.org; Tue, 20 Jul 2021 11:13:27 +0000 Received: by mail-wr1-x42b.google.com with SMTP id t5so25530813wrw.12 for ; Tue, 20 Jul 2021 04:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rssW9MvuSrY18dvpw7amkf+MYjvhgV8BCmj8r2D+edQ=; b=K7vq3dVJv9e19grP2qCy6RAOZY+bX+Abe2GwleQgCAThD/Ktphh7T6Hk8e+U7dOn5Q ymRWUaww5B0nvzeT//Q1p6BowVr0oYbwsyreIyOlK5N8DlZfrIu1zZ9o2opKWlKnBrnk LUCsiCUbO1X92FsH9QqgOFn2KjjXTQLsmYrpMUzxGFAZ/jOUz4jDfZzKO9QRDCm+1dEQ GVPLQBeAySBxe19MQruR5u16/OFBNBl8de3UVr0Z42Ef1FQxlvPify25KeQg4iRdsigB Lo4yVb2io4tvTVln2XGFG39wJoQ/PpjT9OhOUm+uJojX6OCXNmOmMF/3IjDmn6neevRp om0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rssW9MvuSrY18dvpw7amkf+MYjvhgV8BCmj8r2D+edQ=; b=B7AjmSfEs+SYNfxjIIDN220CcjO89O+I5rN8muF8xNL8oIDTgHrdgtg26kIcxIjZce +kBFPZiF/3eaTWZcpKihm29dCqNcyi3omwB/jeMgiCSKHUIQpha888MPPGLO/ImNR8hr GAncwp+Z1Je61Z91fn4koNWQY3RYY0TotRiNY+h4IWQ994Cl3CGtZKDwv8KECz2T9VPW ro+UONUKZkspBlbhxpzmayKFM0xVN29x5zoyDkHqqS1zH7wT4NSUI9q1v+6bK2UhS5vU rb7bFwSFKLnVum4AtTvzBJyCCYApKKoUg4fAV4tnTX2efpPULDh1WoVKb9njGL/T7Gqj liSg== X-Gm-Message-State: AOAM5314NvNkaPyJppthrRoF2MZvOkjzXD4R+KpMvg2CEGmE+4sazrbz MEd/b32ewycIFuRcUnXp5h0RJw== X-Google-Smtp-Source: ABdhPJxucLoq3tJ6ywks6cNiyi6pYtOe5W3MkGbCfwenZlNTGXHtenBEwmkjoTj+HN+TgHpbImyIYQ== X-Received: by 2002:adf:f74f:: with SMTP id z15mr35360657wrp.54.1626779603785; Tue, 20 Jul 2021 04:13:23 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:83e0:11ac:c870:2b97]) by smtp.gmail.com with ESMTPSA id y3sm23651964wrh.16.2021.07.20.04.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 04:13:23 -0700 (PDT) Date: Tue, 20 Jul 2021 12:13:20 +0100 From: Quentin Perret To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, will@kernel.org, dbrazdil@google.com, Srivatsa Vaddagiri , Shanker R Donthineni , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH 04/16] KVM: arm64: Add MMIO checking infrastructure Message-ID: References: <20210715163159.1480168-1-maz@kernel.org> <20210715163159.1480168-5-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210715163159.1480168-5-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210720_041325_843554_EF25CCFC X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thursday 15 Jul 2021 at 17:31:47 (+0100), Marc Zyngier wrote: > +struct s2_walk_data { > + kvm_pte_t pteval; > + u32 level; > +}; > + > +static int s2_walker(u64 addr, u64 end, u32 level, kvm_pte_t *ptep, > + enum kvm_pgtable_walk_flags flag, void * const arg) > +{ > + struct s2_walk_data *data = arg; > + > + data->level = level; > + data->pteval = *ptep; > + return 0; > +} > + > +/* Assumes mmu_lock taken */ > +static bool __check_ioguard_page(struct kvm_vcpu *vcpu, gpa_t ipa) > +{ > + struct s2_walk_data data; > + struct kvm_pgtable_walker walker = { > + .cb = s2_walker, > + .flags = KVM_PGTABLE_WALK_LEAF, > + .arg = &data, > + }; > + > + kvm_pgtable_walk(vcpu->arch.hw_mmu->pgt, ALIGN_DOWN(ipa, PAGE_SIZE), > + PAGE_SIZE, &walker); > + > + /* Must be a PAGE_SIZE mapping with our annotation */ > + return (BIT(ARM64_HW_PGTABLE_LEVEL_SHIFT(data.level)) == PAGE_SIZE && > + data.pteval == MMIO_NOTE); Nit: you could do this check in the walker directly and check the return value of kvm_pgtable_walk() instead. That would allow to get rid of struct s2_walk_data. Also, though the compiler might be able to optimize, maybe simplify the level check to level == (KVM_PGTABLE_MAX_LEVELS - 1)? Thanks, Quentin > +} _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel