From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B0ACC4338F for ; Fri, 23 Jul 2021 11:04:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54F6A60EB2 for ; Fri, 23 Jul 2021 11:04:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 54F6A60EB2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2YhMc0pneQDoKEh7OjNuytURxgzX8fdcakOOeC7UWZg=; b=QJWOPh3IpT8Ru3 EzyDMc10AHIvZKzk21tLlXi80GMHHF88FheLGesrgJ6RKCdk7Th5YKPjj297G7S1p/ZVHpMplNzNk hhNlJoFLUryXmA7ZeaYqr/kFpdo5Neb3NdEs642vQJKrM0WxywK8s6k9DjVPs39SmMFU6Le4RYiKW vN9lsRjt5A0spFhwkYYdOXh7ZO0bsnFOSgsUR4A8mPQrngeGYSCLD54sG0FRdvhw5R22FcYHx6+vv G+/bqtB3/0omezH7G/4OZiHJP7jwOGQ3y6X7EC9u2ecmFJINAeefCKnUpJsRQdGU9V3wCm4zqb3nl LuWl4va8Qv7O37iA8uAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6sx9-004Qha-Kr; Fri, 23 Jul 2021 11:02:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6sx5-004Qh1-AJ for linux-arm-kernel@lists.infradead.org; Fri, 23 Jul 2021 11:02:48 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 31B1360EB2; Fri, 23 Jul 2021 11:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627038166; bh=tErI2vcqXTeZiUkoPXX1NnocpSrL2pNRd47WOhAS1uQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HPWRbVJ8YcJoyO0iwG9wvtQMqVCrpjLHDGtYwSiwYyN82MDk6lVBWUcopcKpF+v3K m1zq3/K9LJplD0gyYGfa2OpQITeoxTM60EKctoVEt7bstbQTlAMOtNug+XBZrXXfcB HVHCBvGF+qtyw4hL4RrQwt5ZKf/0f+U/aQmwPwZg= Date: Fri, 23 Jul 2021 13:02:41 +0200 From: Greg KH To: Ojaswin Mujoo Cc: nsaenz@kernel.org, stefan.wahren@i2se.com, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/5] vchiq: Patch to separate platform and cdev code Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210723_040247_417122_4B86FCEA X-CRM114-Status: GOOD ( 17.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 21, 2021 at 09:50:48PM +0530, Ojaswin Mujoo wrote: > Hello, > > This patchset adderesses the TODO item number 10 specified at: > > drivers/staging/vc04-services/interface/TODO > > For reference, the task is: > > 10) Reorganize file structure: Move char driver to it's own file and join > both platform files > > The cdev is defined alongside with the platform code in vchiq_arm.c. It > would be nice to completely decouple it from the actual core code. For > instance to be able to use bcm2835-audio without having /dev/vchiq created. > One could argue it's better for security reasons or general cleanliness. It > could even be interesting to create two different kernel modules, something > the likes of vchiq-core.ko and vchiq-dev.ko. This would also ease the > upstreaming process. > > A summary of the patches is as follows: > > - Patch 1: Move cdev init code into a function > - Patch 2: Shift some devlarations from vchiq_arm.c to vchiq_arm.h for > sharing > - Patch 3: Move vchiq cdev init code from vchiq_arm.c into vchiq_dev.c > - Patch 4: Decouple cdev code by defining a Kconfig entry to allow > optional compilation of it. > - Patch 5: Merge code in vchiq_2835_arm.c to vchiq_arm.c > > Changes since v3 [2]: > > * In Patch 5, replace forward declarations of some of the functions with > function definition You dropped the reviews of others, so now I need to wait for them again :( _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel