From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 573B5C4338F for ; Wed, 28 Jul 2021 06:58:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E98460F6D for ; Wed, 28 Jul 2021 06:58:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1E98460F6D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TlWJGAe5cmZQaJWWrniCA7Kb5polgsfCghFae7sxqqA=; b=m68OpJfqJLqCBG pyWGFlmH46s0btyBQX7kizLbXaGqOgyEdqdHKEFo1OjSaswjgwB3IZLz0Hz4eDl6EYYRCD8t6TPiB OjfqD/csnluniba93SVR/QIacwksJt+lp7IFyb7mn4o6QZqqsYQFxMO1V/ZTrTZzslMatGO5B22RB vLgkUEYP6t1/hYWUkJqVv7HDAOAAskM6zcTx129oozmB9Qloln+f8AO9/1M6uG1EXOIoayQ434x8H h588YDv0iuf5ZJ3UMhVPd84MyFJqnlX5QLSvei+Rfbh4p3EIhcoRgb7kgO27215AhBntykE/ISZfY ubBC1bss39HTwVxsOLJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8dUx-00HIz7-1i; Wed, 28 Jul 2021 06:56:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8dUt-00HIyW-3w for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 06:56:56 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D3ECA60F6D; Wed, 28 Jul 2021 06:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627455414; bh=uG4A0x8I1qOLetqrP5zVU9v4dMBfQQBdM6FU6vTMBmI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MVAR6HwsGo+IqLUIwPYqelXm/CDjdZpXlJve7lqY+otMsIuecNvV63Kjed3G+Kg2Y RnxvH8vBjrpT8FwSCuYJLaWzVBwcBQY7AVDmGVRUCVsdDchbpizp6zYA7lm2tbaE0B vRS/Mop+nvQR413/a8uPim3ovhtUo94W9WhLX3C7OUA53CaSOCrlB2Z+xC4677JRE8 1OyG/NrxNUePg0+CJH8pomkIM9I2ioyve586lkR544a15EOxa/6+xXzb8nVTMOwzxl I0kpJnd91f+fYW7lqplTZto7aOLm4R4qpvPgqbe2OsdDIOEJvDgvqF8aHbAvdoBn/q zMpKbiHrJMSlA== Date: Wed, 28 Jul 2021 12:26:50 +0530 From: Vinod Koul To: =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= Cc: Ludovic Desroches , Tudor Ambarus , Alexandre Belloni , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: at_xdmac: use module_platform_driver Message-ID: References: <20210625090042.17085-1-clement.leger@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210625090042.17085-1-clement.leger@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210727_235655_219342_E70D4B95 X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25-06-21, 11:00, Cl=E9ment L=E9ger wrote: > The driver was previously probed with platform_driver_probe. This does > not allow the driver to be probed again later if probe function > returns -EPROBE_DEFER. This patch replace the use of > platform_driver_probe with module_platform_driver which allows that. > = > Signed-off-by: Cl=E9ment L=E9ger > --- > drivers/dma/at_xdmac.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > = > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index 64a52bf4d737..109a4c0895f4 100644 > --- a/drivers/dma/at_xdmac.c > +++ b/drivers/dma/at_xdmac.c > @@ -2238,11 +2238,7 @@ static struct platform_driver at_xdmac_driver =3D { > } > }; > = > -static int __init at_xdmac_init(void) > -{ > - return platform_driver_probe(&at_xdmac_driver, at_xdmac_probe); > -} > -subsys_initcall(at_xdmac_init); > +module_platform_driver(at_xdmac_driver); You are also changing the init call here, there is a reason why dmaengine drivers are subsys_initcall.. have you tested this? -- = ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel