From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D9FEC4338F for ; Thu, 29 Jul 2021 16:52:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C06D60E76 for ; Thu, 29 Jul 2021 16:52:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0C06D60E76 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=efn/EDl9CBCjmGTnF5PtSZ3i8Uk+wMigHXb4uprmmYc=; b=qxlCigCEJjBZwz 4EcFk+8NX37uomkqPS4LmODeVFkM0TpM2jTVMBUpjD1KqPxG7kVwmjB6KVBzyuUNdYHLJb0wBTb1Q hmF8Vcl0jibVjBF/NjGzZyscj8tGqdcB1GwyPrAP7IP63WK3LPenRPR+zxS/uF+BoqNjpgTeRiFIe BY9aYFj57pCHIVftWJj4T0RfCRWUQlgr4aeLohu+MPiZX8UR1st8TwAFEjvDozvyCTE+FAxa3dlOP Edi5l0DexmQmvRCz5R2SkfDFuZ7b7qDIl9H9XW2KnkN9hrIAZ4dDiIM/ZYyFMNiGxR0xSAZvsuepv IQ0Pzt2PuXxFoQjf6aGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m99Ex-0059Dn-8d; Thu, 29 Jul 2021 16:50:35 +0000 Received: from mx2.smtp.larsendata.com ([91.221.196.228]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m99Er-0059BM-Je for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 16:50:32 +0000 Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 1c1c2356-f08d-11eb-8d1a-0050568cd888; Thu, 29 Jul 2021 16:50:41 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id D1FF4194B1F; Thu, 29 Jul 2021 18:50:41 +0200 (CEST) Date: Thu, 29 Jul 2021 18:50:17 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Robert Foss Cc: Jagan Teki , Marek Vasut , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-samsung-soc@vger.kernel.org, Joonyoung Shim , Neil Armstrong , linux-amarula , dri-devel , Krzysztof Kozlowski , Seung-Woo Kim , Frieder Schrempf , Andrzej Hajda , Kyungmin Park , Laurent Pinchart , Daniel Vetter , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , NXP Linux Team Subject: Re: [RFC PATCH 05/17] drm/exynos: dsi: Get the mode from bridge Message-ID: References: <20210704090230.26489-1-jagan@amarulasolutions.com> <20210704090230.26489-6-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_095029_971518_D93877C7 X-CRM114-Status: GOOD ( 25.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 29, 2021 at 03:20:17PM +0200, Robert Foss wrote: > Hey Jagan, > > On Sun, 4 Jul 2021 at 11:04, Jagan Teki wrote: > > > > Now the exynos dsi driver is fully aware of bridge > > handling, so get the display mode from bridge, mode_set > > API instead of legacy encoder crtc. > > > > This makes bridge usage more efficient instead of relying > > on encoder stack. > > > > Add mode_set in drm_bridge_funcs. > > > > Signed-off-by: Jagan Teki > > --- > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > > index d828be07c325..99a1b8c22313 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > > @@ -275,6 +275,7 @@ struct exynos_dsi { > > u32 format; > > > > int state; > > + struct drm_display_mode mode; > > struct drm_property *brightness; > > struct completion completed; > > > > @@ -881,7 +882,7 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi) > > > > static void exynos_dsi_set_display_mode(struct exynos_dsi *dsi) > > { > > - struct drm_display_mode *m = &dsi->encoder.crtc->state->adjusted_mode; > > + struct drm_display_mode *m = &dsi->mode; > > unsigned int num_bits_resol = dsi->driver_data->num_bits_resol; > > u32 reg; > > > > @@ -1411,6 +1412,15 @@ static void exynos_dsi_bridge_disable(struct drm_bridge *bridge) > > pm_runtime_put_sync(dsi->dev); > > } > > > > +static void exynos_dsi_bridge_mode_set(struct drm_bridge *bridge, > > + const struct drm_display_mode *mode, > > + const struct drm_display_mode *adjusted_mode) > > +{ > > + struct exynos_dsi *dsi = bridge_to_dsi(bridge); > > + > > + drm_mode_copy(&dsi->mode, adjusted_mode); > > +} > > + > > static int exynos_dsi_panel_or_bridge(struct exynos_dsi *dsi, > > struct device_node *node) > > { > > @@ -1451,6 +1461,7 @@ static int exynos_dsi_bridge_attach(struct drm_bridge *bridge, > > static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = { > > .enable = exynos_dsi_bridge_enable, > > .disable = exynos_dsi_bridge_disable, > > + .mode_set = exynos_dsi_bridge_mode_set, > > As far as I understand it, .enable(), .disable() &.mode_set() are > deprecated[1] and should be replaced by atomic_enable(), > atomic_disable() & atomic_enable() respectively. > > [1] https://lore.kernel.org/dri-devel/20210722062246.2512666-8-sam@ravnborg.org/ Correct, we are slowly moving away from the deprecated bridge functions. Need to find time to update my patchset that address some of this. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel