From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30904C4338F for ; Thu, 29 Jul 2021 17:02:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E77CD608FB for ; Thu, 29 Jul 2021 17:02:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E77CD608FB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TRUTdfdXj/kGLVM0L5eoK09cuP8HcsW3RmebHq1B1yI=; b=vQ4Txrl09Me5ig ByP4mods1aH/KJJ4dsJyePA83Jyiah+J5X5g1m7T5gms7fahJo2Va2KzZx8A3gJP8KqQ+dz0lmb23 aTbDp9X+lJf7fTH1TgzaxshlkIxsbQDzKaFdxD5clm1VXLMCRGAqwvcyUy6tC7mfC5sOnmjV+0moj FZbzcsp7cnP0DkRtFVYR5kyqFuzV8dSSGtozNUZHaoPpx/w9L7Z9Mb+x0GCcSvEyPUAA1Bv5zrtms nAgVWukrxbpZ8TK+aiNiPZBaJyBtaGALcJBmz2jWhwWXAvLFXBBBKP/fPqWZaYU8jNPgqBOUDLflG 1scyaJAg4P4TOBVNsKQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m99Ob-005Cfm-Ic; Thu, 29 Jul 2021 17:00:34 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m99OY-005Cdc-1g for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 17:00:31 +0000 Received: by mail-wr1-x430.google.com with SMTP id m12so2969677wru.12 for ; Thu, 29 Jul 2021 10:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rFgImdL4oRnQoKBA5pI3AwMwu/TF6E4dvPNBUaLQNFQ=; b=Ym5Ufkl/exEhxT3LXpkyNJPvberJTQmdCqua9HnSvE4M1l834pSV3ErwW2z0EyYWzN 25tlJDAdf4Z8milEdWy0tk01sdQ6hArqX5HIewWnMc4zSAriwLR/66Pb62qomNeOfoZ9 uHH4jP7oMOLk7iBAtSooAcqjMGyBacUbzwf2prksRZN34Etp9YS6CxBG1OmhWxdt5iwv Cz0hTGe2SZ6LQAjhb/19b6Onsoqj3n+calSmMc1PqDOdl6S5v2E+DIvW1JqZultHFGaZ e0HJto+/7kXHwepNw+rHHp76Vd4deu1YTEZU2A+fO6L5MjxxixVrUs1tBlqHMKsC19AF Ywgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rFgImdL4oRnQoKBA5pI3AwMwu/TF6E4dvPNBUaLQNFQ=; b=ET/hlC+QlCAGI4B2WbDtDE6KqjPzrJ/btsEuyr3pesd/e8rosZAb93vuHMVEEXFgJn MAeSB+lssa7V6ULgOBhX1lWa3x1qMoLJsutSkEnPDnmDv8AOFNL8QsrbDwiG8pYj2V8P Cp74r+04pQeRK63fPczoJ2lnwFzk1KEA9vr/KuSdTT+N6mWLUD5ZWuNU4s5F0fo284di 9xyxl2qgO9tjeqOkGAs6RVm23lQzjX5zQN4FlPnhMGp3o/wpvoyPOr8LT/IDEnNpQNAM nHFwodWFA3VF8Pb2nu0wSHtZ8srAaEUCWFIg2V3Lazp0a3dVYQnd26ASbJnHG/qwr5Qe /zJA== X-Gm-Message-State: AOAM5310+HdmL4dYUsQGZVZnSfV7EdmF0jMoUs+82rl0jLV5lLEgk26n m4PIFfb1XFPxgdahZzhqxH1NGg== X-Google-Smtp-Source: ABdhPJyFz2hml+WnVbZ7VNzv3kjo6OC8XSEJ53KL7oluYjYUSeypg9pkHqCQ9bSEkCwBjaOkz9WNEQ== X-Received: by 2002:a5d:53ca:: with SMTP id a10mr4243003wrw.197.1627578027075; Thu, 29 Jul 2021 10:00:27 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:293a:bc89:7514:5218]) by smtp.gmail.com with ESMTPSA id q22sm3841194wmc.16.2021.07.29.10.00.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 10:00:26 -0700 (PDT) Date: Thu, 29 Jul 2021 18:00:23 +0100 From: Quentin Perret To: David Brazdil Cc: kvmarm@lists.cs.columbia.edu, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] KVM: arm64: Minor optimization of range_is_memory Message-ID: References: <20210728153232.1018911-1-dbrazdil@google.com> <20210728153232.1018911-3-dbrazdil@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210728153232.1018911-3-dbrazdil@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_100030_147848_2518C171 X-CRM114-Status: GOOD ( 20.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday 28 Jul 2021 at 15:32:32 (+0000), David Brazdil wrote: > Currently range_is_memory finds the corresponding struct memblock_region > for both the lower and upper bounds of the given address range with two > rounds of binary search, and then checks that the two memblocks are the > same. Simplify this by only doing binary search on the lower bound and > then checking that the upper bound is in the same memblock. > > Signed-off-by: David Brazdil > --- > arch/arm64/kvm/hyp/nvhe/mem_protect.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > index a6ce991b1467..37d73af69634 100644 > --- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c > +++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c > @@ -189,13 +189,18 @@ static bool find_mem_range(phys_addr_t addr, struct kvm_mem_range *range) > return false; > } > > +static bool is_in_mem_range(phys_addr_t addr, struct kvm_mem_range *range) > +{ Nit: addr@ could be u64 for consistency -- struct kvm_mem_range holds IPAs in general. > + return range->start <= addr && addr < range->end; > +} > + > static bool range_is_memory(u64 start, u64 end) > { > - struct kvm_mem_range r1, r2; > + struct kvm_mem_range r; > > - if (!find_mem_range(start, &r1) || !find_mem_range(end - 1, &r2)) > + if (!find_mem_range(start, &r)) > return false; > - if (r1.start != r2.start) > + if (!is_in_mem_range(end - 1, &r)) > return false; > > return true; Nit: maybe drop the second if and simplify to: return is_in_mem_range(end - 1, &r); With that: Reviewed-by: Quentin Perret Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel