From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 231A4C432BE for ; Mon, 2 Aug 2021 07:05:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E587660E76 for ; Mon, 2 Aug 2021 07:05:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E587660E76 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WiliMzcvy6pJ4s2/zOZkwHdtMJ+Qd6RXodh9zyJGC0g=; b=udw0TbkUkf2c1H MiDL2DoWFXMom6owJtDFgaXVsHCZqDFdMEi0MmgEUi9yf6KxdIRcANb1HLoLW85wzZix81rGJID2h DoNSh00E2UlDJURfMRfO5gl7mNUXwqUTNyVttkU/94w+5DW162kV1s10By4k+cISX2x0+O7hbHEoH TcF2VMhnRu28C9z4fTpSo7YIFBN2yYgRQHI/T7oWuwyTBdCBBUdXXbBinI39HH/tFtlVuiBRq2nzt FhG7gYROOMUkzUZNbQ1xvXlnZ1LLXv5hnltLDxPTX2Ekv0WWB5rPi/Y+OUCKtRDNV4TaLLH+GswrL 7nkB+D6WSo6go7XL0kbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mARzN-00FEI6-Dp; Mon, 02 Aug 2021 07:03:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mARzJ-00FEHa-CP for linux-arm-kernel@lists.infradead.org; Mon, 02 Aug 2021 07:03:50 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9CF7A60D07; Mon, 2 Aug 2021 07:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627887828; bh=NKl+nkYf7lr7H2SbcBdWTsOdU4qUqQPTa+Dss6PlQoY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k+DEhCOtrl64l4nIYok+2yIiDF72qLlrpKouaCv4j7Nl5psQeJebwM5h8Dtdilzdl b953+/umtsr3qraFzSECT/AH1+saKm7NqCLuR0lS/DCdVPvQ5fLU094jDlW8woKmOp tTdpvo5hVt1qc/agzvqxfUkMF9tRAk/daA/qthBSUvCftu5LPNAllv1ajTarEzRXs2 wpPtyJLpGm+9lreW4JRBijk8PpivFkc8SDhPgH2kJ6jDJcTZBi4tUD+YSYN2F+ECsN OXB4XroHWfSC3v3f9OV6ZaT9pCJ5CGVYj9vQ9dcAyMQVrFTafFTV65/ckDtKCEe3fO lyCaq5l+ERcKw== Date: Mon, 2 Aug 2021 12:33:44 +0530 From: Vinod Koul To: Juergen Borleis Cc: dmaengine@vger.kernel.org, linux-imx@nxp.com, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, shawnguo@kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] dma: imx-dma: configure the generic DMA type to make it work Message-ID: References: <20210729071821.9857-1-jbe@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210729071821.9857-1-jbe@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_000349_483734_0B82872A X-CRM114-Status: GOOD ( 15.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29-07-21, 09:18, Juergen Borleis wrote: > Commit dea7a9f you should use 12+ chars for sha1 > dmaengine: imx-dma: remove dma_slave_config direction usage even with this is commit log, you made the patch tile dma: ....! > > changes the method from a "configuration when called" to an "configuration > when used". Due to this, only the cyclic DMA type gets configured > correctly, while the generic DMA type is left non-configured. > > Without this additional call, the struct imxdma_channel::word_size member > is stuck at DMA_SLAVE_BUSWIDTH_UNDEFINED and imxdma_prep_slave_sg() always > returns NULL. I ahve fixed the subsystem name, updated commit in 12 chars and format expected, added it as Fixes line and applied. Please take care of these things! > > Signed-off-by: Juergen Borleis > --- > drivers/dma/imx-dma.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c > index 7f116bb..2ddc31e 100644 > --- a/drivers/dma/imx-dma.c > +++ b/drivers/dma/imx-dma.c > @@ -812,6 +812,8 @@ static struct dma_async_tx_descriptor *imxdma_prep_slave_sg( > dma_length += sg_dma_len(sg); > } > > + imxdma_config_write(chan, &imxdmac->config, direction); > + > switch (imxdmac->word_size) { > case DMA_SLAVE_BUSWIDTH_4_BYTES: > if (sg_dma_len(sgl) & 3 || sgl->dma_address & 3) > -- > 2.20.1 -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel