From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEF3CC43214 for ; Mon, 2 Aug 2021 18:29:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9589610A2 for ; Mon, 2 Aug 2021 18:29:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A9589610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ifj76QzNKEKs1hCp/LjP1fq8n/FFdQTFoguRxo+98IM=; b=Kzz0/vu1wDalY0 GoOa4us0mtEzvY9c7QtqyM6Q6b6pIoOOAd31KULbFbyB3ktO4t2UjKcRtcZXerf2YCB8owhuLZK4+ GnQW6PGPm9bTNfBhCTEVVhT0xz44h7MVqjBjEOt839bS8JmeOFpHWZ8ZYlBErJSyPaZkoN8jNvZDq j++xrC3XsP9sgBr/EymLSCLQCy7fTM4wDZik+ikFDZIl7Bi7Ab8uNF95MaCS/PXG9W6krvv1nVl6e kv9Ri1NRYiPldGs2n9YxckL8kEFd05/pTR0Cz7XBoaOoVAYeWcRNch5dI6AhgmYYGc2z1XA4cyNSo 9RjVZednYw5iPtkeirig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAceg-00HVcS-Nc; Mon, 02 Aug 2021 18:27:14 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAcec-00HVaX-Dd for linux-arm-kernel@lists.infradead.org; Mon, 02 Aug 2021 18:27:11 +0000 Received: by mail-wm1-x32c.google.com with SMTP id f9-20020a05600c1549b029025b0f5d8c6cso53748wmg.4 for ; Mon, 02 Aug 2021 11:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=DTKhTm7Ptg33LCmAo/w+iCwbuM4MPLTXMtIM7VJDESs=; b=XSipToRaSYK8r/yD7Y2zbkP6xbYJje+aooSF0mhT0oVLuyaMKIePaSg1zx3ZCe8RbB kS/zCjZ24853zmMTLuE+JMDuQ/seXGbLPh0BYIj1AbbbudTfAOnPO6ATTr7ruQfi+OuM harDKQpcKQdzKJlIfCjqbcDlDmVI84AYKvIHQ6fBG1BqnTk9jUMbtVQz8WKzaUCLLnS5 nFZw1RzFeWCd7OfGppbdPpaBi5h2c7gjY6A8S8ngAC3APaD2+EAeXGDu/aZC/pgOSHhy rwdfCq5trcb1HvacEODObZ5X5WYYx3LmWsaJ+G/95MC4DAjT+LEDXrMOQNqVwTlJR9Dk mWFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=DTKhTm7Ptg33LCmAo/w+iCwbuM4MPLTXMtIM7VJDESs=; b=WuHkkg1Jgh4UJlpPoxR6UtOFq7ApOscvcz2EsyL6mbWDHXxEHJH+iIce6DviZjQrdJ VhDgogtXn81bKLmgOzGJ50I5SI5M2FHAelC7SLISyPeQK0S3/wBkWyWqZQaDJOFDa0PC sAHdXyH4aqSDSYa5hT/MpezFo7aThGqDkLSrJHaHGQmQQHGE4XTqfO261nuM+kiX3itl itV6B/0tKn/8un0Q+vbPHDdlAloB2En6hxfOpH/vWQiiszYrc4nvGyhCVA1G1LXUmwXo 6UTzXylsssuw3dA+Kdb7/XWo0qW/ed5Bv3NPr088kPzS4sZBn2e8f9k2MOiwTpgQHKTq xtZQ== X-Gm-Message-State: AOAM533NboJLteUBL9VtdiHc6p9qauxgL4+IWKAjX6Lm0R5y+u9Lnohv B2iREDJHUJZBgoIFcHRZcHk= X-Google-Smtp-Source: ABdhPJymktIwUnfQLR4bmt28w5+VecVM+04e+/xdZY89WAq8zBoRUTO9t6fdiK4z/lEwUTGG2ZhK6A== X-Received: by 2002:a7b:c5c7:: with SMTP id n7mr18520297wmk.5.1627928828647; Mon, 02 Aug 2021 11:27:08 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id w5sm14025259wro.45.2021.08.02.11.27.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 11:27:08 -0700 (PDT) Date: Mon, 2 Aug 2021 20:27:06 +0200 From: Corentin Labbe To: Dongliang Mu Cc: Herbert Xu , "David S. Miller" , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Ard Biesheuvel , Xiang Chen , Eric Biggers , Colin Ian King , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] crypto: sun8i-ss: fix multiple memory leaks in sun8i_ss_hash_run Message-ID: References: <20210726152533.2281139-1-mudongliangabcd@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210726152533.2281139-1-mudongliangabcd@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_112710_512772_2F5FDA8F X-CRM114-Status: GOOD ( 10.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Mon, Jul 26, 2021 at 11:25:21PM +0800, Dongliang Mu a =E9crit : > In sun8i_ss_hash_run, all the dma_mmap_sg/single will cause memory leak > due to no corresponding unmap operation if errors happen. > = > Fix this by adding error handling part for all the dma_mmap_sg/single. > = Hello I have nearly the same comment than on your sun8i-ce patch, (copy result on= ly if err=3D=3D=3D0 and wording). Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel