From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E0FC4338F for ; Mon, 9 Aug 2021 09:13:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B13D61075 for ; Mon, 9 Aug 2021 09:13:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8B13D61075 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=78fc/eqxY2J024DqI0EhRnuN67sBUl79knaT32cT3l0=; b=LQxfMwcBnrKPKd 1NfPLAmj9yTuzjyfoUYHC/OgBWfMnkvA4I0AYy+4jREMAmAtU9JiIdHGXOHudILPRHfJ4GtWdLe2c YGAjzXHICeVNHdkBFqeBJFCt9YWodZbKlSn9NKmvwnu4lVW8zRFam2GWJd11A/V4XIO+8XX9Vzxmp Iqo+0esUkYEu8IRotiEcLN1+Tw0NGx4ZrU8o9zskV2Qj2Ku7/9qIJ7AFsKUK4UbbXqjsf6TIz5A3Y wtzZ6zEX/jGFqkXfWr8MahA4ypkDXsM86G9+vJhOylC0dEZGueYVafZATmiPoq2T7vX9ZLUD69olI 7i7yBSVKd+Otk64JZC6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD1K0-00HYYs-U8; Mon, 09 Aug 2021 09:11:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD1Jx-00HYYF-FG; Mon, 09 Aug 2021 09:11:46 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A562D6101D; Mon, 9 Aug 2021 09:11:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1628500305; bh=UCLknj9tc8LczjOHUUN+VpDgDoLql2fB1/oOaHk0U18=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AAfCz0PGiIhXhwGWCYjbYcGQe5P9XYiS7XrTSkAINzG3Tv8LOJJSOxhTDE81G7Oty 42Dx+ZcLlxZWtIEOFGroZlWZAAN2A/TVkEM1uRAy8Va3jmvOgXAp+p9uqyjpqBMF3l BP/vLH9aUsg9j2tKycFfDaoEFQG1CDZnFQ8hGSVk= Date: Mon, 9 Aug 2021 11:11:42 +0200 From: Greg Kroah-Hartman To: Ikjoon Jang Cc: linux-usb@vger.kernel.org, Chunfeng Yun , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mathias Nyman Subject: Re: [RFC PATCH] usb: xhci-mtk: handle bandwidth table rollover Message-ID: References: <20210809165904.RFC.1.I5165a4a8da5cac23c9928b1ec3c3a1a7383b7c23@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210809165904.RFC.1.I5165a4a8da5cac23c9928b1ec3c3a1a7383b7c23@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210809_021145_570846_82171E81 X-CRM114-Status: GOOD ( 10.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 09, 2021 at 04:59:29PM +0800, Ikjoon Jang wrote: > xhci-mtk has 64 slots for periodic bandwidth calculations and each > slot represents byte budgets on a microframe. When an endpoint's > allocation sits on the boundary of the table, byte budgets' slot > should be rolled over but the current implementation doesn't. > > This patch applies a 6 bits mask to the microframe index to handle > its rollover 64 slots and prevent out-of-bounds array access. > > Signed-off-by: Ikjoon Jang > --- > > drivers/usb/host/xhci-mtk-sch.c | 79 +++++++++------------------------ > drivers/usb/host/xhci-mtk.h | 1 + > 2 files changed, 23 insertions(+), 57 deletions(-) Why is this "RFC"? What needs to be addressed in this change before it can be accepted? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel