From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52B60C4338F for ; Mon, 9 Aug 2021 14:40:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 129D161004 for ; Mon, 9 Aug 2021 14:40:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 129D161004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0C4QIEstkpMlLWslqaj2w7jg473NwJhBH24ZwiRkLYo=; b=emsjLLNbZved0f qhHy9RMjT2t/5/cQQRsQMDoYyeTPmGYzZe9dG1uO/AaHmIRzFEwO2yoDLjYY8SpbcfQjYRpozVwpE xHPPNm0DZBtzUSLlEQ9q8pRZVYw8W27RjhN56R5rcwzQp22CxlzqZeiTSTAiiisW0KNrVvdW2KjAs /ClWPcSTRvkokrt0/4X1zEi3miUCXdq7NgImP7oBB3lX18ZMR/bOTHlx4HF8Fy/y8EcLYNlLzUIlA MHHBhPTIcLr8WuhQbwpHfYSEbCy9y2h6sLMf25HYml/p3xBCpdLQhfhc5dxzQGPHjGMVQ0+aDMgzL QODxJQ69vjZri+6FC0Ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD6Qh-000w74-E7; Mon, 09 Aug 2021 14:39:03 +0000 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD6Qd-000w6S-St for linux-arm-kernel@lists.infradead.org; Mon, 09 Aug 2021 14:39:01 +0000 Received: by mail-io1-xd33.google.com with SMTP id i7so21600627iow.1 for ; Mon, 09 Aug 2021 07:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZJFa7d2MMspvNHYHeb9vzFdsiru50qHv4RgXeKQT0og=; b=IqozBY6P6n0YzqrBK7p9SAteUFAqjxnyGIHv/kYcKrr7nh9bL7VPCKSImSd2ExBqAD WzClQLbIPTw/VyD/METBhkisqtqZL6E+PGlEho0TyWVqevTjI76YGCP7pJYPDkcP2Kx6 BWkVdJhjWjqsqWnxMaYRFal57J3B7DpnlOiDrlbb/pVQZONG710/ZiDCNcqyGBJEOwIp TTkNSRLHE2iQT0Eb+i+SmbKimGdkg+TYvgl4MFVD4fRSPU9BgubVJ8pXmhoVnfJF+wy8 gDuTphWzFAGamMS7H4d5d5DRTPqFgNu4WdAgdpSc03egz7LLEV23beRgQhi5chCx6Ll1 K/zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZJFa7d2MMspvNHYHeb9vzFdsiru50qHv4RgXeKQT0og=; b=jcZO2h8C0YnB+9hpztS6R8lG4BdsuC/OPiFvZVgXWdKfxnsU3GrLIIha9ilMXc4nwU bZShZ3mcG71nMyeH/wfnfhqBMuW5t48KzTIzDCe6AE9TWSxDOLpSsVsSx+8W5EG3TEJq g33j1+qhfrOLqf9oo61SxsFS9RubOnHvkDIzUj2eZ3ev7hX0RNt15ZyrUnSSXYIduv6u z557M5Lf3662lJqVDTPQoHwhBlH8qD7+rtTsnwiqSlPEZYfsnl/9TsNB9TsVa8CwOmVP xYw1y0Ih8C945KCqR6iSKBOmkxr9gJuvI42GJaCrlbdtyyT4hrnDcvLgvcdUuAMgvS0B tjtw== X-Gm-Message-State: AOAM5330Q5B/c1E+fG/KZ22zY7R6xNB7qg/zjQkZkyW5PyC0SjLCQgNl MdwxSnK7Oyx3Ah3NQO2o6GU= X-Google-Smtp-Source: ABdhPJz6AaDqIPar7LvgnhtcoluXCQeKSt2vZi3mKbto+SViQe/qpvzlij4OcoX6HW4KgxE8Djvsnw== X-Received: by 2002:a02:2348:: with SMTP id u69mr22677803jau.141.1628519937572; Mon, 09 Aug 2021 07:38:57 -0700 (PDT) Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com. [66.111.4.228]) by smtp.gmail.com with ESMTPSA id z22sm10866290ioe.52.2021.08.09.07.38.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Aug 2021 07:38:56 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id E03FD27C0054; Mon, 9 Aug 2021 10:38:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 09 Aug 2021 10:38:55 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjeejgdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepuehoqhhunhcu hfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrghtth gvrhhnpedvleeigedugfegveejhfejveeuveeiteejieekvdfgjeefudehfefhgfegvdeg jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegsoh hquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeiledvgeehtdeigedq udejjeekheehhedvqdgsohhquhhnrdhfvghngheppehgmhgrihhlrdgtohhmsehfihigmh gvrdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 Aug 2021 10:38:53 -0400 (EDT) Date: Mon, 9 Aug 2021 22:38:48 +0800 From: Boqun Feng To: Lorenzo Pieralisi Cc: Bjorn Helgaas , Arnd Bergmann , Marc Zyngier , Catalin Marinas , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, Sunil Muthuswamy , Mike Rapoport Subject: Re: [PATCH v6 8/8] PCI: hv: Turn on the host bridge probing on ARM64 Message-ID: References: <20210726180657.142727-1-boqun.feng@gmail.com> <20210726180657.142727-9-boqun.feng@gmail.com> <20210803171451.GA15466@lpieralisi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210803171451.GA15466@lpieralisi> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210809_073859_986796_9A42EED5 X-CRM114-Status: GOOD ( 32.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 03, 2021 at 06:14:51PM +0100, Lorenzo Pieralisi wrote: > On Tue, Jul 27, 2021 at 02:06:57AM +0800, Boqun Feng wrote: > > Now we have everything we need, just provide a proper sysdata type for > > the bus to use on ARM64 and everything else works. > > > > Signed-off-by: Boqun Feng > > --- > > drivers/pci/controller/pci-hyperv.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c > > index e6276aaa4659..62dbe98d1fe1 100644 > > --- a/drivers/pci/controller/pci-hyperv.c > > +++ b/drivers/pci/controller/pci-hyperv.c > > @@ -40,6 +40,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -448,7 +449,11 @@ enum hv_pcibus_state { > > }; > > > > struct hv_pcibus_device { > > +#ifdef CONFIG_X86 > > struct pci_sysdata sysdata; > > +#elif defined(CONFIG_ARM64) > > + struct pci_config_window sysdata; > > This is ugly. HV does not need pci_config_window at all right > (other than arm64 pcibios_root_bridge_prepare()) ? > Right. > The issue is that in HV you have to have *some* sysdata != NULL, it is > just some data to retrieve the hv_pcibus_device. > > Mmaybe we can rework ARM64 ACPI code to store the acpi_device in struct > pci_host_bridge->private instead of retrieving it from pci_config_window > so that we decouple HV from the ARM64 back-end. > > HV would just set struct pci_host_bridge->private == NULL. > Works for me, but please note that pci_sysdata is an x86-specific structure, so we still need to define a fake pci_sysdata inside pci-hyperv.c, like: #ifndef CONFIG_X86 struct pci_sysdata { }; #end > I need to think about this a bit, I don't think it should block > this series though but it would be nicer. After a quick look into the code, seems that what we need to do is to add an additional parameter for acpi_pci_root_create() and introduce a slightly different version of pci_create_root_bus(). A question is: should we only do this for ARM64, or should we also do this for other acpi_pci_root_create() users (x86 and ia64)? Another question comes to my mind is, while we are at it, is there anything else that we want to move from sysdata to ->private? These questions are out of scope of this patchset, I think. Maybe it's better that we address them in the future, and I can send out separate RFC patches to start the discussion. Does that sound like a plan to you? Regards, Boqun > > Lorenzo > > > +#endif > > struct pci_host_bridge *bridge; > > struct fwnode_handle *fwnode; > > /* Protocol version negotiated with the host */ > > @@ -3075,7 +3080,9 @@ static int hv_pci_probe(struct hv_device *hdev, > > dom_req, dom); > > > > hbus->bridge->domain_nr = dom; > > +#ifdef CONFIG_X86 > > hbus->sysdata.domain = dom; > > +#endif > > > > hbus->hdev = hdev; > > INIT_LIST_HEAD(&hbus->children); > > -- > > 2.32.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel