From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6132DC4338F for ; Tue, 10 Aug 2021 12:40:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 280A7604DC for ; Tue, 10 Aug 2021 12:40:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 280A7604DC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=neSpjeXKcHn06m2VUwD8qe7zO7GwuXBkVS1dtOJQtbQ=; b=Tn2NiF5+Xbjlks NnFPTospx7Re9O1cagZwiQbAg+c+sDF0jAjw0E2tA6eKOEqE9LxxCtw3IVCkkB802jXQjXsThlROR dNfMcKAzuXq6jsnihGUJUPmc9qozkh5OAO8b7JolEYH7+lvezCqH9DLiFNZsGGkN0tJPH+iihY2oV Xw32sQacK1jcOAqd9KrdVMqgqBu7jJhLxJgL8+HM3uUtmJPNhfDemufd+liVd7VuBJLg8h0mUItW/ ays5ziyhg0MshBp7N1Ohap1RELxJ4s/ma7Ije3mB4MiOdIcaa+lMtjBMMkwK/l7yhQBeqczGuINtl OimX52YkRaFoGLFS2jAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDQz6-003jM8-Va; Tue, 10 Aug 2021 12:35:57 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDQyz-003jJx-8T for linux-arm-kernel@lists.infradead.org; Tue, 10 Aug 2021 12:35:53 +0000 Received: by mail-wr1-x42e.google.com with SMTP id l18so26080609wrv.5 for ; Tue, 10 Aug 2021 05:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cXcVfaJa9gxQfqomI6BeLC46V441BROQ5crN/C0u7tQ=; b=aFsv3vr+XQ6POKdiOCpyItN/s1A3yD15/zjn5UostldN1x0iL5S1t/7EXoUl4mMz8Q 8uowNLbyuG2VkEPcjjwnxbK6tW9BeU8zchx6GlPqOffGl7lbLoMYd2ECnz8EIIuFGAW4 Rjt6Db4jWbDc7edO/2yn9cC82+Y6maFBe7ARMIb6MT9SB32P8lSW/xxLmi6ooVHg1n1R fWj5yHcEtOUtG6Zie4y9ktNsQrvGTNFnDBCFkPxHUKFMLVmRIrHiV6Yn7GSXi+ytpjxw UFqTo3igkPxFx/S9aTva5s6e+RD887u4ahF5QGcNM7fvB5Dfu3sNWWxy584kPwVotjxq cW3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cXcVfaJa9gxQfqomI6BeLC46V441BROQ5crN/C0u7tQ=; b=c4/QID8y4mNih2W72u579gjjfJBVWBPbqQzy3Fb7ZLZg3PaH8qm7KJcY6fILSApC4P CJ4lkrNDrAlZa8sqWlJJkMX3uj7NegtClUy/ZcUhsqzwQ71PDpKqZm3UtyHf1G0FvUqf xsoyGqtCqGP63bQUgfRIjT62sDbJ+ftMvOSdaP6zN4FflLjDfvLafNu9wsz0HVUXGRHC sY26fVYN1NoNpLY1Mhw9FG5ROgu6C43SfML0GIh2TZLG9CqyZ5xRu3gRRnHieEhbBRGA uLOZhMJT5SLsLFc9B9KZ4Gj6EXgZ1rCs6xQCS6S9Z0yCOuyl9GYP+6pdaOLQHJAdCSQN mXxg== X-Gm-Message-State: AOAM530CAQnKC2WKjKICEqO8ynUkqj0mADGDQiE8id5FV+dhrJjIIlEQ kVOEh2M0QNDy7mO8usj2ca9kpw== X-Google-Smtp-Source: ABdhPJyrxhF8E0q6i871koPqo7IgwEwcQPwaC+jYoSQxm92eBV0IEuOY/clY+5owwOhTp0yntrvIQw== X-Received: by 2002:adf:e5cf:: with SMTP id a15mr30538552wrn.362.1628598945798; Tue, 10 Aug 2021 05:35:45 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e920:cedf:a082:9d02]) by smtp.gmail.com with ESMTPSA id 104sm23687271wrc.4.2021.08.10.05.35.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 05:35:45 -0700 (PDT) Date: Tue, 10 Aug 2021 13:35:39 +0100 From: Quentin Perret To: Viresh Kumar Cc: Rafael Wysocki , Vincent Donnefort , lukasz.luba@arm.com, Andy Gross , Bjorn Andersson , Cristian Marussi , Fabio Estevam , Kevin Hilman , Matthias Brugger , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Sudeep Holla , linux-pm@vger.kernel.org, Vincent Guittot , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 0/8] cpufreq: Auto-register with energy model Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_053549_379003_20D4ED0A X-CRM114-Status: GOOD ( 21.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tuesday 10 Aug 2021 at 13:06:47 (+0530), Viresh Kumar wrote: > Provide a cpufreq driver flag so drivers can ask the cpufreq core to register > with the EM core on their behalf. Hmm, that's not quite what this does. This asks the cpufreq core to use *PM_OPP* to register an EM, which I think is kinda wrong to do from there IMO. The decision to use PM_OPP or another mechanism to register an EM belongs to platform specific code (drivers), so it is odd for the PM_OPP registration to have its own cpufreq flag but not the other ways. As mentioned in another thread, the very reason to have PM_EM is to not depend on PM_OPP, so I'm worried about the direction of travel with this series TBH. > This allows us to get rid of duplicated code > in the drivers and fix the unregistration part as well, which none of the > drivers have done until now. This series adds more code than it removes, and the unregistration is not a fix as we don't ever remove the EM tables by design, so not sure either of these points are valid arguments. > This would also make the registration with EM core to happen only after policy > is fully initialized, and the EM core can do other stuff from in there, like > marking frequencies as inefficient (WIP). Though this patchset is useful without > that work being done and should be merged nevertheless. > > This doesn't update scmi cpufreq driver for now as it is a special case and need > to be handled differently. Though we can make it work with this if required. Note that we'll have more 'special cases' if other architectures start using PM_EM, which is what we have been trying to allow since the beginning, so that's worth keeping in mind. Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel