From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA14FC4338F for ; Wed, 11 Aug 2021 06:14:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91F0360724 for ; Wed, 11 Aug 2021 06:14:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 91F0360724 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0SVCVRaJI7fiRmtMrF1sZTgZCVZHhNn+9vHj41fMsgE=; b=L30+siSICY41OS exvC0fRv53VVpWbKjuH6bncC07JuLO0HGR7EB2JL5xdEgtnX9/SspknCQLOqCkrTTsuL6KhwpYHL5 6aYBV301Gwxw+1dsay5h9HO50KiE3SNNS4h8LWbTl7bua20UCmuZemRnto5IxayiS5PaegbvSRJUo J+hIfe7S8PnMFLfJDeBlvCJdzMEA0KA+4HFWe9N5qvfp55bQcvy0tD08QlHXn9dPZlI+fYSDxVaCR bn2WKynTHwre38o9PwTMq150+Rf2FJOuvpJqI3hSPu9M8E+5KKXL6CpchDFT/2DKcSWvkru1PN2hj bcdTz6NeC/0sBIl9kK8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDhTT-005hhD-13; Wed, 11 Aug 2021 06:12:23 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDhTP-005hfr-IF for linux-arm-kernel@lists.infradead.org; Wed, 11 Aug 2021 06:12:20 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 8DE3380CF; Wed, 11 Aug 2021 06:12:37 +0000 (UTC) Date: Wed, 11 Aug 2021 09:12:15 +0300 From: Tony Lindgren To: Pavel Machek Subject: Re: [PATCH] bus: ti-sysc: Fix gpt12 system timer issue with reserved status Message-ID: References: <20210611060224.36769-1-tony@atomide.com> <20210810124006.GA25121@amd> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_231219_693162_AC1A2C3F X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sashal@kernel.org, Nishanth Menon , Grygorii Strashko , Dave Gerlach , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Faiz Abbas , Jarkko Nikula , Keerthy , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Tony Lindgren [210810 12:52]: > * Pavel Machek [210810 12:40]: > > What is going on here? First, we silently ignore errors other than > > EBUSY. Second, sysc_check_active_timer() can't return -EBUSY: it > > returns either 0 or -ENXIO. (I checked 5.10-stable, mainline and > > -next-20210806). > > Thanks for spotting it, looks like there's now a conflict with commit > 65fb73676112 ("bus: ti-sysc: suppress err msg for timers used as > clockevent/source"). It seems we should also check for -ENXIO here > too. And yeah it makes sens to return on other errors for sure. FYI, fix posted at [0] below. Regards, Tony [0] https://lore.kernel.org/linux-omap/20210811061053.32081-1-tony@atomide.com/T/#u _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel