From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F263CC4338F for ; Mon, 16 Aug 2021 05:55:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDD32617E3 for ; Mon, 16 Aug 2021 05:55:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BDD32617E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BQtk0WMJXvqV9p6TWF6Po9m1WMKFYqqEJyFyDSO0cYM=; b=10wkHZ30Qyj1Qs 3fK3U7kviRhL5tDKCzymAORcx23MlBoGvUWwnSV9toY4/Zys6gdSJO+CZihMnKe/h9cXoljjnZ9/E OPocjoCCAB9WoOeCvk2a1Z4xCoWyMlnv4nc7CKa91gWVoEOjDrEAW9afPyXHaKKMq6Oxi1kaCE6B2 hNZbj4B3x3YuerHxxl9pRR3xya4DXzu8gp3xJd3caf7PVZfSIg7DPEBBPLkybhHY1lAO3zP818afS O2KbYGPpQUWyOpkTNenMg/VUYAVHJoM9CY92RYT65l2YeXUrjNeIYxnZBsdtBsLfHaoAI1HQO64f5 mwRtUGRzOB/IkzEsrzIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFVXx-00G9yC-04; Mon, 16 Aug 2021 05:52:29 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFVXr-00G9xX-FI; Mon, 16 Aug 2021 05:52:24 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A884A600CC; Mon, 16 Aug 2021 05:52:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629093142; bh=A6XKGIIAGrCO5lr+EGtJFLRD0uO5DuHaL25253B/0cs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i0ZWxkzqk1lluWmumf696hHuneR81LxxFZwzuz6zcNGNz2uWu8eVpQgTKcpPmZqj5 /AtGznPbKq0lL/ikkV7hit2eI87siYUwoTWUXOXgzNC3OF/WrX1BumfBDpGDVn6T1g xWoPeQNXsSH781LLNcBIR5zGByncT4MSL2m4vtR1Jztv2bFt1sqcGe7ddekuvryAMK fKTXmr7VAVwKt15KAiMkWixahE8wF4NRQrMqP4RZSclYSPUt6WzqU3jwjnnUXwMjlJ pUT7vbAI/rpzvVTmYGoaf4IvoxZtrMDqZNrmwda+Qn1L7e/cy6bmDqiTIfwRmIJ06i 3XiqiOoVCj5Ng== Date: Mon, 16 Aug 2021 08:52:12 +0300 From: Mike Rapoport To: Geert Uytterhoeven Cc: Rob Herring , Russell King , Nicolas Pitre , Ard Biesheuvel , Linus Walleij , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Nick Kossifidis , Paul Walmsley , Palmer Dabbelt , Albert Ou , Frank Rowand , Dave Young , Baoquan He , Vivek Goyal , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, kexec@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/9] MIPS: Avoid future duplicate elf core header reservation Message-ID: References: <92b6718f5618d5469f67b48fbea189cca0c12f4b.1628670468.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <92b6718f5618d5469f67b48fbea189cca0c12f4b.1628670468.git.geert+renesas@glider.be> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210815_225223_571972_61909232 X-CRM114-Status: GOOD ( 20.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, On Wed, Aug 11, 2021 at 10:50:59AM +0200, Geert Uytterhoeven wrote: > Prepare for early_init_fdt_scan_reserved_mem() reserving the memory > occupied by an elf core header described in the device tree. > As arch_mem_init() calls early_init_fdt_scan_reserved_mem() before > mips_reserve_vmcore(), the latter needs to check if the memory has > already been reserved before. Doing memblock_reserve() for the same region is usually fine, did you encounter any issues without this patch? > Note that mips_reserve_vmcore() cannot just be removed, as not all MIPS > systems use DT. > > Signed-off-by: Geert Uytterhoeven > --- > v5: > - New. > --- > arch/mips/kernel/setup.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c > index 23a140327a0bac1b..4693add05743d78b 100644 > --- a/arch/mips/kernel/setup.c > +++ b/arch/mips/kernel/setup.c > @@ -429,7 +429,8 @@ static void __init mips_reserve_vmcore(void) > pr_info("Reserving %ldKB of memory at %ldKB for kdump\n", > (unsigned long)elfcorehdr_size >> 10, (unsigned long)elfcorehdr_addr >> 10); > > - memblock_reserve(elfcorehdr_addr, elfcorehdr_size); > + if (!memblock_is_region_reserved(elfcorehdr_addr, elfcorehdr_size) > + memblock_reserve(elfcorehdr_addr, elfcorehdr_size); > #endif > } > > -- > 2.25.1 > -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel