From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF5CC4338F for ; Wed, 18 Aug 2021 03:47:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 294F260C3E for ; Wed, 18 Aug 2021 03:47:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 294F260C3E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kflA7oWRz5K1Lc+0P7Xl7U2I1PX8fhRyqccgG7OrYL0=; b=tOc4y05viwFyxs MExKBOfCfrtQBMO35WHT5Xx7Ww/kc56CmiCXJ/GG8aVlUd3+WIJ98xdHuS1SCXDqwaO5PeZPSHf4X owrXlTqeBscGxumiPokaqVoOTBSX2jVSjWILpUmxnVP64Z27XMrbSVH3SNMWrqmkE8B2zBAbp+8jY 1URMDTB3615ArjLUutnxkldAHxKOMzYeSoken9iPJY3dq4FtNkZ4KCKQQVddtTq/7hcOWm4cC7P17 xdrWRj8WfFmDKBKnqmO8AZThqR/NfqN8Eo9Fj9wmlNl/26MF7zyx+auf3EKTXYbjC7U2CW2TH66vF RBKg6WY0MR4HzrrIwxdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGCVG-0044Ou-To; Wed, 18 Aug 2021 03:44:35 +0000 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGCVB-0044O2-8F for linux-arm-kernel@lists.infradead.org; Wed, 18 Aug 2021 03:44:33 +0000 Received: by mail-ot1-x335.google.com with SMTP id h63-20020a9d14450000b02904ce97efee36so1111318oth.7 for ; Tue, 17 Aug 2021 20:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dOY/Y+m8CtGs2t22YoW318N2LcUpxV+MpuaJ5LhTgsc=; b=aLy58NDwB5iWg0GHfBe12kmdCiuAYo9opAjTnoggWlFAx23pcpHyAXkeBjVJdVAcI+ y2hLvIe7bGl3c7IbxKwD2jADhSpX2mh7rFTGtMUwEp9fTkcRI17RG7mRzcOB5wZVNk3c Hgy9R3VSP2qotmwK+iPSpLpRRmWWeHRIO/jHIvzIQ9B09uT4Yk+IW/qstqhpAEEc6jBD 0DCz4QZuGFNiPHeyaceIo4Ipn0WxaQ3XnAADSyHNe0ybSxadh2+foMXNVSdp136YJJ/R 9KbpdIMTejZMUN407CjyuCUKCeVJvuG0uA4Xr5l8Mp6VdbGXjqC5gZWFBn48D3EI4rXA 6ekQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dOY/Y+m8CtGs2t22YoW318N2LcUpxV+MpuaJ5LhTgsc=; b=VjJzBZEzejQx6k2lZSp6Ku341lt0UN6gaIBm6OWTuxx2DOAvB2KAwLY/sJM8O075J6 hmHY9QgAffpqpQtlWTzM0nyOFJh7VntcmCiE3WFAN+USxhPO+3/z7UpLs5zF+HL7ZOAm 1H6byMAuSUnohT0iCOvJQTlyofzWqJApELX7auwpKI3tuxH8Lfuvsv4HYGIdrI/cEZhX DNc9oO+v9wTH0wfpvp5mqlFHhi/36y8ONy+zz7Z4gDcs5gYvJtpSkzFuVhtVmh4ItaO1 usgQnDlgEzyAKQo5CkcOHZ0uY5UPaDXLRHw/UcplWJMP8JciiIVsgiOjle8rf6vSokCo Sk3w== X-Gm-Message-State: AOAM530NIcnlN5tjUWTwRcfEDui9uejqQD785W0HFd6Szbb6j47jmk7A CEyUsQz++/9nIBwVmKFEWpubgQ== X-Google-Smtp-Source: ABdhPJwnVYK5fYr39j7qhmd0jRrOO7rMEezuFGQlLvSOJkLU4zHxBqJ5DgiwAELpKicRaga+Gs1gCg== X-Received: by 2002:a9d:649a:: with SMTP id g26mr5174265otl.92.1629258265750; Tue, 17 Aug 2021 20:44:25 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id u126sm835593ooa.23.2021.08.17.20.44.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Aug 2021 20:44:25 -0700 (PDT) Date: Tue, 17 Aug 2021 22:44:23 -0500 From: Bjorn Andersson To: Serge Semin Cc: John Stultz , Serge Semin , Krzysztof Kozlowski , Greg Kroah-Hartman , Rob Herring , Felipe Balbi , Florian Fainelli , Andy Gross , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , Linux USB List , lkml , linux-arm-kernel , Amit Pundir Subject: Re: [PATCH 29/29] arm64: dts: qcom: Harmonize DWC USB3 DT nodes name Message-ID: References: <20210721112531.xvu6ni5ksaehsrjh@mobilestation> <20210722181221.xh3r5kyu7zlcojjx@mobilestation> <20210722220918.l7j6zw3aaa27qato@mobilestation> <20210815194617.sbrkutxzldqbxfat@mobilestation> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210815194617.sbrkutxzldqbxfat@mobilestation> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210817_204429_347195_2612100E X-CRM114-Status: GOOD ( 60.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun 15 Aug 14:46 CDT 2021, Serge Semin wrote: > Hello John > > On Fri, Aug 13, 2021 at 06:06:24PM -0700, John Stultz wrote: > > On Thu, Jul 22, 2021 at 3:09 PM Serge Semin wrote: > > > On Thu, Jul 22, 2021 at 01:09:05PM -0700, John Stultz wrote: > > > > On Thu, Jul 22, 2021 at 12:17 PM Bjorn Andersson > > > > wrote: > > > > > > On Jul 21, 2021, 1:45 PM +0200, Krzysztof Kozlowski wrote: > > > > > > > I had impression that kernel defines interfaces which should be used and > > > > > > > are stable (e.g. syscalls, sysfs and so on). This case is example of > > > > > > > user-space relying on something not being marked as part of ABI. Instead > > > > > > > they found something working for them and now it is being used in "we > > > > > > > cannot break existing systems". Basically, AOSP unilaterally created a > > > > > > > stable ABI and now kernel has to stick to it. > > > > > > > > > > > > > > Really, all normal systems depend on aliases or names and here we have > > > > > > > dependency on device address. I proposed way how AOSP should be fixed. > > > > > > > Anything happened? Nope. > > > > > > > > > > > > First time he sent a possible solution for the problem: > > > > > > https://lore.kernel.org/lkml/20201221210423.GA2504@kozik-lap/ > > > > > > > > > > > > To sum up you could have used one of the more portable approaches > > > > > > 1. add an udc alias to the controller and use it then to refer to the > > > > > > corresponding USB controller > > > > > > > > > > Is there such a thing as "UDC alias"? Or are you suggesting that we > > > > > should add such feature? > > > > > > > > > > I think it would be wonderful if we could identify the UDCs on our > > > > > boards as "USB1" and "USB2", or "the one and only USB-C connector". But > > > > > unless that will fall back to the existing naming it would break John's > > > > > _existing_ userspace. > > > > > > > > > > > Well, I'd not hold up the existing userspace I'm using as sacrosanct > > > > (AOSP devices still usually don't have to work cross-kernel versions - > > > > devboards being the main exception). I'm fine if we can rework > > > > userland as proposed, so that the issues can be avoided, but I > > > > honestly don't have enough context to really understand what that > > > > looks like (no idea what udc aliases are). > > > > > > > > And whatever we do, the main constraint is that userland has to be > > > > able to work with existing LTS kernels and newer kernels. > > > > > > As I said in my response to Bjorn even if it is added to the kernel it > > > won't get to the official LTSes as it would be a new kernel feature. > > > New features aren't normally backported to the older kernels. > > > > > > > > > > > > > 2. search through DT-nodes looking for a specific compatible/reg > > > > > > DT-properties. > > > > > > > > > > > > > > > > We could define that this is the way, but again we didn't yesterday so > > > > > your proposal is not backwards compatible. > > > > > > > > > > > It may be backwards compatible, but I'm still not clear exactly how it > > > > would work. > > > > > > > > I guess if we look through all > > > > sys/bus/platform/devices/*/of_node/compatbile strings for the desired > > > > "snps,dwc3", then find which of the directories have the desired > > > > address in the string? (The suggestion for looking at reg seems > > > > better, but I don't get a char value out of the dwc3 of_node/reg > > > > file). > > > > > > The algorithm is simple: > > > 1) You know what USB controllers you have on your platform. They are > > > supposed to be compatible with snps,dwc3 string and have some pre-defined > > > base address. > > > 2) Find all the files in the directory /sys/class/udc/. > > > 3) Walk through all the directories in /sys/bus/platform/devices/ with > > > names found in 2) and stop on the device with matching compatible/base > > > address defined in 1). > > > > > > In my case the strings could be retrieved like this: > > > USB_NAME_COMPAT=$(/sys/bus/platform/devices/1f100000.usb/of_node/compatible | tr '\0' '\t' | cut -f1) > > > USB_DEVICE_ADDR="$(head -c 4 /sys/bus/platform/devices/1f100000.usb/of_node/reg | hexdump -ve '/1 "%02x"' | sed -e 's/^0*//g')" > > > > > > > Hey Serge, > > I just wanted to follow up here. Amit has reworked the db845c AOSP > > userland so that it no longer uses the fixed node name, but instead > > probes for it: > > https://android-review.googlesource.com/c/device/linaro/dragonboard/+/1774872 > > > > Admittedly, it does take a short-cut. As your algorithm above, > > digging up the devices and finding the sys/bus path to read the reg > > value and pipe through hexdump (which android doesn't have) seemed > > overly obtuse when the address is in the node name itself (while the > > only way to be sure, one normally doesn't use spectroscopy to > > determine the value of a coin when you can read what's printed on it > > :). But, should the node naming be further changed at least the > > infrastructure we have can be reworked fairly easily to adapt now. > > > > In any case, as we can handle the name change now, if you want to > > resubmit your patch, we would no longer object (but can't promise no > > one else might be bitten). Sorry for the delay this caused, and we > > appreciate you working with us to find a solution. > > Great! Thanks for sending the notification. I'll resend the patch with a > reference to your report and to the update made to AOSP, as soon as I > am done with my current task. > Amit's change makes future versions of AOSP able to cope with changes in the UDC name, unfortunately it doesn't change the fact that renaming the node breaks compatibility in non-Android user space (or any existing branches/tags of AOSP). Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel