From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2536C4338F for ; Fri, 20 Aug 2021 20:04:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B0D26113B for ; Fri, 20 Aug 2021 20:04:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6B0D26113B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T03aSaR1yK6gymjxjm7HHkATGJPLf2TaM3GzW4ax/Bw=; b=pOLD4K/VPYVEBt DlTZ4239+VSrWq3EuuzTFjDTXvcF3mvVU1/qHZeUdrt9XHl2CLUBNleufGYTkLmuxCnLAx/3H3q26 KT2z/YJekOtYPuABwgTugl+lN2AVUX5i8cYmbTybr6uwVau6QF9KiIZsV6HnvikdwrNLi0gKFPIli BNJ2UpnO11DzKQkwyO1faj4G3Ao+z26+ukR2ZdE0GxJpEbQcUC7vV4ErVDfoIYGohtr6vqnzyJFez pDqg+7a+WUbLDNbgLuehudfvs9DWRwwSG67V+iOWxrBG6vm/3PfT0jFIuqjO9w+TgG1CtmhJJoLij YGRpcVC2YEt0GK4XB7Rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHAiK-00C1UP-NN; Fri, 20 Aug 2021 20:02:04 +0000 Received: from mail-oo1-f41.google.com ([209.85.161.41]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHAiE-00C1Tg-FZ for linux-arm-kernel@lists.infradead.org; Fri, 20 Aug 2021 20:02:02 +0000 Received: by mail-oo1-f41.google.com with SMTP id s21-20020a4ae495000000b0028e499b5921so486009oov.12 for ; Fri, 20 Aug 2021 13:01:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wlbFPYPY/Xtj1KW5rp0UccGo9s5jQlV0fCqX0LEM8rA=; b=D0Cla/mkzc95hFXKtqwlrD2eC6UIZhbklDGZ4GxibutxXUv4Jtv8Br89xax9AB83Is ktJH6xtq0PKCyHJqgHz+WeHMbMANUMDCHkQOPC7uuviC41GMg6V16c0kcm0YFQ2uAhJq Ux0h++SgvLey0YxcTL7g7lbZc3teMgP+YbohqOqk+we6hvBFr0ocFKFZQdp3C8Xjq7F+ WnXeR5SssK+XVVtV7WFa4R+7X99tge3ED5pEFW3VeuSbVnPgqanP+aCL4vp/mF2fl7pl YrOa1eVp67yWkEx3kQPuzRI4NHSoHIkjSOXb04PGxQLaUZUfl4JbD1sQ7lhCExLanqVo iIvA== X-Gm-Message-State: AOAM532yL8Rnkg5DuY5+MXRDel9l96A1m1+D23QrH+hnIZqcgNVl5GFe JVsm5QSWIv4WtrcWDeoa2qzfufINfQ== X-Google-Smtp-Source: ABdhPJys2nyF9UYQYqZJu3h13pyM0x7e7+IP1RxgPq7sPk58kOG6bqF1k5cdEbYjpsmGblW/KXee2Q== X-Received: by 2002:a4a:bc90:: with SMTP id m16mr17240148oop.33.1629489717171; Fri, 20 Aug 2021 13:01:57 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id w15sm1385177oiw.19.2021.08.20.13.01.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Aug 2021 13:01:56 -0700 (PDT) Received: (nullmailer pid 3886974 invoked by uid 1000); Fri, 20 Aug 2021 20:01:55 -0000 Date: Fri, 20 Aug 2021 15:01:55 -0500 From: Rob Herring To: Chia-Wei Wang Cc: joel@jms.id.au, andrew@aj.id.au, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ryan_chen@aspeedtech.com Subject: Re: [PATCH v2 1/5] dt-bindings: aspeed: Add eSPI controller Message-ID: References: <20210819080040.31242-1-chiawei_wang@aspeedtech.com> <20210819080040.31242-2-chiawei_wang@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210819080040.31242-2-chiawei_wang@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210820_130158_570979_8974F5A8 X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 19, 2021 at 04:00:36PM +0800, Chia-Wei Wang wrote: > Add dt-bindings for Aspeed eSPI controller > > Signed-off-by: Chia-Wei Wang > --- > .../devicetree/bindings/soc/aspeed/espi.yaml | 158 ++++++++++++++++++ > 1 file changed, 158 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/aspeed/espi.yaml > > diff --git a/Documentation/devicetree/bindings/soc/aspeed/espi.yaml b/Documentation/devicetree/bindings/soc/aspeed/espi.yaml > new file mode 100644 > index 000000000000..fec3d37f3ffd > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/aspeed/espi.yaml > @@ -0,0 +1,158 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# # Copyright (c) 2021 Aspeed Technology Inc. > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/aspeed/espi.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Aspeed eSPI Controller > + > +maintainers: > + - Chia-Wei Wang > + - Ryan Chen > + > +description: > + Aspeed eSPI controller implements a slave side eSPI endpoint device > + supporting the four eSPI channels, namely peripheral, virtual wire, > + out-of-band, and flash. > + > +properties: > + compatible: > + items: > + - enum: > + - aspeed,ast2500-espi > + - aspeed,ast2600-espi > + - const: simple-mfd > + - const: syscon Is this really 2 sub devices that could be used individually or in a different combination? If not, then I'd make all this 1 node. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel