From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95C13C4338F for ; Sat, 21 Aug 2021 10:54:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50E566120C for ; Sat, 21 Aug 2021 10:54:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 50E566120C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xUzCnyRcM6Ub71Vw5el3VUfR2OODwYpC8I7ZWHHCEV4=; b=WUhgzrk6e4Jkl36835tiI0VNG2 ekEpVm76RybZM/Y9fDez1wFKOAn9MD5XM4+pzK6PW6Bag6IBsVSouZ8BBXZ1RU3LCkfvE/PJ70QYB mSR4opCdIzc2CGEGEdQnYI2EDZCSsqoU7o5IP0aA9hYEUu8QuA4wQt7M1SEWdiObgw0cTueHBUs+H iQw+KLu0i9FnSo14hvVSMRuvAkP3r3rFcnpgEqDufvZXdQ2RIULFVMAYOTk5oohtNpN52Mf9F3Rkk mY2gRjCZZdNeWR0o1gYUnSkuYBHPtyuo36hb2e5r+bACU6Vj3hL56C/NmdriAWCe62XVBdHU+BS+G WEwrcigw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHOcD-00CipZ-Ut; Sat, 21 Aug 2021 10:52:42 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHOcA-00CipD-4R for linux-arm-kernel@lists.infradead.org; Sat, 21 Aug 2021 10:52:40 +0000 Received: by mail-pg1-x535.google.com with SMTP id t1so11802833pgv.3 for ; Sat, 21 Aug 2021 03:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7GHZ71vn1IOyEe5RXN4R0wAt4wO6jCQIg+NGEUM1G7w=; b=E77GypFj7f0d6klY5ylnID+eWbmqIPQxTnRVeVE4YvqcbIa6kRk+AjA6qoJk6HL6fV Hm5RNXXE6JYNRLCtkAM4jL6KHsPLU8zvZKrKDL+KQI8mLnTn8KE3P+nK6GkDhOA3Q29k GhxcruQtC246xFx7P8sfiQ6SzJvnqVYKDWAYM4DkkYtmTC0217zSA5lSZa/zM/8dxTxz 8XPDcxtevNOq4LNMoY91V0hUz7MFLXSg6O2EnrKBSXVy8T8ushel5tgWQNr/E+nCjQDV EWm+V6BOo5NGC1dPEKmuKEGVUu93UfyT2mKpGu6TV5+Rw9E1HO7eo3cXffsy6QbFLtOs hHUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7GHZ71vn1IOyEe5RXN4R0wAt4wO6jCQIg+NGEUM1G7w=; b=LeS2gpVIpv6gMqO8TGp1J+g0s3baWql0sD9ncwx58qL+5Lu4qNeTA7PUMwZ23BVTRr COXa7HW49cj5xnKgsRExA2LJTf4EIrq6gjd8sr0SF3n3tGXDoJu/5H6rC8tvFrkLk10s IWOnYf9FKOJS8JvZodA7tAGqd1Orvy0nqlkR4Ya0/F8zELjK5OpGksGjj+sL4rIrVEAt w0MPj7pW67bdI27Pituw0dUqY7/UxCCT47nbsOxboWNwKHqIuCnpJi3gkUXZNnN/r6BG 04RJ0z0WNr2u+0oD3ufTNzhjUw5FBXMRISn4BfrQd5lGHv5K2m8S5PisDg6HcqaloXwZ C2yg== X-Gm-Message-State: AOAM533xi/jo8P+lTfDNK4Cbsbq8ShfqI+J8HVCfE3CO1S3aZ7wncdJf rOaYxj44GRy+BsO8z6asRC0= X-Google-Smtp-Source: ABdhPJwU1O/fyQ1CgvrQNT+/7EUp2HR/Zk2LYQNY8wRyENOHx6pzwRrzfuDSMopQdhJywkaK95asLQ== X-Received: by 2002:aa7:9e5d:0:b029:3e0:46a2:1dea with SMTP id z29-20020aa79e5d0000b02903e046a21deamr23891279pfq.77.1629543155036; Sat, 21 Aug 2021 03:52:35 -0700 (PDT) Received: from shinobu ([156.146.35.76]) by smtp.gmail.com with ESMTPSA id y4sm8740382pjw.57.2021.08.21.03.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Aug 2021 03:52:34 -0700 (PDT) Date: Sat, 21 Aug 2021 19:52:27 +0900 From: William Breathitt Gray To: Jonathan Cameron Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com Subject: Re: [PATCH v15 07/13] docs: counter: Document character device interface Message-ID: References: <20210815175102.4a10a28f@jic23-huawei> MIME-Version: 1.0 In-Reply-To: <20210815175102.4a10a28f@jic23-huawei> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210821_035238_247478_3C532FBE X-CRM114-Status: GOOD ( 24.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1025722683577153637==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1025722683577153637== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FonV+Z3EdOcq0SvO" Content-Disposition: inline --FonV+Z3EdOcq0SvO Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 15, 2021 at 05:51:02PM +0100, Jonathan Cameron wrote: > On Mon, 9 Aug 2021 21:37:32 +0900 > William Breathitt Gray wrote: >=20 > > This patch adds high-level documentation about the Counter subsystem > > character device interface. > >=20 > > Signed-off-by: William Breathitt Gray >=20 > Hi William, >=20 > Trivial probable typo inline. >=20 > I'm struggling somewhat with these interfaces because I simply don't know > enough about how people use counters to know whether they provide everyth= ing > people will want. They feel similar to the event handling type functions = you > can set up in motor drives, so they may well make sense, but ideally > we need review from someone (other than yourself!) who actually uses this > stuff on a regular basis. >=20 > If we don't get any additional review I guess we go ahead anyway > next cycle. >=20 > Jonathan >=20 > > --- >=20 > > + > > +Counter events can be configured by users to report various Counter > > +data of interest. This can be conceptualized as a list of Counter > > +component read calls to perform. For example: > > + > > + +-------------------------------------------------+ > > + | COUNTER_EVENT_OVERFLOW | COUNTER_EVENT_INDEX | > > + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D+ > > + | Channel 0 | Channel 0 | > > + +------------------------+------------------------+ > > + | * Count 0 | * Signal 0 | > > + | * Count 1 | * Signal 0 Extension 0 | > > + | * Signal 3 | * Extension 4 | > > + | * Count 4 Extension 2 +------------------------+ > > + | * Signal 5 Extension 0 | Channel 1 | > > + | +------------------------+ > > + | | * Signal 4 | > > + | | * Signal 4 Extension 0 | > > + | | * Count 7 | > > + +------------------------+------------------------+ > > + > > +When ``counter_push_event(counter, COUNTER_EVENT_INDEX, 1)`` is called > > +for example, it will go down the list for the ``COUNTER_EVENT_INDEX`` > > +event channel 1 and execute the read callbacks for Signal 4, Signal 4 > > +Extension 0, and Count 4 -- the data returned for each is pushed to a >=20 > Count 7? Looks like my finger slipped on my numpad and hit 4 when I intended 7. I'll fix this for v16, thanks. William Breathitt Gray --FonV+Z3EdOcq0SvO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmEg2usACgkQhvpINdm7 VJLlrBAA5ef/1u/fl55aa7bo8Y2TRZq13h+0JMoMFw+JkZff7ubiQ0NaVAfOZNQN zG9PNIwOsfw0dhWrWhPgyyQDtXewP27ISLqBjKvlXStIT6gaE/RL1IqAdR2b7PXn oK1LOh89aAWmD6fWX4qB/NABJ0gUnrHi7AfWU9TKfbCyYfCt6GCCvXovaol0OVLY 9/ZZo6vgE0leqpkIYDEWUEUdVMz48GNEWlKHfRE3ajwyHVXkUKoIAVvzP+Bdo7ON Cwu3GdFpSGzG/f6tvOlQN3+HTyiO8F5TOe954tCCpSY27N2GLBgF3s93mFJtmYmy sAdtyEgEj6GhWF12gQKcnvcVt08uC1eSbg1Gh7ZUiZ9F3v4cyLUqHhTFPtxM+PyH flghDGTfyHgcBD3Zt66cVBJvN1v29hQVc4/Q+x7q4YDXYk5c5LKBUNThfdVsAR+x 475bGsvth6Uq4qzOdOPfdMh8+IHJ3x6JygmxvyGdWiDaBGWk5XrgilEkVUdsf4NR cFvlEv7ElzQpNjsm3atDkSTYKw29QiTZzAihXPbB1WXMbGEA2B5n6wuPUFF5tgrR 0nFVsG84EleG+u/KwZkIMWhlRpEl8e1OiJETtlObjMvwybwNn5JLlnsFvTWnsVq6 4j4EBNsdllCs2NPTQVa5eJRXa7WsChfEYegahqRQCB0fqNQnGVg= =glsn -----END PGP SIGNATURE----- --FonV+Z3EdOcq0SvO-- --===============1025722683577153637== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1025722683577153637==--