From: Rob Herring <robh@kernel.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Andy Gross" <agross@kernel.org>,
"Balaji Prakash J" <bjagadee@codeaurora.org>,
linux-pwm@vger.kernel.org,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Robert Marko" <robert.marko@sartura.hr>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Kathiravan T" <kathirav@codeaurora.org>,
"Lee Jones" <lee.jones@linaro.org>
Subject: Re: [PATCH v7 3/4] dt-bindings: pwm: add IPQ6018 binding
Date: Wed, 25 Aug 2021 11:12:47 -0500 [thread overview]
Message-ID: <YSZr/xo2a60PYTuW@robh.at.kernel.org> (raw)
In-Reply-To: <87ilzta5xn.fsf@tarshish>
On Wed, Aug 25, 2021 at 05:59:45PM +0300, Baruch Siach wrote:
> Hi Rob,
>
> On Wed, Aug 25 2021, Rob Herring wrote:
>
> > On Wed, 25 Aug 2021 12:48:26 +0300, Baruch Siach wrote:
> >> DT binding for the PWM block in Qualcomm IPQ6018 SoC.
> >>
> >> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> >> ---
> >> v7:
> >>
> >> Use 'reg' instead of 'offset' (Rob)
> >>
> >> Drop 'clock-names' and 'assigned-clock*' (Bjorn)
> >>
> >> Use single cell address/size in example node (Bjorn)
> >>
> >> Move '#pwm-cells' lower in example node (Bjorn)
> >>
> >> List 'reg' as required
> >>
> >> v6:
> >>
> >> Device node is child of TCSR; remove phandle (Rob Herring)
> >>
> >> Add assigned-clocks/assigned-clock-rates (Uwe Kleine-König)
> >>
> >> v5: Use qcom,pwm-regs for phandle instead of direct regs (Bjorn
> >> Andersson, Kathiravan T)
> >>
> >> v4: Update the binding example node as well (Rob Herring's bot)
> >>
> >> v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring)
> >>
> >> v2: Make #pwm-cells const (Rob Herring)
> >> ---
> >> .../devicetree/bindings/pwm/ipq-pwm.yaml | 52 +++++++++++++++++++
> >> 1 file changed, 52 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/pwm/ipq-pwm.yaml
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/pwm/ipq-pwm.example.dt.yaml:0:0:
> > /example-0/syscon@1937000: failed to match any schema with compatible:
> > ['qcom,tcsr-ipq6018', 'syscon', 'simple-mfd']
>
> What can I do about that? Is it because qcom,tcsr-ipq6018 is documented
> in a non-yaml plain .txt file?
No, it is not documented at all.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-25 16:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 9:48 [PATCH v7 1/4] dt-bindings: mfd: qcom, tcsr: document ipq6018 compatible Baruch Siach
2021-08-25 9:48 ` [PATCH v7 2/4] pwm: driver for qualcomm ipq6018 pwm block Baruch Siach
2021-08-25 9:48 ` [PATCH v7 3/4] dt-bindings: pwm: add IPQ6018 binding Baruch Siach
2021-08-25 14:10 ` Rob Herring
2021-08-25 14:59 ` Baruch Siach
2021-08-25 16:12 ` Rob Herring [this message]
2021-08-25 16:18 ` Rob Herring
2021-08-25 15:45 ` Rob Herring
2021-08-25 9:48 ` [PATCH v7 4/4] arm64: dts: ipq6018: add pwm node Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSZr/xo2a60PYTuW@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=baruch@tkos.co.il \
--cc=bjagadee@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kathirav@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).