From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 349EDC432BE for ; Fri, 27 Aug 2021 02:01:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02EE260524 for ; Fri, 27 Aug 2021 02:01:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 02EE260524 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iYjIOVrLcLraoDdh+saE9oWHc9+M21zJ2DStXCC5AM4=; b=3BX0AFihzuiE3o pKuhch1jlwYetgtZh6O16llAdOrwJK2W4gaiPFyoBJwsP9mKQMkmMFMpY5vTc41vHc3+DUNdZxDrY 0S1PAoW4y8gGPBmXCWgHnB1sTO+DPrZUhLCOelG5KNsele3u09HGBdvCaEHV+sFrYuUIMvCEd+//k YAk5psEKqROhpt2HByZsBh+GfVYR6iMKjHr9O2Ll4OpARS+U6sVDqZP2TgvXriS6LtBX7OgdcPzFf IwK9I+0QiVokhmwuSNXGar0/NjkjUza/k1ji9jAK8HMNV//Z7qTY1fZITBpyJHGmTNk6hAwNizQe2 OSC3CW0tH5YppcWt8ifA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJR8Z-00BKwd-3N; Fri, 27 Aug 2021 01:58:31 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJR8S-00BKv0-MW for linux-arm-kernel@lists.infradead.org; Fri, 27 Aug 2021 01:58:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=4lIne5FHlydWaN5UNR7D7DuxGZeLkCmilmM1YEyzkHc=; b=ezyVcrjDrkRWKg0PX0HxoXV32g gTFQuWv1ugtYv7/sjr58dmaWOnmyEwhLd45JnHjyyUoOLB58EMlhmW8f1rKg+cjwDIktoL/MhqhyP HeoMFd1WK4fmu8iHF+/l8+Bq9zaa7bJCD92s6DvF5Wg8Tta14kyPPm3LIaGeTodrP/kw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mJR86-0042Z5-Sq; Fri, 27 Aug 2021 03:58:02 +0200 Date: Fri, 27 Aug 2021 03:58:02 +0200 From: Andrew Lunn To: Wong Vee Khee Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , Vladimir Oltean , Vivien Didelot , Florian Fainelli , Russell King , Heiner Kallweit , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Vladimir Oltean , Voon Weifeng , Michael Sit Wei Hong Subject: Re: [PATCH net-next v2 1/2] net: pcs: xpcs: enable skip xPCS soft reset Message-ID: References: <20210826235134.4051310-1-vee.khee.wong@linux.intel.com> <20210826235134.4051310-2-vee.khee.wong@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210826235134.4051310-2-vee.khee.wong@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210826_185824_783794_E50AB06F X-CRM114-Status: GOOD ( 13.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 27, 2021 at 07:51:33AM +0800, Wong Vee Khee wrote: > Unlike any other platforms, Intel AlderLake-S uses Synopsys SerDes where > all the SerDes PLL configurations are controlled by the xPCS at the BIOS > level. If the driver perform a xPCS soft reset on initialization, these > settings will be switched back to the power on reset values. > > This patch introduced a new xpcs_reset() function for drivers such as > sja1105 and stmmac to decide whether or not to perform a xPCS soft > reset. > > + /* If Device ID are all ones, there is no device found */ > + if (xpcs_id == 0xffffffff) > + goto out; > + This does not look like plain refactoring. It is not code moved from somewhere else. At minimum, it needs explaining in the commit message, but it probably should be a commit of its own. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel