From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02343C433F5 for ; Tue, 7 Sep 2021 16:48:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF6C861090 for ; Tue, 7 Sep 2021 16:48:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF6C861090 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cgqGSbeT/BUHFUIeu3vtmUcxx2tkLGZZ4WyWDeTsL0U=; b=L6x46rAjewBrp4 Z8s+AmSlvlsBma/rZIDcGf8E3iVHl4SeKIJG/9LjYP7+36UenAwBNUISVehL6Uhf8PGVKFTAlmKSi RLPf/Qe0y7FeQDnd6sxSqXTp4AduP7Sk9zORtEHpunyOh/S9ZDijqgLRSISLK9sk1FphgECsRDVv4 /B3mWzka5GkPtzwD5boxkYsOc+8sPv5cp/t3oWVSSCnbqzF85ZDQEdux7KrRFZa6wQc6uut0lQRP0 1Y/zCf8eS55crWWAN+f1QOaqPBnRpjcgiCnQyfDk4py0WkK2N3SnDnJNtsZ3jCnNFn8+QLX7uBWmg 77sQx6vmMJ0greJsb6zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNeEf-004FRx-Rk; Tue, 07 Sep 2021 16:46:14 +0000 Received: from mail-oi1-f175.google.com ([209.85.167.175]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNeEc-004FRC-D5 for linux-arm-kernel@lists.infradead.org; Tue, 07 Sep 2021 16:46:12 +0000 Received: by mail-oi1-f175.google.com with SMTP id bi4so13514053oib.9 for ; Tue, 07 Sep 2021 09:46:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DCZNN4p5E8kdrXSmi6bXMnp7xKFnaiWBCB0tHa5A5OA=; b=L3nB+Rnkzlg1Ki2AUvd24/JBMFOa7RyE+E9W+PDtPXbaxp3ZBNe2qz7WhzZuN43beS JuYBDeNajZLNQGTtHE7IxL4BQfgnvCiDYlp+aFJobu468yzHnNTcK5s5CFvwujWWgk7J BJeRAd7PL3Caelj/Lp+kGRYFyFjCYkOL1dQD29OlTolyQgTHFbhhVsT0wi2HB7hG8Isd ZNgccgdlWvzDFPt45NZGRPSjvLnp3rFGRIO7sHgheSXo1ktndNThdNEueJB2OBSSUwX6 Yy+5XKgymoCRfVBGR28LmK0T31BKF3TLiPNXaunqzkPujdQmmWlxyuJhEk7bWhTVQPyW 0ZfA== X-Gm-Message-State: AOAM530SrEmEKS6vnMDMXZ3W9oQXqVlpFTeHvZtsJKVMhBzq7AktJY08 Jaq+oNigfSB+ZNVgsksODQ== X-Google-Smtp-Source: ABdhPJyEWZxNDh9WKG25RoeCwev0Ca107OKI1Rf+mUhA3Dl4aN8TzcDh+oMu6TG6+aso5kQpCnX2YA== X-Received: by 2002:a05:6808:13d3:: with SMTP id d19mr3506601oiw.178.1631033166614; Tue, 07 Sep 2021 09:46:06 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id x4sm2327260ood.2.2021.09.07.09.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 09:46:05 -0700 (PDT) Received: (nullmailer pid 4134391 invoked by uid 1000); Tue, 07 Sep 2021 16:46:04 -0000 Date: Tue, 7 Sep 2021 11:46:04 -0500 From: Rob Herring To: Cai Huoqing Cc: Jonathan Cameron , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] dt-bindings: iio: adc: Add the binding documentation for NXP IMX8QXP ADC Message-ID: References: <20210907015724.1377-1-caihuoqing@baidu.com> <20210907015724.1377-3-caihuoqing@baidu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210907015724.1377-3-caihuoqing@baidu.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_094610_495284_1AD958BA X-CRM114-Status: GOOD ( 21.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 07, 2021 at 09:57:22AM +0800, Cai Huoqing wrote: > The NXP i.MX 8QuadXPlus SOC has a new ADC IP, so add the binding > documentation for NXP IMX8QXP ADC. > > Signed-off-by: Cai Huoqing > --- > v1->v2: *Fix some indentation issues. > *Mark status as okay. > *Change clock2 source. > v1 link: > https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210830172140.414-5-caihuoqing@baidu.com/ > > .../bindings/iio/adc/nxp,imx8qxp-adc.yaml | 85 +++++++++++++++++++ > 1 file changed, 85 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > new file mode 100644 > index 000000000000..77501898a563 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > @@ -0,0 +1,85 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/nxp,imx8qxp-adc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP IMX8QXP ADC bindings > + > +maintainers: > + - Cai Huoqing > + > +description: > + Supports the ADC found on the IMX8QXP SoC. > + > +properties: > + compatible: > + const: nxp,imx8qxp-adc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: per > + - const: ipg > + > + assigned-clocks: > + maxItems: 1 > + > + assigned-clocks-rate: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + status: > + const: disable ??? You don't need 'status' in bindings. Plus this would cause 'status = "okay"' to cause an error in your dts files. > + > + "#io-channel-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupts-parent It is valid for interrupt-parent to be in a parent node, so it is never required. > + - clocks > + - clock-names > + - assigned-clocks > + - assigned-clock-rates > + - power-domains > + - state Not documented. > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + soc { > + #address-cells = <1>; > + #size-cells = <1>; > + adc@5a880000 { > + compatible = "nxp,imx8qxp-adc"; > + reg = <0x0 0x5a880000 0x0 0x10000>; > + interrupts = ; > + clocks = <&clk IMX_SC_R_ADC_0>, > + <&clk IMX_SC_R_ADC_0>; > + clock-names = "per", "ipg"; > + assigned-clocks = <&clk IMX_SC_R_ADC_0>; > + assigned-clock-rates = <24000000>; > + power-domains = <&pd IMX_SC_R_ADC_0>; > + status = "okay"; Remove status from examples. > + #io-channel-cells = <1>; > + }; > + }; > +... > -- > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel