From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B389C433EF for ; Thu, 9 Sep 2021 11:22:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BE5B61100 for ; Thu, 9 Sep 2021 11:22:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0BE5B61100 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S+A9U88BwbpimBlQAlD127cusEhdqiGH8L3Uhw/wm0o=; b=nFR2TNJZhMVG9T CeHj0Swn/GTtMkrFqF3+iDaMwinCmHw0/4Mnie9Qmya+hn+n4K5EI3m/iHhK4616jObLCj3CDh0FL 4imTyjH394VUZI7YqYrgLh622fzKoeTeAdoRWRU6KbsDcNyEK/EIu0BLeXa9cISlgRhaAfq2qvix4 gvZAljYkd+NGkI37PKn8Ttl1/WCddfFEn0/qtgFj/GrokQLzx67Vw3GlVtw/c3lT60PP9SU39rfO+ 4VZaYXaip90WxZtoyd8WPS1rjT/bL9nComqUIGOm5Vveagwpv893wDmcYCa5uJBnc3GaxwUjR0LmD pVJpaYHgERRvn5HQAgHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOI6p-0091e0-Le; Thu, 09 Sep 2021 11:20:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOI6l-0091dE-HS for linux-arm-kernel@lists.infradead.org; Thu, 09 Sep 2021 11:20:46 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id CAF4C61100; Thu, 9 Sep 2021 11:20:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631186442; bh=zOSter71YOfYsm8XJFjTGezqiWicv0G3Ba/q9VBktSc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VRIaV9WaDODAWGPg3ZhUr44BmZCIooex5ioxhbl8KRsU1mVb6znLP45+dd0hwsEre zSl8PWfHQj4817XumOjGpIrTa7pvtbXrOPQx+Qvqmuoz3G6cOcXIV1jvPgJWcoVHHg 6vmB0zyayS4CevNB5G0i0bR636yHSSDUlYDoKI9U= Date: Thu, 9 Sep 2021 13:20:34 +0200 From: Greg Kroah-Hartman To: Neal Liu Cc: Alan Stern , Tony Prisk , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Tao Ren , BMC-SW Subject: Re: [PATCH v3] usb: ehci: handshake CMD_RUN instead of STS_HALT Message-ID: References: <20210909063652.17282-1-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210909_042043_662565_0C04CC2E X-CRM114-Status: GOOD ( 46.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 09, 2021 at 11:13:15AM +0000, Neal Liu wrote: > > -----Original Message----- > > From: Greg Kroah-Hartman > > Sent: Thursday, September 9, 2021 2:38 PM > > To: Neal Liu > > Cc: Alan Stern ; Tony Prisk > > ; linux-usb@vger.kernel.org; > > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Tao Ren > > ; BMC-SW > > Subject: Re: [PATCH v3] usb: ehci: handshake CMD_RUN instead of STS_HALT > > > > On Thu, Sep 09, 2021 at 02:36:52PM +0800, Neal Liu wrote: > > Fix STS_HALT handshake failure for Aspeed 2500/2600 platform. > > Change since v2: > - Use my "real" name for both the Signed-off-by: line and the From: line. > > Change since v1: > - Handshake CMD_RUN status on startup instead of easily skip it. > > --- > > > For Aspeed, HCHalted status depends on not only Run/Stop but also > > > ASS/PSS status. > > > Handshake CMD_RUN on startup instead. > > > > > > Signed-off-by: Neal Liu > > > Acked-by: Alan Stern > > > Reviewed-by: Tao Ren > > > Tested-by: Tao Ren > > > > > > --- > > > drivers/usb/host/ehci-hcd.c | 11 ++++++++++- > > > drivers/usb/host/ehci-platform.c | 6 ++++++ > > > drivers/usb/host/ehci.h | 1 + > > > 3 files changed, 17 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > > > index 10b0365f3439..01c022e46aa2 100644 > > > --- a/drivers/usb/host/ehci-hcd.c > > > +++ b/drivers/usb/host/ehci-hcd.c > > > @@ -634,7 +634,16 @@ static int ehci_run (struct usb_hcd *hcd) > > > /* Wait until HC become operational */ > > > ehci_readl(ehci, &ehci->regs->command); /* unblock posted writes */ > > > msleep(5); > > > - rc = ehci_handshake(ehci, &ehci->regs->status, STS_HALT, 0, 100 * 1000); > > > + > > > + /* For Aspeed, STS_HALT also depends on ASS/PSS status. > > > + * Skip this check on startup. > > > + */ > > > + if (ehci->is_aspeed) > > > + rc = ehci_handshake(ehci, &ehci->regs->command, CMD_RUN, > > > + 1, 100 * 1000); > > > + else > > > + rc = ehci_handshake(ehci, &ehci->regs->status, STS_HALT, > > > + 0, 100 * 1000); > > > > > > up_write(&ehci_cf_port_reset_rwsem); > > > > > > diff --git a/drivers/usb/host/ehci-platform.c > > > b/drivers/usb/host/ehci-platform.c > > > index c70f2d0b4aaf..c3dc906274d9 100644 > > > --- a/drivers/usb/host/ehci-platform.c > > > +++ b/drivers/usb/host/ehci-platform.c > > > @@ -297,6 +297,12 @@ static int ehci_platform_probe(struct > > platform_device *dev) > > > "has-transaction-translator")) > > > hcd->has_tt = 1; > > > > > > + if (of_device_is_compatible(dev->dev.of_node, > > > + "aspeed,ast2500-ehci") || > > > + of_device_is_compatible(dev->dev.of_node, > > > + "aspeed,ast2600-ehci")) > > > + ehci->is_aspeed = 1; > > > + > > > if (soc_device_match(quirk_poll_match)) > > > priv->quirk_poll = true; > > > > > > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h index > > > 80bb823aa9fe..fdd073cc053b 100644 > > > --- a/drivers/usb/host/ehci.h > > > +++ b/drivers/usb/host/ehci.h > > > @@ -219,6 +219,7 @@ struct ehci_hcd { /* one per controller */ > > > unsigned need_oc_pp_cycle:1; /* MPC834X port power */ > > > unsigned imx28_write_fix:1; /* For Freescale i.MX28 */ > > > unsigned spurious_oc:1; > > > + unsigned is_aspeed:1; > > > > > > /* required for usb32 quirk */ > > > #define OHCI_CTRL_HCFS (3 << 6) > > > -- > > > 2.17.1 > > > > > > > Hi, > > > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him > > a patch that has triggered this response. He used to manually respond > > to these common problems, but in order to save his sanity (he kept > > writing the same thing over and over, yet to different people), I was > > created. Hopefully you will not take offence and will fix the problem > > in your patch and resubmit it so that it can be accepted into the Linux > > kernel tree. > > > > You are receiving this message because of the following common error(s) > > as indicated below: > > > > - You did not specify a description of why the patch is needed, or > > possibly, any description at all, in the email body. Please read the > > section entitled "The canonical patch format" in the kernel file, > > Documentation/SubmittingPatches for what is needed in order to > > properly describe the change. > > > > - This looks like a new version of a previously submitted patch, but you > > did not list below the --- line any changes from the previous version. > > Please read the section entitled "The canonical patch format" in the > > kernel file, Documentation/SubmittingPatches for what needs to be done > > here to properly describe this. > > > > If you wish to discuss this problem further, or you have questions about > > how to resolve this issue, please feel free to respond to this email and > > Greg will reply once he has dug out from the pending patches received > > from other developers. > > > > thanks, > > > > greg k-h's patch email bot > > Do you prefer fixing canonical patch format inline or sending new patch v4? > I added more description and the changes from previous version. v4 please. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel