Re: [PATCH 19/22] soc: sunxi: mbus: Add A31 ISP compatibles to the list

Paul Kocialkowski
2021-09-13T07:47:56Z

[-- Attachment #1.1: Type: text/plain, Size: 1920 bytes --]

Hi Samuel,

On Fri 10 Sep 21, 21:36, Samuel Holland wrote:
> On 9/10/21 1:41 PM, Paul Kocialkowski wrote:
> > The A31 ISP sits on the mbus and requires the usual bus address
> > adaptation. Add its compatibles to the list.
>
> My understanding is that this driver only exists to work around old DT
> bindings where the interconnects/interconnect-names = "dma-mem"
> properties are not required (and so they are historically missing from
> the device trees).
>
> For new bindings, it would be better to use those properties and not add
> to this list.

Oh okay, I didn't really look into it and just did the same thing that was
done for the CSI controller. Thanks for the heads up!

Paul

> Regards,
> Samuel
>
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > ---
> > drivers/soc/sunxi/sunxi_mbus.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/soc/sunxi/sunxi_mbus.c b/drivers/soc/sunxi/sunxi_mbus.c
> > index d90e4a264b6f..7f0079ea30b1 100644
> > --- a/drivers/soc/sunxi/sunxi_mbus.c
> > +++ b/drivers/soc/sunxi/sunxi_mbus.c
> > @@ -37,6 +37,7 @@ static const char * const sunxi_mbus_devices[] = {
> > "allwinner,sun5i-a13-video-engine",
> > "allwinner,sun6i-a31-csi",
> > "allwinner,sun6i-a31-display-backend",
> > + "allwinner,sun6i-a31-isp",
> > "allwinner,sun7i-a20-csi0",
> > "allwinner,sun7i-a20-display-backend",
> > "allwinner,sun7i-a20-display-frontend",
> > @@ -50,6 +51,7 @@ static const char * const sunxi_mbus_devices[] = {
> > "allwinner,sun8i-h3-csi",
> > "allwinner,sun8i-h3-video-engine",
> > "allwinner,sun8i-v3s-csi",
> > + "allwinner,sun8i-v3s-isp",
> > "allwinner,sun9i-a80-display-backend",
> > "allwinner,sun50i-a64-csi",
> > "allwinner,sun50i-a64-video-engine",
> >
>

--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]