From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D83FC433FE for ; Tue, 14 Sep 2021 16:25:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17173610F9 for ; Tue, 14 Sep 2021 16:25:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 17173610F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9AGjAEFdDfX/3nhS+sSSxrFJUD6lfP2yNV8+tX/DDPI=; b=qY216QRADN0qML ko6LCjEULKmyo214TaCeoy0m0UUetfNvILeVfzMOHAyf22OJ0lAcr5EjMX+m/IbSrO876SegFCJeg h9i7wd4rnmMR0dpVjDR5AXSoYfIZRmgRNSU8Ru2mYpoKrgHvduB78zAR+3ylAmwJm23M4+WVT8XNa JTHoXNABuVnc/LIwK7GG4rW82oF87tSkThKvKHVe/ds6KhQOOJj3k6wvno4lRVP8k4yDgjEH5AFfo qCVeLWSyWFn85VHxYDTdV2D8L0BhwnZBuGRKDo3UEQi0fomCSrbp/41ZHnSPOWtzvNmq/m0/FrfUg /YLNfIwp/5pXMtcvyAXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQBCm-006Rbo-Tw; Tue, 14 Sep 2021 16:22:45 +0000 Received: from mail-ot1-f46.google.com ([209.85.210.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQBCi-006Rav-UH for linux-arm-kernel@lists.infradead.org; Tue, 14 Sep 2021 16:22:42 +0000 Received: by mail-ot1-f46.google.com with SMTP id i8-20020a056830402800b0051afc3e373aso19285192ots.5 for ; Tue, 14 Sep 2021 09:22:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ELcDPKJa1WqjIjHIohEd4xcW4UCoHGlmNfR9X3tKCTg=; b=EeHmsfvoZGORpSke9EjxpJ/fNDIp1cu5gz7JiGI5P7gIE1P5TvTeXMeSXPlMfUnYVz G51IUs7Z2P6qckT5gLVWrghnKMAMKcbVJ3HcyZW5TI40CpbSzcfPRvJZuMEJfDEyUBYi XfpSUE5NTaVNxWruI/blhy4mgrne4ZxRNOAtKnz0IFVs9G+E3vvwY21m/GMm0+0tBWon XKpZUx4KYLizqILfN0UJwyK8Sjvily3ZIkpWTYpplcPsM88YYzThC/0HpYiJbF1ym0vM 27oqe7edpX0zLJDd62RfXFQHmNcvj92Xt2EoeDfOMwrNl0p6i5HKR5/Tt7Bs7hvXHNuV PlvA== X-Gm-Message-State: AOAM533GeX7yRU/cJTphmiEzv5bPGQGIXIdZFQx1ZCxGkv1Iw61E7CQ8 UoCcDio6uJwpdNPJgv9DSQ== X-Google-Smtp-Source: ABdhPJx9tiukj074D2L64vCKyJvg7rExXu5ryDjVuvb6hck/1tQT1ViBfr9195nKNOWbxgUtyPokxA== X-Received: by 2002:a9d:36d:: with SMTP id 100mr15545952otv.237.1631636559607; Tue, 14 Sep 2021 09:22:39 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id r20sm2704219oot.16.2021.09.14.09.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 09:22:37 -0700 (PDT) Received: (nullmailer pid 3503731 invoked by uid 1000); Tue, 14 Sep 2021 16:22:36 -0000 Date: Tue, 14 Sep 2021 11:22:36 -0500 From: Rob Herring To: Linus Walleij Cc: Stephen Boyd , Pavel Machek , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Linux ARM , linux-clk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , Linux LED Subsystem Subject: Re: [PATCH v2 1/8] dt-bindings: leds: Convert register-bit-led binding to DT schema Message-ID: References: <20210913192816.1225025-1-robh@kernel.org> <20210913192816.1225025-2-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_092241_020487_BBDEABC4 X-CRM114-Status: GOOD ( 19.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 14, 2021 at 12:41:31AM +0200, Linus Walleij wrote: > On Mon, Sep 13, 2021 at 9:28 PM Rob Herring wrote: > > > Convert the register-bit-led binding to DT schema format. > > > > As the example just repeats nearly identical nodes, trim it down to a > > few nodes and use some documented values for 'linux,default-trigger'. > > > > Cc: Linus Walleij > > Cc: Pavel Machek > > Cc: linux-leds@vger.kernel.org > > Signed-off-by: Rob Herring > > Thanks for doing this! > > > v2: > > - Drop undocumented linux,default-trigger values > > Will this lead to warnings? People tend to want to use these. Yes. The list for linux,default-trigger was purposely limited rather than just throw in all the occurrences we could find. It's kind of a mess with similar or overlapping names. There's other and better ways to do this now. There's the 'function' property and you can link to another device. > > (Possibly we could actually create operating-system independent > triggers that make sense on any system. But it's another can > of worms we don't need to open today.) > > > + enum: > > + [ 0x1, 0x2, 0x4, 0x8, 0x10, 0x20, 0x40, 0x80, 0x100, 0x200, 0x400, 0x800, > > + 0x1000, 0x2000, 0x4000, 0x8000, 0x10000, 0x20000, 0x40000, 0x80000, > > + 0x100000, 0x200000, 0x400000, 0x800000, 0x1000000, 0x2000000, 0x4000000, > > + 0x8000000, 0x10000000, 0x20000000, 0x40000000, 0x80000000 ] > > That's an interesting looking enum :D > > But I can't think of anything better, so: We could define our own type, but I can't say I recall the need for this elsewhere. > Reviewed-by: Linus Walleij Thanks. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel