From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F88C433EF for ; Thu, 16 Sep 2021 09:10:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9147C60F93 for ; Thu, 16 Sep 2021 09:10:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9147C60F93 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b2CwSyixo2u65QRpJH1PzoiSbH8MHNPAprZJU3FgQLI=; b=3uSpJoyJU8XYog iA7ekjmf0CCBTo3VU3Ypdm722o+lJiEkGSJWrrcPu7XnLYr3LouW8KHpNqbvkOL5jELs9Men27nYf gsmFyD6vB+pEwPPmyCFCHZaehp2PryIH3DjT0DmPGOO2jvxZ8pp+YY41HOSqBDtyN5INF7dSrR96j vinrQ2416/1QPYP3Vkv/x4Xa9iLevu1j9ymNRTAXRbs/awDBlluLBWXrajnn910NVqdR8acw6d6lm XwBzPtIx4GdKHvN2FEwk8MwN3H2/ktkCeg4VbYroHHMgfYpmjg/kA79PGmipQ1cKexKca8tLP6oMe VtSRpWzFqlvPypGFXn4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQnNn-00AdQG-HR; Thu, 16 Sep 2021 09:08:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQnNk-00AdPu-45 for linux-arm-kernel@lists.infradead.org; Thu, 16 Sep 2021 09:08:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BCA8460F93; Thu, 16 Sep 2021 09:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631783315; bh=WVZp7zAxrJcGJFceYnaC30L3NEug/ghHkDrrF8bTKWI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R8zNlq+6LDpDSB6aIwW2FWWR18uvGGQl1jdbf63U4ouezWknqHqVmp3lEJDDV1pRu Fp/4G4fmivvsMWB2H3DVg/Q0l/Mhfh4TXTChCNcOWcNFwqneRbmLGMSRhpA0BTiBz4 Xzvyb9Gjne5oOLhHdP1BXJtfqjjP+WGGA5DLbbBqscjFZknBvDLhYCaa2KZj0/cAwX ZkjPAiHcvdE6Hra3tpgqRr3xGPtl0m3vEOfqSZH4D/64PuJC/FQd+bbUpJVV1n3vHT sHhJeLOgNyijxqPAXxKOZJbcwVWhywOhamAXhrlCfRGRaskksh6YiDQpJqSMvTkJPR YgIqyI8Kwmalw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1mQnNj-00059h-Oc; Thu, 16 Sep 2021 11:08:36 +0200 Date: Thu, 16 Sep 2021 11:08:35 +0200 From: Johan Hovold To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , Jiri Slaby , Shawn Guo , Li Yang , Scott Wood , "open list:SERIAL DRIVERS" , linuxppc-dev , Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] serial: 8250: SERIAL_8250_FSL should not default to y when compile-testing Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210916_020836_227304_B88B2F18 X-CRM114-Status: GOOD ( 23.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 16, 2021 at 10:55:49AM +0200, Geert Uytterhoeven wrote: > Hi Johan, > > On Thu, Sep 16, 2021 at 10:46 AM Johan Hovold wrote: > > On Wed, Sep 15, 2021 at 02:56:52PM +0200, Geert Uytterhoeven wrote: > > > Commit b1442c55ce8977aa ("serial: 8250: extend compile-test coverage") > > > added compile-test support to the Freescale 16550 driver. However, as > > > SERIAL_8250_FSL is an invisible symbol, merely enabling COMPILE_TEST now > > > enables this driver. > > > > > > Fix this by making SERIAL_8250_FSL visible. Tighten the dependencies to > > > prevent asking the user about this driver when configuring a kernel > > > without appropriate Freescale SoC or ACPI support. > > > > This tightening is arguable a separate change which risk introducing > > regressions if you get it wrong and should go in a separate patch at > > least. > > Getting it wrong would indeed be a regression, but not tightening > that at the same time would mean I have to send a separate patch with > a Fixes tag referring to this fix, following this template: > > foo should depend on bar > > The foo hardware is only present on bar SoCs. Hence add a > dependency on bar, to prevent asking the user about this driver > when configuring a kernel without bar support. I know this is a pet peeve of yours, but asking users about one more symbol when configuring their kernels is hardly something that requires a Fixes tag. Either way it's a pretty weak argument for not separating the change. Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel