From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F4C6C433F5 for ; Fri, 17 Sep 2021 15:14:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D4BA61244 for ; Fri, 17 Sep 2021 15:14:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D4BA61244 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4YaQ0WW3vqqu/oFcNmzSSlKqTxI6NAEuvXCkk/M1LMA=; b=dMqLkd5I1T60yB MHlyX2/VdDAL/wkDfXRxCzM+MjzO9K1VJHms71lOE+IGLDKwCSgJaMamdv/QFQQKnIJkFqNjBbPPT F3mXzY77VfJ68TzSK0fYtUeuQwjEa7IrNIdpNU3qvDlMPzYGsMqXa8zwSUKFNt89P4uSgRYZWGe+G BTu12bLHc6HitKpmhFAMpKmInuvNGpniEaQB8ZA7DtJ5hQIgCjQYPjsoZ7WocWHhwHxp29kPxFppu CrlCM9UgvVZnzi1NdSLmmidtqNtSKjKZzrUKbJb7ixmrJyQkJerqNCJ8O1wk2fg17rInE8GlE56XU BB4sUYmd5kgt4b5XNDag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRFX8-00EVhV-Ex; Fri, 17 Sep 2021 15:12:10 +0000 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRFX4-00EVg7-FK for linux-arm-kernel@lists.infradead.org; Fri, 17 Sep 2021 15:12:08 +0000 Received: by mail-ot1-x32b.google.com with SMTP id c8-20020a9d6c88000000b00517cd06302dso13222355otr.13 for ; Fri, 17 Sep 2021 08:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CbpkK3MKWhoicNomq4vZswgf8W9C6ZPEXdT4IuLeAN0=; b=tPA9DSkPfjRU158Maapz60FNNSZmq0GLX+2Q1HSIUa8gHmKQfo2PxxNzrbwcf4EIBz FtxMUA87nFBkLBIQ7WfusK8x+wamF/BFOoJS0xT6ZcY+k6q88LXViEYSqrljM7ln8e9/ proV7MjGX1pyPwDv5y6ErlMMjfZU0wCWjQXAdsu0an9Gbxg/DqIx0TxX3bOPOFkWbZtw nvYUQtUki/v83A9U1toQvo/Z2ptyf429kvn84v7q2TGWiXGM/l+waAfFXMJ4SkpueD/L 3HXLQPt+QikzMv7CCthdzr7A00omUIBd+3W979a6jvYxvdEdfg85UG2LH5Ek0ZmwTbxG Oa4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CbpkK3MKWhoicNomq4vZswgf8W9C6ZPEXdT4IuLeAN0=; b=EYsIN56evZzwDSpq8HpwWVJBZ7mDD7vJxcFKGoeD+2WIAwJQUsJiVDgNMdxUISTG0B cV/f3KiVGV4BOD65UF00hPtxtQuLq0A/rjvBpi4ZK7J9RyKC6istiHjIgXafxdYeruIx uaGHG0x4ul8Thm24/Nh9Tx4awOkfJRelDcpnhrJFZDvUrsO4Mq5OVOQcBlnynDTm5tsO KdXIys1XqJ2/LPIf9vQ/iGZWwr87X7WSUA4xUJFnA2oKztE+RoLJj2Iv2ul9WJx4HUMp 3mri60mLKBmeEh7IVXrRbptVNNz8LJNZ5cRY9u77ufLLcHfSNfCM/YCh7e7YWVXvnzWF Bjdw== X-Gm-Message-State: AOAM533jthJ/wkZPgClP9PfyJWqwhYCnC+G3hY0dE1110MFa6JwxYuOw J+10+2PZum53zhyPMg9DQo3EeQ== X-Google-Smtp-Source: ABdhPJzXQBFkdOea9/dxNT0X+/pbnPjluuH5FejB9i1Rtzyvjuum48zbXlO5HMCj+dwC4CWzaDIWKQ== X-Received: by 2002:a05:6830:1b6f:: with SMTP id d15mr9708181ote.158.1631891524489; Fri, 17 Sep 2021 08:12:04 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id bi41sm1501939oib.54.2021.09.17.08.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Sep 2021 08:12:04 -0700 (PDT) Date: Fri, 17 Sep 2021 10:12:00 -0500 From: Bjorn Andersson To: Sinthu Raja Subject: Re: [PATCH] dt-bindings: hwlock: omap: Remove board-specific compatible from DT example Message-ID: References: <20210917094740.18891-1-sinthu.raja@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210917094740.18891-1-sinthu.raja@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210917_081206_630826_FFFF0693 X-CRM114-Status: GOOD ( 25.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ohad Ben-Cohen , devicetree@vger.kernel.org, Nishanth Menon , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Sinthu Raja , Rob Herring , Baolin Wang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri 17 Sep 04:47 CDT 2021, Sinthu Raja wrote: > From: Sinthu Raja > > The example includes a board-specific compatible property, this is > wrong as the example should be board agnostic. Replace the same with a > generic soc node. > I do think your fix is correct in that it results in a proper tree, but the examples are not supposed to describe the node in a fully described DT tree, but rather just show an example of the particular binding. I therefor think that it would be appropriate to reduce that second example to just: spinlock@30e00000 { compatible = "ti,am654-hwspinlock"; reg = <0x30e00000 0x1000>; #hwlock-cells = <1>; }; Because the rest has nothing to do with this binding. That said, this example is now the same example as the first one, just with different compatible, so I think we should drop the entire second example instead. PS. While we're doing that, we should also remove the "hwspinlock: " label from the first example. Regards, Bjorn > Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML") > Signed-off-by: Sinthu Raja > --- > > This patch was triggered by discussions in [1]. > > When applying the patch, if you could provide an immutable tag for the > bindings, it would help line things up for new platforms to be added for > us. See [2] for the context > > [1] https://lore.kernel.org/all/20210818074030.1877-1-sinthu.raja@ti.com/ > [2] https://lore.kernel.org/linux-arm-kernel/20210125141642.4yybjnklk3qsqjdy@steersman/ > > .../devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml > index ae1b37dbee75..d56dc1bebdc6 100644 > --- a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml > +++ b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml > @@ -47,10 +47,8 @@ examples: > }; > > - | > - / { > + soc { > /* K3 AM65x SoCs */ > - model = "Texas Instruments K3 AM654 SoC"; > - compatible = "ti,am654-evm", "ti,am654"; > #address-cells = <2>; > #size-cells = <2>; > > -- > 2.32.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel