From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D9F5C433EF for ; Sun, 19 Sep 2021 09:26:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B63F611F0 for ; Sun, 19 Sep 2021 09:26:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5B63F611F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8qgoHkL9+s50AJIqOEl+HhMSL+Q9aE4INklfQ+YzpKY=; b=0sZmM2OgOt4lsD IyFetmze/LMz4HyZAFzaR+FD4i3sLpq/j1kDIBRdII+FdlTv2HH3CEs+8QUnE363RS8Qnrx67/zoi pb0kniDl2yVYbq1eAao37gCJQkPrahBl9kgJwF7BjCecOCKtAe2O70ALctUsjb3NZLUv3VtP5C2xZ 6yWYPbjbK8qdx7iB1U9wFAx2P0pRw7myIgO/F9c+hm8Yguf4grA82gro6u0ovENd9E5nJun9dVDuL 7hnBIrI3OONQZftG+B8/Dgc4RF43Dh55ldF7ezV4DFaaFPlBrZchNh5MpvrFC4UGodyPwTItOKsUP x/Q/kv3qSth6G/Cihy+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRt3o-00H1zg-8u; Sun, 19 Sep 2021 09:24:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRt3k-00H1zM-JM for linux-arm-kernel@lists.infradead.org; Sun, 19 Sep 2021 09:24:30 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5957061212; Sun, 19 Sep 2021 09:24:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632043468; bh=bSIZwIh5uthvdwZh1zrRqm4gzyWRwEiLJVqVSspJ50s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cb6HeccPyGESeX7Jom5I3x66ewqBZS6QNnOZi8DCZeG+NUBDUlAJCylPrVB0xZRg2 UHQSMsHUxl2uM+Epdiy+70MaQPei0CynByHe+aB0x1fZenDaVR0MIAN/DtPQJXfKcM FA8xNamRMuclK34Y1PvAPNe2fnjZXEvgMJ+reV40= Date: Sun, 19 Sep 2021 11:24:25 +0200 From: Greg Kroah-Hartman To: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Marek Szyprowski , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz , Tomasz Figa , Arnd Bergmann , Olof Johansson , Alim Akhtar , Chanwoo Choi , Pankaj Dubey Subject: Re: [PATCH 1/2] soc: export soc_device_to_device symbol Message-ID: References: <20210917175134.252882-1-krzysztof.kozlowski@canonical.com> <20210917175134.252882-2-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210919_022428_700874_DA4E266D X-CRM114-Status: GOOD ( 20.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Sep 19, 2021 at 11:12:29AM +0200, Krzysztof Kozlowski wrote: > On 18/09/2021 09:02, Greg Kroah-Hartman wrote: > > On Fri, Sep 17, 2021 at 07:51:33PM +0200, Krzysztof Kozlowski wrote: > >> In case if soc-bus drivers are modules soc_device_to_device() has to be > >> exported. Since it is trivial, export it as non-GPL. > >> > >> Signed-off-by: Krzysztof Kozlowski > >> --- > >> drivers/base/soc.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/base/soc.c b/drivers/base/soc.c > >> index 0af5363a582c..ac8db303daa1 100644 > >> --- a/drivers/base/soc.c > >> +++ b/drivers/base/soc.c > >> @@ -41,6 +41,7 @@ struct device *soc_device_to_device(struct soc_device *soc_dev) > >> { > >> return &soc_dev->dev; > >> } > >> +EXPORT_SYMBOL(soc_device_to_device); > > > > I thought we were getting rid of the use of this function, why export it > > and not just fix it up instead? > > > > Or am I confused about some other soc device abuse... > > I was not aware of discussion about soc_device_to_device(). Thanks for > pointing out the issue. I googled a little and found previous talks: > https://lore.kernel.org/lkml/20191111052741.GB3176397@kroah.com/ > > I can easily get rid of soc_device_to_device() in my driver, so first > patch won't be needed. Wonderful, thanks for fixing that up. greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel