From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99BD5C433F5 for ; Mon, 20 Sep 2021 16:30:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64FD261019 for ; Mon, 20 Sep 2021 16:30:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 64FD261019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CFKgBpb1pmH5Ug4XHjzXTqOQso4pe1yEViNvZ9nrZyk=; b=hYb1b+Cjt3rLrN zEN6sqOTNY40M4BLkLIUXRDHV3ixwbjXV5HTJzRVELlKpUPZ7IQ0Sel2XsiIG6UIBLTloWfYgoXxd HTdwkyOvJdHGuHahQx1l1lWCuXI1i5e2Ulv67oWntlBiho9JsqoK2ML1vQxuBy9hbnzkmEAjFBMjW 7wLfyg0LWjhYkk2jNQUoMZrT0krELZzM87MFKwRdgf6T//dZbboGkFapouavo1rpy8kCASkH+nM5O IuJlfZaWUjYn53GBeSz2LMZxUIybW+AqajwCS7gCOPGDW57Mt6wgiPTkF8cERWn+nNRGIf2pb67EH ZUS3N21ERw7G+5CUmnjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSM9m-002R4a-Nn; Mon, 20 Sep 2021 16:28:38 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSM9j-002R3u-B8 for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 16:28:36 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 825822F06; Mon, 20 Sep 2021 18:28:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1632155311; bh=rT3iP0dO5pvYhS8utchpgMyakT6U9Iy8T0YzsoNSQus=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UDZgeUitXVv8n0Ag8SqWvA+699JQg38we82uzXq94Z6g+LA9b9B33PXNtOpdU/zBZ dueDxH8QPImnBbYd3TfLgOMu0QY7hdsrpiGQOK58d7oZ+Frlui8kFY99laly0Nw6r7 iKqJz0GABmZ536ENyCDwipW8LOi0YyKGCnAwqez8= Date: Mon, 20 Sep 2021 19:28:01 +0300 From: Laurent Pinchart To: Arnd Bergmann Cc: Hyun Kwon , Vinod Koul , Michal Simek , Sanjay R Mehta , Peter Ujfalusi , Arnd Bergmann , Jianqiang Chen , Quanyang Wang , Yang Li , Allen Pais , Lad Prabhakar , Biju Das , Andy Shevchenko , dmaengine@vger.kernel.org, Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] dmaengine: remove debugfs #ifdef Message-ID: References: <20210920122017.205975-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_092835_588714_5FCAFB95 X-CRM114-Status: GOOD ( 15.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On Mon, Sep 20, 2021 at 02:50:52PM +0200, Arnd Bergmann wrote: > On Mon, Sep 20, 2021 at 2:47 PM Laurent Pinchart wrote: > > > > It's only a few bytes of data in struct dma_device, but a bit more in > > .text here. Is the simplification really required in this driver ? > > The intention was to not change the resulting object code in this driver, > and I still don't see where it would grow after dead-code-elimination removes > all the unused static functions. What am I missing? Indeed, gcc does a fairly good job there. The .text section doesn't grow. Interestingly, there's an increase in size in the .data and .rodata sections in the xilinx-dpdma module: - 8 .rodata.str1.8 0000029f 0000000000000000 0000000000000000 00003660 2**3 + 8 .rodata.str1.8 000002a7 0000000000000000 0000000000000000 00003660 2**3 - 10 .rodata 00001080 0000000000000000 0000000000000000 00003960 2**5 + 10 .rodata 000010e0 0000000000000000 0000000000000000 00003960 2**5 - 15 .data 00001050 0000000000000000 0000000000000000 00004e40 2**5 + 15 .data 00001090 0000000000000000 0000000000000000 00004ea0 2**5 I'm not entirely sure where it comes from, it may be related to instrumentation caused by debugging options. For your patch, Reviewed-by: Laurent Pinchart -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel