From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92978C433EF for ; Tue, 21 Sep 2021 05:56:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D43660FA0 for ; Tue, 21 Sep 2021 05:56:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5D43660FA0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Tvn+umhNWp7lfZgzyoIXvVqM31tDuSxSkQNO+jhOxHQ=; b=kCroDLgUpce/45Bg0MX471QkG9 WyQ5R8SsXwEa2iRVfVm9Rd4dNXFwQD5Cy2e7vN7BqcyFEqhGvCy8JBPv9W7myZu80I+gYCONrTLbX ovyAh+yH24d3B95QDxCP65t59hgKzXpdHFtu/46EWvzZYLyPNJtgSoDFIk5y3dI2HFDik/Y1D0UJF IXGCTK7e/9TF9X8LKW4lVrlcJpv4WwORKwYQR6EJ5TDT53fr/vb0SFPBSAqKRJdspnHtERByTG+WG rnjHktx+5rfybv4f11dvbI3LYnD9L7/BKYByNnpxBvWG0saICg4VHZ21hKnISsQnc1LlhK+j5lk0e L1HIbTyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSYhl-003fF8-5a; Tue, 21 Sep 2021 05:52:33 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSYhg-003fEK-Jg for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 05:52:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=TsC7Gf8WNSlJZ2XI5WCkNgZUyR2l j2Iij8k4znGy35Q=; b=GYDUxnuZz1WCM9i5DOD0Lyj3+f10g6mCvhKZ+yj4A0M3 Z6lHweg2hvKsBATNUHeUyTBownIcoI4HRMuBlQZncftDW9uI0osur358+SOeOXyM cbeOKtqIFNusPGFl3iXgkcPyYXFv2iqHm7hCX9oZxltDQYbbifqfM2s83rCxjOY= Received: (qmail 2740070 invoked from network); 21 Sep 2021 07:52:23 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 21 Sep 2021 07:52:23 +0200 X-UD-Smtp-Session: l3s3148p1@EuEyAHvMas8gAwDPXxJ6ACVKg6pV4G9h Date: Tue, 21 Sep 2021 07:52:19 +0200 From: Wolfram Sang To: Florian Fainelli Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 7/9] net: mdio: mdio-bcm-iproc: simplify getting .driver_data Message-ID: Mail-Followup-To: Wolfram Sang , Florian Fainelli , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210920090522.23784-1-wsa+renesas@sang-engineering.com> <20210920090522.23784-8-wsa+renesas@sang-engineering.com> <6a8ffcab-4534-1692-5f6a-8a7906d07a09@gmail.com> MIME-Version: 1.0 In-Reply-To: <6a8ffcab-4534-1692-5f6a-8a7906d07a09@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_225229_289012_F59D10B8 X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2884317170805329207==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2884317170805329207== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lhLmpLSFjJ4cOlGR" Content-Disposition: inline --lhLmpLSFjJ4cOlGR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > The change looks good to me, however if you change from > platform_get_drvdata() to dev_get_drvdata(), you might also want to > change from using platform_set_drvdata() to dev_set_drvdata() for > symmetry no? If not, then maybe this patch should be dropped? In theory, yes. However, I haven't finished the coccinelle script yet because there are a lot more usage patterns. I can do this individually for this driver first if you want. --lhLmpLSFjJ4cOlGR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmFJcw8ACgkQFA3kzBSg KbZhwRAAllWphC2uNFh1IXRes+w2NxhbIvR7QkzU83hHzeYBsyhHaZuvVGAFogPq QAlitr4Ea30sImmthBwldN79YGuX80gloJnq+gq8W4AvKbWa9bX+kmovig/jdsy6 ixuoMnAQoxwD9ya+c7wqMZax9A8QI3Fks0/aoGXZBeJWMrRaKq/V0WQ8TCrm6kZ2 RlfW6xMWmCxNia0a2p2rZRpgsqQH7eNxYG/pY821XJYXXyNFzDDm+AA9ctJuiSTS RBiFdwSjSRIedPGm52iew2EXeh4D+o+nH/a93iFZq5DPu6TjMolVRyyNtGeU/oEL /GgwjvaJg66NMkzOdY+aEpqPQ60+5eCOHNKoZgIxeORws7W2wlJt/VOBYq6MtROY dDDASxQ0MyLGuh6C62JMIiMxa3+DjmTujJWu9K/YdZul47JMT1aEICUuQIEr/5U9 k5PVHgE/hM+VXfl73fXSnbqSn24HGOIKjxzi/Qf4+XLpD82C2uUwWFjqsnrMoL9+ rYINPUwo0zW6U0s48fThnkwYuY1kGlK+qFvpQIGGiAMoaq9Bd3cDxbx72qOf8KV2 U8cqzJoh0M0aLVEUyncQ+27SMo4m6xWsi77Ga9n7BbMX31snCJTDHiDn2HukdGka pmhsHigfeelqBKR9/iTLhI1G+iWAOMyFgnhQvRZh4jVG94wC2bY= =1qz8 -----END PGP SIGNATURE----- --lhLmpLSFjJ4cOlGR-- --===============2884317170805329207== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2884317170805329207==--