From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB87C433EF for ; Tue, 21 Sep 2021 16:14:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D03FB6109E for ; Tue, 21 Sep 2021 16:14:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D03FB6109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VMJWI0AQMrAbbPdOe4oT45BusuJkGm88mWuil7J9Qt4=; b=3cicNo8qH1USjy 4JRnXWjDJf4xLNbYDDuNWB3snPJUTzFMZk00AOjaa43/KySBSvOChfZl2JXvtjNxUc9MRaNZGR9hQ NGAz5U3QdFjiTD/MmLwoHxC6Yzm5iifc/WHj+X5m76M2D+/uTyTsff/9LdZFSgXyZ9ULYQXmDp/R5 51doma1Kej/zOSFw98ZZQCCdC09PQPGMSFhL/pYJ2HkzrEHEN8UGNqL/+kxKmStTYp2GgW4f0O+21 2/p7jHvzoqQ/TfRaH3zqJvgN+PIV5+qeAEn8nJSHSe2OA8Nw1nkL6HVHa87+qGAWFmqZlAM4FX06Z bSVpNeQkyTnz3cym/sFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSiNh-0057qa-Pv; Tue, 21 Sep 2021 16:12:30 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSiFJ-0054GJ-Gl for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 16:03:51 +0000 Received: by mail-wr1-x42a.google.com with SMTP id i23so40803051wrb.2 for ; Tue, 21 Sep 2021 09:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=c9ydbvY8sDfCdxG0I7FnWgHTf3YXOLh553u7tDIhY7Q=; b=hOu9oqEpgRma4m5TwajhAd5E/ajA0+oK5Wilrodt3LT7oGNBQVS/alGR9wd4Vflv/v Jxp4GyJh+p4DoX7CDkqq4P9vJ/4OO/DUQQqOTCLQXw/iaOKndL3YBFu74cReCsa3WB85 h2zl/fVWmaAyNvuPTxYcKdDgXat04zMpqmEvVr2eDR3XgdWLCKrz9ALQAw7Ae0CWv5Cf E82i7jMw1EoTdPtwkwPy85ocWzQsCVLxR6CLmAer6depp97ulfIRcVODaNsWq17W94tc 8NTYrtEnImcl7CE8pLca0kYtxR0e6N6JjBfCnoBDqY57l9J6Z4XR9y/xi9jkDVCIFsUd 8RyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c9ydbvY8sDfCdxG0I7FnWgHTf3YXOLh553u7tDIhY7Q=; b=K+gexONRjOX8G1T94d0LfY9i6fwdgUEGaCBXoUFUmoAmhkRGPWGT6PhFGNy/C3tWV2 XaP7Ns9yRmnRBQHzvj1mWVyYk+k+tPs1pvc7hFHva4AE4fjKGmh9RHUDVhLqaN90LJEE cjPwBpGZnSJaZ1r31d03iUR0WUtnSNEjM2NJN1Qb8j1HC1NlB7IksCVL81BTT9c9g0kW 4/6P5J5bQMd9H0RwqDOmorVOwkdYLAZIyjScTd7SBSzKqEvay8MHQlbpkj/hWq7Cpiz4 oZAhrC+FxJRAOUQ9zhutNv8K/bTRO6Jmekyu6bLZiH80fO86KZ8vp/a6WpzmCuqnHseS xPwg== X-Gm-Message-State: AOAM5311okytPAxMBz9GcBM6U5r0yat1G6oBvO7AnZxqdVqxh+uGamgF OKj9+G7kZikKEUkbVcG02fLOCg== X-Google-Smtp-Source: ABdhPJzogdRHMobW1EV7gNAcIgxeJ8ugHZsaEOBpNSPLnWVSDi+WSM6RWXiAksaaRnOXJnSOuAd9Ug== X-Received: by 2002:a05:600c:3209:: with SMTP id r9mr5445839wmp.35.1632240227704; Tue, 21 Sep 2021 09:03:47 -0700 (PDT) Received: from myrica (cpc92880-cmbg19-2-0-cust679.5-4.cable.virginm.net. [82.27.106.168]) by smtp.gmail.com with ESMTPSA id j20sm19907636wrb.5.2021.09.21.09.03.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 09:03:46 -0700 (PDT) Date: Tue, 21 Sep 2021 17:03:25 +0100 From: Jean-Philippe Brucker To: Vivek Gautam Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, virtualization@lists.linux-foundation.org, joro@8bytes.org, will.deacon@arm.com, mst@redhat.com, robin.murphy@arm.com, eric.auger@redhat.com, kevin.tian@intel.com, jacob.jun.pan@linux.intel.com, yi.l.liu@intel.com, Lorenzo.Pieralisi@arm.com, shameerali.kolothum.thodi@huawei.com Subject: Re: [PATCH RFC v1 03/11] iommu/virtio: Handle incoming page faults Message-ID: References: <20210423095147.27922-1-vivek.gautam@arm.com> <20210423095147.27922-4-vivek.gautam@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210423095147.27922-4-vivek.gautam@arm.com> X-TUID: xnj50RSTlhls X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_090349_630211_ED02B344 X-CRM114-Status: GOOD ( 28.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 23, 2021 at 03:21:39PM +0530, Vivek Gautam wrote: > Redirect the incoming page faults to the registered fault handler > that can take the fault information such as, pasid, page request > group-id, address and pasid flags. > > Signed-off-by: Vivek Gautam > --- > drivers/iommu/virtio-iommu.c | 80 ++++++++++++++++++++++++++++++- > include/uapi/linux/virtio_iommu.h | 1 + > 2 files changed, 80 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c > index c970f386f031..fd237cad1ce5 100644 > --- a/drivers/iommu/virtio-iommu.c > +++ b/drivers/iommu/virtio-iommu.c > @@ -37,6 +37,13 @@ > /* Some architectures need an Address Space ID for each page table */ > DEFINE_XARRAY_ALLOC1(viommu_asid_xa); > > +struct viommu_dev_pri_work { > + struct work_struct work; > + struct viommu_dev *dev; > + struct virtio_iommu_fault *vfault; > + u32 endpoint; > +}; > + > struct viommu_dev { > struct iommu_device iommu; > struct device *dev; > @@ -49,6 +56,8 @@ struct viommu_dev { > struct list_head requests; > void *evts; > struct list_head endpoints; > + struct workqueue_struct *pri_wq; > + struct viommu_dev_pri_work *pri_work; IOPF already has a workqueue, so the driver doesn't need one. iommu_report_device_fault() should be fast enough to be called from the event handler. > > /* Device configuration */ > struct iommu_domain_geometry geometry; > @@ -666,6 +675,58 @@ static int viommu_probe_endpoint(struct viommu_dev *viommu, struct device *dev) > return ret; > } > > +static void viommu_handle_ppr(struct work_struct *work) > +{ > + struct viommu_dev_pri_work *pwork = > + container_of(work, struct viommu_dev_pri_work, work); > + struct viommu_dev *viommu = pwork->dev; > + struct virtio_iommu_fault *vfault = pwork->vfault; > + struct viommu_endpoint *vdev; > + struct viommu_ep_entry *ep; > + struct iommu_fault_event fault_evt = { > + .fault.type = IOMMU_FAULT_PAGE_REQ, > + }; > + struct iommu_fault_page_request *prq = &fault_evt.fault.prm; > + > + u32 flags = le32_to_cpu(vfault->flags); > + u32 prq_flags = le32_to_cpu(vfault->pr_evt_flags); > + u32 endpoint = pwork->endpoint; > + > + memset(prq, 0, sizeof(struct iommu_fault_page_request)); The fault_evt struct is already initialized > + prq->addr = le64_to_cpu(vfault->address); > + > + if (prq_flags & VIRTIO_IOMMU_FAULT_PRQ_F_LAST_PAGE) > + prq->flags |= IOMMU_FAULT_PAGE_REQUEST_LAST_PAGE; > + if (prq_flags & VIRTIO_IOMMU_FAULT_PRQ_F_PASID_VALID) { > + prq->flags |= IOMMU_FAULT_PAGE_REQUEST_PASID_VALID; > + prq->pasid = le32_to_cpu(vfault->pasid); > + prq->grpid = le32_to_cpu(vfault->grpid); > + } > + > + if (flags & VIRTIO_IOMMU_FAULT_F_READ) > + prq->perm |= IOMMU_FAULT_PERM_READ; > + if (flags & VIRTIO_IOMMU_FAULT_F_WRITE) > + prq->perm |= IOMMU_FAULT_PERM_WRITE; > + if (flags & VIRTIO_IOMMU_FAULT_F_EXEC) > + prq->perm |= IOMMU_FAULT_PERM_EXEC; > + if (flags & VIRTIO_IOMMU_FAULT_F_PRIV) > + prq->perm |= IOMMU_FAULT_PERM_PRIV; > + > + list_for_each_entry(ep, &viommu->endpoints, list) { > + if (ep->eid == endpoint) { > + vdev = ep->vdev; > + break; > + } > + } > + > + if ((prq_flags & VIRTIO_IOMMU_FAULT_PRQ_F_PASID_VALID) && > + (prq_flags & VIRTIO_IOMMU_FAULT_PRQ_F_NEEDS_PASID)) > + prq->flags |= IOMMU_FAULT_PAGE_RESPONSE_NEEDS_PASID; > + > + if (iommu_report_device_fault(vdev->dev, &fault_evt)) > + dev_err(vdev->dev, "Couldn't handle page request\n"); An error likely means that nobody registered a fault handler, but we could display a few more details about the fault that would help debug the endpoint > +} > + > static int viommu_fault_handler(struct viommu_dev *viommu, > struct virtio_iommu_fault *fault) > { > @@ -679,7 +740,13 @@ static int viommu_fault_handler(struct viommu_dev *viommu, > u32 pasid = le32_to_cpu(fault->pasid); > > if (type == VIRTIO_IOMMU_FAULT_F_PAGE_REQ) { > - dev_info(viommu->dev, "Page request fault - unhandled\n"); > + dev_info_ratelimited(viommu->dev, > + "Page request fault from EP %u\n", > + endpoint); That's rather for debugging the virtio-iommu driver, so should be dev_dbg() (or removed entirely) > + > + viommu->pri_work->vfault = fault; > + viommu->pri_work->endpoint = endpoint; > + queue_work(viommu->pri_wq, &viommu->pri_work->work); > return 0; > } > > @@ -1683,6 +1750,17 @@ static int viommu_probe(struct virtio_device *vdev) > goto err_free_vqs; > } > > + viommu->pri_work = kzalloc(sizeof(*viommu->pri_work), GFP_KERNEL); > + if (!viommu->pri_work) > + return -ENOMEM; > + > + viommu->pri_work->dev = viommu; > + > + INIT_WORK(&viommu->pri_work->work, viommu_handle_ppr); > + viommu->pri_wq = create_singlethread_workqueue("viommu-pri-wq"); > + if (!viommu->pri_wq) > + return -ENOMEM; > + > viommu->map_flags = VIRTIO_IOMMU_MAP_F_READ | VIRTIO_IOMMU_MAP_F_WRITE; > viommu->last_domain = ~0U; > > diff --git a/include/uapi/linux/virtio_iommu.h b/include/uapi/linux/virtio_iommu.h > index accc3318ce46..53aa88e6b077 100644 > --- a/include/uapi/linux/virtio_iommu.h > +++ b/include/uapi/linux/virtio_iommu.h > @@ -302,6 +302,7 @@ struct virtio_iommu_req_invalidate { > #define VIRTIO_IOMMU_FAULT_F_READ (1 << 0) > #define VIRTIO_IOMMU_FAULT_F_WRITE (1 << 1) > #define VIRTIO_IOMMU_FAULT_F_EXEC (1 << 2) > +#define VIRTIO_IOMMU_FAULT_F_PRIV (1 << 3) Should go in the previous patch. (I'd also prefer 'privileged' because in this context 'priv' is easily read as 'private') Thanks, Jean > #define VIRTIO_IOMMU_FAULT_F_ADDRESS (1 << 8) > > #define VIRTIO_IOMMU_FAULT_F_DMA_UNRECOV 1 > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel