From: Marco Elver <elver@google.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Evgenii Stepanov <eugenis@google.com>,
Branislav Rankov <Branislav.Rankov@arm.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH v2 5/5] kasan: Extend KASAN mode kernel parameter
Date: Wed, 6 Oct 2021 13:35:15 +0200 [thread overview]
Message-ID: <YV2J8/i7C/FYf4F1@elver.google.com> (raw)
In-Reply-To: <20211004202253.27857-6-vincenzo.frascino@arm.com>
On Mon, Oct 04, 2021 at 09:22PM +0100, Vincenzo Frascino wrote:
[...]
> DECLARE_STATIC_KEY_FALSE(kasan_flag_stacktrace);
> extern bool kasan_flag_async __ro_after_init;
> +extern bool kasan_flag_asymm __ro_after_init;
>
> static inline bool kasan_stack_collection_enabled(void)
> {
> return static_branch_unlikely(&kasan_flag_stacktrace);
> }
>
> -static inline bool kasan_async_mode_enabled(void)
> +static inline bool kasan_async_fault_possible(void)
> {
> - return kasan_flag_async;
> + return kasan_flag_async | kasan_flag_asymm;
> +}
> +
> +static inline bool kasan_sync_fault_possible(void)
> +{
> + return !kasan_flag_async | kasan_flag_asymm;
> }
Is the choice of bit-wise OR a typo? Because this should probably have
been logical OR. In this case, functionally it shouldn't matter, but is
unusual style.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-06 11:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 20:22 [PATCH v2 0/5] arm64: ARMv8.7-A: MTE: Add asymm in-kernel support Vincenzo Frascino
2021-10-04 20:22 ` [PATCH v2 1/5] kasan: Remove duplicate of kasan_flag_async Vincenzo Frascino
2021-10-04 20:22 ` [PATCH v2 2/5] arm64: mte: Bitfield definitions for Asymm MTE Vincenzo Frascino
2021-10-04 20:22 ` [PATCH v2 3/5] arm64: mte: CPU feature detection " Vincenzo Frascino
2021-10-04 20:22 ` [PATCH v2 4/5] arm64: mte: Add asymmetric mode support Vincenzo Frascino
2021-10-06 12:19 ` Andrey Konovalov
2021-10-06 14:21 ` Vincenzo Frascino
2021-10-04 20:22 ` [PATCH v2 5/5] kasan: Extend KASAN mode kernel parameter Vincenzo Frascino
2021-10-06 10:58 ` Will Deacon
2021-10-06 11:35 ` Marco Elver [this message]
2021-10-06 14:22 ` Vincenzo Frascino
2021-10-06 12:19 ` Andrey Konovalov
2021-10-06 14:25 ` Vincenzo Frascino
2021-10-05 22:25 ` [PATCH v2 0/5] arm64: ARMv8.7-A: MTE: Add asymm in-kernel support Andrew Morton
2021-10-06 8:05 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV2J8/i7C/FYf4F1@elver.google.com \
--to=elver@google.com \
--cc=Branislav.Rankov@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox