From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BAA9C433EF for ; Wed, 6 Oct 2021 11:37:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BF5D604E9 for ; Wed, 6 Oct 2021 11:37:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0BF5D604E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Rax6dR5YnNS5FvZmVY2ejsNWU6mbUR6Dd0Lc+jL7yMc=; b=gej5/qJezLdKZA YtvybaznBwemMDZSeEx28rtZLaGDjFaON0CqkqSeCMhH7fGdM2PzslUKls+LVA04GZ/Sikv3JEnbQ 6iaXa/SqQ+/SJEE37FhrY/KOCFSuoB/GaLA/jV9EnLNhhe2L59bMGerVfPyjAoojuOMocY2Ife/wf FTdMZAZDfu8aNwVuBYXv8bgcHyEWffYRjJhZO1Z23HDIuNx+Mb7xVOrye0jG/QyvsJo7Gi5ljc6xo +q6VlUhqorZSXCmFd3LZZf6iuGnK/eMsqX9FR8JvR+5pDaHa9iGcR9hbF8UfuS1yjHYnpQxEINLQK 8KmH86TlDfofW/zEYHvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY5Co-00E5TX-9X; Wed, 06 Oct 2021 11:35:26 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY5Cl-00E5Sq-D3 for linux-arm-kernel@lists.infradead.org; Wed, 06 Oct 2021 11:35:24 +0000 Received: by mail-wr1-x42a.google.com with SMTP id s15so7850180wrv.11 for ; Wed, 06 Oct 2021 04:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WlB+aQwesSqg+PcbUJ65iZtpYtFLGZhjloxXmDYdamI=; b=L2cB28Z0wz5JHhrTTsd6YlPd2Blpu9lFVOJC8to1DQTlK3kM6hhcyJVTp/k3dTx2dN /KqMwAlC+HrNAYlnL0fugxZXs+WAIT149hLimQ0fogDazUC3BvCMiRctmkPbF7SqNTyY 9jKVm/8Ncj1LM7k9kWAO2dt9TmW5UrGdZnOfJDA8b38TCDDzzLnl+679dnFEfQ2gAUY3 SkyqpFOmkNOKwyTLzX5YMDZuDE5454Rk5/UIZOu3740JnBGWYauo54MZvkB6rQumBp3Y cnoDmi0ok14Uez/7gp9D0zEnO/DE4zlkNIWamTa05HbrM11NaoxAmFexZTQOYSA9mQUk yFRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WlB+aQwesSqg+PcbUJ65iZtpYtFLGZhjloxXmDYdamI=; b=oBw5kCDmh8GsQHAQN24CHA4gbBFL0nIgfWwnqRRfm7YYB6LbPDtioNktUTLfDGWd6o fYykdS0QObO/F7rfT/hUdFQ8TulOJlw5jFOJYeeK/qYH1JxaKBj41/JSk+uYrz+A1ifA VPF9gJOnPv2Ly896rp1sdv2W24DQwsSV6+j1SsQXvjrRlAl4i5mi6h2TgZbNp87ZWb+w Y0WX0IdknqsYK0oZwEULS1YoOvDQhQkiVM3szqx5D/+DF7vdkoJMfuw9GWq6gRn3Ue7I YKZRuSw2tSF4mgta1mCv4SzKcJCNIBfNzv5YeA95jhhASipCCwgQdeP9n4r1QeiTnpo4 eYuw== X-Gm-Message-State: AOAM5316m7pKVDyAfV8z3U8EWWvI949anyGuCPvvAATlIyUoivjUeZ29 t/nLjpycjQu365m1EJrld5XzSzegXOUN3g== X-Google-Smtp-Source: ABdhPJx4kB+4pSHbo38S/Hyxgkv3G5HzJVBV0fElyQQUYmWqrIKgrK7SOiuo6C3zNW2p6gI+eZbByQ== X-Received: by 2002:a1c:43c3:: with SMTP id q186mr9058705wma.143.1633520121547; Wed, 06 Oct 2021 04:35:21 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:15:13:378e:f074:3bc9:383c]) by smtp.gmail.com with ESMTPSA id n186sm5079756wme.31.2021.10.06.04.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 04:35:20 -0700 (PDT) Date: Wed, 6 Oct 2021 13:35:15 +0200 From: Marco Elver To: Vincenzo Frascino Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Andrew Morton , Catalin Marinas , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Branislav Rankov , Andrey Konovalov , Lorenzo Pieralisi Subject: Re: [PATCH v2 5/5] kasan: Extend KASAN mode kernel parameter Message-ID: References: <20211004202253.27857-1-vincenzo.frascino@arm.com> <20211004202253.27857-6-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211004202253.27857-6-vincenzo.frascino@arm.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211006_043523_480484_A29974A1 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 04, 2021 at 09:22PM +0100, Vincenzo Frascino wrote: [...] > DECLARE_STATIC_KEY_FALSE(kasan_flag_stacktrace); > extern bool kasan_flag_async __ro_after_init; > +extern bool kasan_flag_asymm __ro_after_init; > > static inline bool kasan_stack_collection_enabled(void) > { > return static_branch_unlikely(&kasan_flag_stacktrace); > } > > -static inline bool kasan_async_mode_enabled(void) > +static inline bool kasan_async_fault_possible(void) > { > - return kasan_flag_async; > + return kasan_flag_async | kasan_flag_asymm; > +} > + > +static inline bool kasan_sync_fault_possible(void) > +{ > + return !kasan_flag_async | kasan_flag_asymm; > } Is the choice of bit-wise OR a typo? Because this should probably have been logical OR. In this case, functionally it shouldn't matter, but is unusual style. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel