From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54C3CC433EF for ; Mon, 27 Sep 2021 19:02:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E4046054E for ; Mon, 27 Sep 2021 19:02:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1E4046054E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B/TIbEPDDrzTDEF2FdKx8Xj3JAU0CxjmK4F/m1XE8j0=; b=17IyCxDaFwb/kB Jn8t+P0mXP9CY1gAl+tysZepHE7rSzkNn/f9kX5RbzO9cVwiASp+blrZHtsigc3Jnf137hvaZ7Pbz ZMDBcZAxrEFXeOn5SFlzanq2Vb4YWS+X+6KlfbuIQj7qmEjgpQEmZj8Inn3/DeNG+N3HM8698Sobp pKOkReLvZGjiqXrLZDuzH/fdv+xoxlCHDUn9MqCu4PuzoZAYTCwirgpnIZCBvpfBhiQH6f5MxWnAd uEKq7FxG63iejQBVw8uht0sfEUka4/qgq3YFrvnee7rE7slWgCj8PMnj0v88RfRMWGvuZGb4jGT7W udaNQ7k1AajXmELXpevQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUvqf-003tRL-22; Mon, 27 Sep 2021 18:59:33 +0000 Received: from mail-oi1-f174.google.com ([209.85.167.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUvqM-003tL3-CZ for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 18:59:15 +0000 Received: by mail-oi1-f174.google.com with SMTP id e24so16984355oig.11 for ; Mon, 27 Sep 2021 11:59:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eV+PRo6a2MRz/DpkFNL4n5kAGNJtpr9EpyO3zFy3ARk=; b=g3+G2l6MFqmYLBYPH+jJY3hW4U5Cfnwv5BzEPdS7s+QXx7374w4pK0cltOXrBS5k9/ kDgxEDxnZisSGUIfJopl4nSEQo/jldhgJ1C5GmY1YvK9DU2yoz7IOQPsMoDqDVdvHQpI 7uUPnFzwQeCJx0YUNALMEXZ3TC2CckqaDhbmWfMQKfZWD4B3aDwIF5052WKHw23pQs4q bl/TMVjYZhR9wzCBnZrqDZJMYCM76XYlKQcxUDjz5A5DckU+SX8z6BqFIVl3S4Ps8GsS l68xgbu9AnogN1vAYtmzVUPww/95vFXhOs+M+t/wGAbZi65PvPJ/sN90sn24fd9/8NNR ltDA== X-Gm-Message-State: AOAM532d+vLhs6f1r8AXd8p2REmZBD8LT+823lGsUnhJUnUBBB5YjPIM qD3vF5s8nf1D2i+vNXr6EZTBxlpxIg== X-Google-Smtp-Source: ABdhPJwMJelZ7z1gOyM6KU2hxuI5UxVhhaZKlukjtCf2pvupYDr2rXhjepC7YZIdsEs7BDBH3vdEvw== X-Received: by 2002:aca:604:: with SMTP id 4mr520177oig.8.1632769152914; Mon, 27 Sep 2021 11:59:12 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id p64sm4054025oih.29.2021.09.27.11.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 11:59:12 -0700 (PDT) Received: (nullmailer pid 3666744 invoked by uid 1000); Mon, 27 Sep 2021 18:59:11 -0000 Date: Mon, 27 Sep 2021 13:59:11 -0500 From: Rob Herring To: Chin-Ting Kuo Cc: joel@jms.id.au, mturquette@baylibre.com, sboyd@kernel.org, adrian.hunter@intel.com, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, andrew@aj.id.au, BMC-SW@aspeedtech.com, steven_lee@aspeedtech.com Subject: Re: [PATCH 10/10] dt-bindings: mmc: aspeed: Add a new compatible string Message-ID: References: <20210922103116.30652-1-chin-ting_kuo@aspeedtech.com> <20210922103116.30652-11-chin-ting_kuo@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210922103116.30652-11-chin-ting_kuo@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_115914_473220_EFEBB95B X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 22, 2021 at 06:31:16PM +0800, Chin-Ting Kuo wrote: > Add "aspeed,ast2600-emmc" compatible string for the sake of > distinguishing between SD and eMMC device. Why? Is the h/w block different? We already have properties to handle some of the eMMC specifics. Also, you can have a child node for the eMMC device if you need that. > > Signed-off-by: Chin-Ting Kuo > --- > Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > index 5bb66849df65..41105cd104c6 100644 > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > @@ -52,6 +52,7 @@ patternProperties: > - aspeed,ast2400-sdhci > - aspeed,ast2500-sdhci > - aspeed,ast2600-sdhci > + - aspeed,ast2600-emmc > reg: > maxItems: 1 > description: The SDHCI registers > -- > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel