From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB7FCC433F5 for ; Mon, 27 Sep 2021 20:43:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95B4A610FC for ; Mon, 27 Sep 2021 20:43:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 95B4A610FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5x1cISau4EQkbgHv/5CbKwPjOX8W5OjD52jCn6fCHKg=; b=pbLiZUkZDZ6s+L 80VGEP0I9Rpy2BBHU+3hX41EXRi5hTK5zYfUi6TGMGkwNCCEGt34irZTLRTLg0K6eLJmFa3e6gZvR 9VqNKNglyYZoO7llRtpTR6A8TrUGJ/+3CNwLetEy5BKfkLoVpYYud7bHiy5A0BDY3V0e63DpwpRRo 9F132nUu9atvYznYt15yLrf9gxlkueGMuZFDre+0xD7DPCHtKvHv0f0wbF59EByv9zVNZQKLDsFrE NVTBh+ZOmT5ey+t6FgOYI6hWRBZCfCksayRqMxElynilTuFnFCaF/1GHtaPM0qJSIOOUZcIllJ34/ wYlmQ1Arfc4L6ZeDT4nA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUxRl-004DMt-2O; Mon, 27 Sep 2021 20:41:57 +0000 Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUxRc-004DJf-Tj for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 20:41:50 +0000 Received: by mail-ot1-x329.google.com with SMTP id r43-20020a05683044ab00b0054716b40005so19246085otv.4 for ; Mon, 27 Sep 2021 13:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pUZgLCnNelRAaV+g7H8XGqFTT9YZLErJSXLJYla4RJo=; b=dCoaJUF0HSoSC1tmNX6q8Fh6kJv7c6jk49XmhH2vq1ANKmz6EeVyVtD2Pcxxxh8aXz /W0bzAWmoH3iHlFtKt4RHhcy9v4nMv6BEyBk34D8UUa8oCh+yyJJBwKYrK5zxFL+VJ5W mmk25gMJbff0s4JgjQlL73M1frtzFLhhSSeKsoMfON0N7To1FwqmZevw+vpH964FuN5+ VDs07R1JX2daPpe7GTVjL3t8b85VIkNR+VDjVjC7aEfatwsh4ieB21gaSPHVc9FrfLe4 JK9GpMcv5K/VRzrKmX8WZg1LZAmnWcollVG6hxmBajWBFIxazJts7JTsm6AsqVhgOO/o pUCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pUZgLCnNelRAaV+g7H8XGqFTT9YZLErJSXLJYla4RJo=; b=wmn5gc0TJ/jiEBFCJQQmiFMZIFWn49wwYMtPDj0FLLZgpb+/53t1M32Cx/iecpun/q eDNwy68RrAAVCUxSn7jCB1r64EzWtgmfb946oYR7hvZC+NXJRWj1oNTv0HBQdPY9AP2W TXGlPJlrNCu28/++T1aHvQKAyYO64PBfXev95ae6xV1HUweBYqEFPq27IU2Y8bARf0Wk maejjHxpHGnrIP0IuCx4bObAlgLfvY1UD1yWXavx1m7arIZTsGVtyJMzcJNYJnkMqA2V VpinqCNwBS9pwAAQCKqUP8yiRxxZEV9LeV+7zbWnHAuuP1H+2VyaROKffT1Kgu1GMwWV t5xg== X-Gm-Message-State: AOAM532qXjQi7b3lwTTjE/24G6o/OEFaQxVNC+mCZrCcA//uyOq0bmvc SFaEfktEFjf0LwM+yg2yARMk3A== X-Google-Smtp-Source: ABdhPJydeIzDJHtHzGeBz5+87mWnwkDNbaEe+ql2n9gGjNC+NklvZH2OYxM0vWlXO7E/L2MFCogIbA== X-Received: by 2002:a9d:6a0f:: with SMTP id g15mr1832465otn.126.1632775307597; Mon, 27 Sep 2021 13:41:47 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id a8sm4414108oos.46.2021.09.27.13.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 13:41:47 -0700 (PDT) Date: Mon, 27 Sep 2021 13:42:22 -0700 From: Bjorn Andersson To: Arnd Bergmann Cc: John Stultz , Arnd Bergmann , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Joerg Roedel , Will Deacon , Mauro Carvalho Chehab , Ulf Hansson , Alex Elder , "David S. Miller" , Jakub Kicinski , Kalle Valo , Andy Gross , Linus Walleij , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Linux Kernel Mailing List , linux-arm-msm , dri-devel , freedreno , "open list:IOMMU DRIVERS" , Linux Media Mailing List , linux-mmc , Networking , ath10k@lists.infradead.org, linux-wireless , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-sunxi@lists.linux.dev Subject: Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol Message-ID: References: <20210927152412.2900928-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_134149_007882_173E5B6F X-CRM114-Status: GOOD ( 29.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 27 Sep 13:15 PDT 2021, Arnd Bergmann wrote: > On Mon, Sep 27, 2021 at 9:52 PM Bjorn Andersson > wrote: > > On Mon 27 Sep 08:22 PDT 2021, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > - To avoid a circular dependency chain involving RESET_CONTROLLER > > > and PINCTRL_SUNXI, change the 'depends on RESET_CONTROLLER' in > > > the latter one to 'select'. > > > > Can you please help me understand why this is part of the same patch? > > This can be done as a preparatory patch if we decide to do it this way, > for the review it seemed better to spell out that this is required. > > I still hope that we can avoid adding another 'select RESET_CONTROLLER' > if someone can figure out what to do instead. > Okay, thanks. > The problem here is that QCOM_SCM selects RESET_CONTROLLER, > and turning that into 'depends on' would in turn mean that any driver that > wants to select QCOM_SCM would have to have the same RESET_CONTROLLER > dependency. > Right, and that will just be another thing we'll get wrong across the tree. > An easier option might be to find a way to build QCOM_SCM without > RESET_CONTROLLER for compile testing purposes. I don't know > what would break from that. > Afaict the reset API is properly stubbed and RESET_CONTROLLER is a bool, so I think we can simply drop the "select" and the kernel will still compile fine in all combinations. When it comes to runtime, we currently select RESET_CONTROLLER from the Qualcomm common clocks. If that is dropped (why would it...) it seems possible to build a custom kernel for msm8916 that we can boot and miss the stubbed out "mss restart" reset line from the SCM. So, let's just drop the select RESET_CONTROLLER from SCM for now. Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel